From nobody Tue Feb 10 03:37:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583580770; cv=none; d=zohomail.com; s=zohoarc; b=C373MiuJ76KkikpjUdVbENlXJXud3yxqRtZsCxKGCgTCeNOtfo7kyXXvIUsbIFNsinwOAAHlh5cG3jMPwTFPyWQh1NChlaNUFWOuEfpE8apEl3MaS2kJRe1sZxCVHnNmKCYzOYO7mYRxggjmSLkMSOnsM1Ua9MTaA+2Lfqz2PpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583580770; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vTyoW/p+w8nC99XNRjlzxTWh8fTjeTCdpG2bX1n+b9Y=; b=Q7r4dPgi8OiXTC6ecWcWXQMlHGDr1aIvo+TFnbCbakOPk/cqKEN2aTPz9J0j0WiqyBV92VEwx6dLCNc2b8nBac6Q9lpvOIrJzC5XtPEyGJdfDw+tEnCX+CFzy9vYI5XlcyOa2SpbbESqvOwtdWD03GfqyKOFBoQIsFlkBu4u1Nw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1583580770178823.5166247882954; Sat, 7 Mar 2020 03:32:50 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-0TG7I5WuOY6LYV39u2GMtQ-1; Sat, 07 Mar 2020 06:32:47 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B9348017DF; Sat, 7 Mar 2020 11:32:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 413831BC6D; Sat, 7 Mar 2020 11:32:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB0EF86A0A; Sat, 7 Mar 2020 11:32:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 027BW8hG001026 for ; Sat, 7 Mar 2020 06:32:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id E39502166B2D; Sat, 7 Mar 2020 11:32:07 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF1302166B28 for ; Sat, 7 Mar 2020 11:32:05 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B21848BA508 for ; Sat, 7 Mar 2020 11:32:05 +0000 (UTC) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-MhckmoFcNHy7EGMcfure0g-1; Sat, 07 Mar 2020 06:32:03 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 058A0B7AEC7084D8C1A2 for ; Sat, 7 Mar 2020 19:32:00 +0800 (CST) Received: from huawei.com (10.133.210.227) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Sat, 7 Mar 2020 19:31:52 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583580769; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vTyoW/p+w8nC99XNRjlzxTWh8fTjeTCdpG2bX1n+b9Y=; b=Ffyz2ohwUoevHcqv9YPpKFxb4quCEoVvna4PUo63N/0CL/5pf+gmFhNgOdOpoJTtxQ+a8t 8M0lrjbz4zihp2AM9iyhjtNY3cJxD2xti3jryiXgQLksmPSwXx5PE4NM8mGnbiCxKdR2kw 2mFBnbnCDp3rztAKL+638aNFFqRYIyE= X-MC-Unique: 0TG7I5WuOY6LYV39u2GMtQ-1 X-MC-Unique: MhckmoFcNHy7EGMcfure0g-1 From: Zhang Bo To: Subject: [PATCHv2 2/5] tls: Add a mutex lock on 'tlsCtxt' Date: Sat, 7 Mar 2020 19:31:01 +0800 Message-ID: <20200307113104.722-3-oscar.zhangbo@huawei.com> In-Reply-To: <20200307113104.722-1-oscar.zhangbo@huawei.com> References: <20200307113104.722-1-oscar.zhangbo@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.210.227] X-CFilter-Loop: Reflected X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 027BW8hG001026 X-loop: libvir-list@redhat.com Cc: Zhang Bo , dengkai1@huawei.com, wujing42@huawei.com, wuqingliang4@huawei.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Prevent the handshake function from reading 'tlsCtxt' while updating 'tlsCtxt'. --- src/rpc/virnetserverclient.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 4d85ee25d7..657108239f 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1114,7 +1114,9 @@ int virNetServerClientInit(virNetServerClientPtr clie= nt) client->tls); =20 /* Begin the TLS handshake. */ + virObjectLock(client->tlsCtxt); ret =3D virNetTLSSessionHandshake(client->tls); + virObjectUnlock(client->tlsCtxt); if (ret =3D=3D 0) { /* Unlikely, but ... Next step is to check the certificate. */ if (virNetServerClientCheckAccess(client) < 0) @@ -1435,7 +1437,9 @@ virNetServerClientDispatchHandshake(virNetServerClien= tPtr client) { int ret; /* Continue the handshake. */ + virObjectLock(client->tlsCtxt); ret =3D virNetTLSSessionHandshake(client->tls); + virObjectUnlock(client->tlsCtxt); if (ret =3D=3D 0) { /* Finished. Next step is to check the certificate. */ if (virNetServerClientCheckAccess(client) < 0) --=20 2.23.0.windows.1