From nobody Mon Feb 9 10:27:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583316843; cv=none; d=zohomail.com; s=zohoarc; b=IvnkbgbWpi+Ab/3BYRbRxGaY63eD3L8iHzlAOpH/x9QDJ3YAgcAMSAIRvYKRG9qpLfZ1v9f6/tliM3VAp9QEyq9ygeEd3qdytRMXhyAuCUBgwkceJA7QGuXUSze0fH3tbGO+pd/Ck/4+aZgRUt8bOlYYqT1sx22t76RTrr9WDU4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583316843; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uWlqf70y83wrG7KwYPA3IJoOrRqvzvq8+oEwTJbWJuI=; b=QpB8ss3GL8XbeWh2bLIN+kAJ2rPUfgZSFzHNm6UXCMdYXC+6vHV+6v7lcrOwh1Iew+KuvgxL9TV1THsBYo12jCGvXShIeu+M7hjOEq6nglFRFfctTc6EisszE9yo5wYkmwzYMB86OrmU7OSbckj7hz2ozWG5LWv6O/GA3K0ovTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1583316843794370.39386734616335; Wed, 4 Mar 2020 02:14:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-HqtEMcv8MEeqfKUQLtgngg-1; Wed, 04 Mar 2020 05:13:09 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E9AD101FC6A; Wed, 4 Mar 2020 10:13:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19DEB5C54A; Wed, 4 Mar 2020 10:13:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A94BB18089D5; Wed, 4 Mar 2020 10:13:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 024AClbW030667 for ; Wed, 4 Mar 2020 05:12:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id 56D955DA87; Wed, 4 Mar 2020 10:12:47 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.43.2.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id A716E5DA83; Wed, 4 Mar 2020 10:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583316842; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uWlqf70y83wrG7KwYPA3IJoOrRqvzvq8+oEwTJbWJuI=; b=c93BsbxpdUY1pTJaa6xov2O4fNmx3PZw36CMmFAhiILrCX+0EF9xr9O8FQZQUIJXkcEV1S Z1gkXVwtZAJVcXTOQC7V+XYlX9ri+4IIOLvVmq4CqD+KGQxayM5kamxDyHo7AqNQzdjGbe L28NnoFrtTvTXVOMcfDGjgYifGsxaoE= X-MC-Unique: HqtEMcv8MEeqfKUQLtgngg-1 From: Pavel Mores To: libvir-list@redhat.com Subject: [libvirt PATCH 2/6] qemu: block: pull job extended with 'top' parameter Date: Wed, 4 Mar 2020 11:12:36 +0100 Message-Id: <20200304101240.1139700-3-pmores@redhat.com> In-Reply-To: <20200304101240.1139700-1-pmores@redhat.com> References: <20200304101240.1139700-1-pmores@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Pavel Mores X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" 'top' member added to qemuBlockJobPullData and the job's "constructor" func= tion qemuBlockJobDiskNewPull() and its invocation changed to support the new mem= ber. Signed-off-by: Pavel Mores --- src/qemu/qemu_blockjob.c | 2 ++ src/qemu/qemu_blockjob.h | 2 ++ src/qemu/qemu_driver.c | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 71df0d1ab2..e19a2ad76b 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -253,6 +253,7 @@ qemuBlockJobDataPtr qemuBlockJobDiskNewPull(virDomainObjPtr vm, virDomainDiskDefPtr disk, virStorageSourcePtr base, + virStorageSourcePtr top, unsigned int jobflags) { qemuDomainObjPrivatePtr priv =3D vm->privateData; @@ -270,6 +271,7 @@ qemuBlockJobDiskNewPull(virDomainObjPtr vm, return NULL; =20 job->data.pull.base =3D base; + job->data.pull.top =3D top; job->jobflags =3D jobflags; =20 if (qemuBlockJobRegister(job, vm, disk, true) < 0) diff --git a/src/qemu/qemu_blockjob.h b/src/qemu/qemu_blockjob.h index 72c7fa053e..7223b4abb8 100644 --- a/src/qemu/qemu_blockjob.h +++ b/src/qemu/qemu_blockjob.h @@ -77,6 +77,7 @@ typedef qemuBlockJobPullData *qemuBlockJobDataPullPtr; =20 struct _qemuBlockJobPullData { virStorageSourcePtr base; + virStorageSourcePtr top; }; =20 =20 @@ -177,6 +178,7 @@ qemuBlockJobDataPtr qemuBlockJobDiskNewPull(virDomainObjPtr vm, virDomainDiskDefPtr disk, virStorageSourcePtr base, + virStorageSourcePtr top, unsigned int jobflags); =20 qemuBlockJobDataPtr diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 81cca360e0..7970c913f3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17398,7 +17398,7 @@ qemuDomainBlockPullCommon(virDomainObjPtr vm, speed <<=3D 20; } =20 - if (!(job =3D qemuBlockJobDiskNewPull(vm, disk, baseSource, /*topSourc= e, */flags))) + if (!(job =3D qemuBlockJobDiskNewPull(vm, disk, baseSource, topSource,= flags))) goto endjob; =20 if (blockdev) { --=20 2.24.1