From nobody Sat Feb 7 15:22:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1582998740; cv=none; d=zohomail.com; s=zohoarc; b=Zt99bWMrsHQbRwoML2kVVqB5ZJgkkdc9jaCwb+VooyW4B9679qDbK3dV7kUg1fbuarrMk46R6w0IneuQLRaXaeyE3ajeJcz5NrjE1T0N7juhFUxemSpWwAiBjhvJ0sFBTxzXr4uQ8Uw7oJVA8FiMjUOglii5Atvgjq3ccw1Zik4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582998740; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dG/cv+U2VZu5CccBxFDHmVJ4lEdWpta45QhZ9xIAAQE=; b=DL4mDj/nxCZpMpTQIUfK0pc2QzkrmQx3LPVarZDIVabOzk83vAvw+ZXODmjw/M7jnuKVckVy5TWC2NHMsB+mqmvhWnBWDi4g10Qlowb9jQhniVncv8as9fl1H/Z/ni0a9zGFDX8XMXZ4UjjmLWeLxuJFW2L5SIzi7aPIvxSh4YQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1582998740771401.8902316104163; Sat, 29 Feb 2020 09:52:20 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-pMTJs_HfPoqorpLOU-fUVw-1; Sat, 29 Feb 2020 12:52:16 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0F68107ACC5; Sat, 29 Feb 2020 17:52:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9995E87B0A; Sat, 29 Feb 2020 17:52:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F51784484; Sat, 29 Feb 2020 17:52:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01THpeOQ014218 for ; Sat, 29 Feb 2020 12:51:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3AEDADBF02; Sat, 29 Feb 2020 17:51:40 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36C64DA673 for ; Sat, 29 Feb 2020 17:51:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 762B28007A4 for ; Sat, 29 Feb 2020 17:51:37 +0000 (UTC) Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-dlD2Ad_0N96X8Fa0H__bgQ-1; Sat, 29 Feb 2020 12:51:35 -0500 Received: by mail-qv1-f66.google.com with SMTP id ea1so2933867qvb.7 for ; Sat, 29 Feb 2020 09:51:35 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c7:8749:2052:fc6c:a4b4:ccbc]) by smtp.gmail.com with ESMTPSA id b5sm7158282qkh.58.2020.02.29.09.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Feb 2020 09:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582998739; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dG/cv+U2VZu5CccBxFDHmVJ4lEdWpta45QhZ9xIAAQE=; b=aN6460UDyZTUG5pg/t0+N9ZE6sIH2yBN0cmtphbHQpNM1j1jtFOTJLDlDEgoNiVu0A02ro TCDex0C3P3zMdfFcpKdlBCqxvDdaRnUpQQpwZKbbGc/XLMIC7fwErPpHgPyaSf7BwHB7xY 3YWXw79qG3Gz60W4sBMZj7Gd3xHQJzI= X-MC-Unique: pMTJs_HfPoqorpLOU-fUVw-1 X-MC-Unique: dlD2Ad_0N96X8Fa0H__bgQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5CY76MxSiqMTEF3qBPbJHSyZtW+z/HRYYiwpTSw7Hbc=; b=cePfsOIleqvxovdA3deySZ9h2lHiwY6jJw4M/zecFQ72TmmduTmdAZyOeoVMBwVMHG RSr0FxB7EJCt3O3kWLibHIZfJ1gMkdik0w2AJKr6d/V1/QIg1dZrofMINtkt19c5j01u 9ziZTBc8I+W+1eGIR094pUlltZkyta/ZOrJNRK+GmnaLB1riA3p2S6GZ4RWVQy42GCMk NkKb0OM7uvBTLqDLM1F3wJt5rHGkdU4z3u9rdXti8X5uxuK28pS9Lqs1+84t+wmB43AE 70fwz2OapUod9kZDNaIXGR7nu6A5XPdTd9Z8V2t8zfhG3GEHXdZqbHXY+e1HhJwKZohV wipQ== X-Gm-Message-State: APjAAAU+XlWbojGkIo8RvWj5c2ojGlUOulMVqe8LC5paWJ+9LSdSNfgL vyAr+WnHBdms2geK4gIt7hZCXL8ET0o= X-Google-Smtp-Source: APXvYqzHiTtGXoUn4et9T/0mXYYEcVl98PkEe+K2BDIlAl+o6+HyX2lpRFTn4XmriOpgu+voBWdpKg== X-Received: by 2002:ad4:4650:: with SMTP id y16mr8424174qvv.216.1582998694529; Sat, 29 Feb 2020 09:51:34 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 3/3] qemu_domain.c: remove qemuDomainMemoryDeviceAlignSize() Date: Sat, 29 Feb 2020 14:51:14 -0300 Message-Id: <20200229175114.376223-4-danielhb413@gmail.com> In-Reply-To: <20200229175114.376223-1-danielhb413@gmail.com> References: <20200229175114.376223-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 01THpeOQ014218 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Previous patch removed all the callers of the function. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 16 ---------------- src/qemu/qemu_domain.h | 2 -- 2 files changed, 18 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 27f400005e..1c22bba052 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12386,22 +12386,6 @@ qemuDomainAlignMemorySizes(virDomainDefPtr def) } =20 =20 -/** - * qemuDomainMemoryDeviceAlignSize: - * @mem: memory device definition object - * - * Aligns the size of the memory module as qemu enforces it. The size is u= pdated - * inplace. Default rounding is now to 1 MiB (qemu requires rouding to pag= e, - * size so this should be safe). - */ -void -qemuDomainMemoryDeviceAlignSize(virDomainDefPtr def, - virDomainMemoryDefPtr mem) -{ - mem->size =3D VIR_ROUND_UP(mem->size, qemuDomainGetMemorySizeAlignment= (def)); -} - - /** * qemuDomainGetMonitor: * @vm: domain object diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index d27d7e78d9..efd65be779 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -956,8 +956,6 @@ bool qemuDomainHasBlockjob(virDomainObjPtr vm, bool cop= y_only) ATTRIBUTE_NONNULL(1); =20 int qemuDomainAlignMemorySizes(virDomainDefPtr def); -void qemuDomainMemoryDeviceAlignSize(virDomainDefPtr def, - virDomainMemoryDefPtr mem); =20 virDomainChrDefPtr qemuFindAgentConfig(virDomainDefPtr def); =20 --=20 2.24.1