[libvirt PATCH] tests: fix missing test data for network port XML

Daniel P. Berrangé posted 1 patch 4 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200225110935.1413037-1-berrange@redhat.com
tests/virnetworkportxml2xmldata/plug-network.xml | 5 +++++
tests/virnetworkportxml2xmltest.c                | 1 +
2 files changed, 6 insertions(+)
[libvirt PATCH] tests: fix missing test data for network port XML
Posted by Daniel P. Berrangé 4 years, 1 month ago
The network port XML files were not including any usage of vlan
tags or port options, and one of the files was not even processed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/virnetworkportxml2xmldata/plug-network.xml | 5 +++++
 tests/virnetworkportxml2xmltest.c                | 1 +
 2 files changed, 6 insertions(+)

diff --git a/tests/virnetworkportxml2xmldata/plug-network.xml b/tests/virnetworkportxml2xmldata/plug-network.xml
index a3a8899148..8e7fc6d010 100644
--- a/tests/virnetworkportxml2xmldata/plug-network.xml
+++ b/tests/virnetworkportxml2xmldata/plug-network.xml
@@ -10,6 +10,11 @@
     <inbound average='1000' peak='4000' floor='2000' burst='1024'/>
     <outbound average='128' peak='256' burst='32768'/>
   </bandwidth>
+  <vlan trunk='yes'>
+    <tag id='2'/>
+    <tag id='1729'/>
+  </vlan>
+  <port isolated='yes'/>
   <rxfilters trustGuest='yes'/>
   <plug type='network' bridge='virbr0'/>
 </networkport>
diff --git a/tests/virnetworkportxml2xmltest.c b/tests/virnetworkportxml2xmltest.c
index 1b2175dd9d..039da96490 100644
--- a/tests/virnetworkportxml2xmltest.c
+++ b/tests/virnetworkportxml2xmltest.c
@@ -94,6 +94,7 @@ mymain(void)
     DO_TEST("plug-bridge-mactbl");
     DO_TEST("plug-direct");
     DO_TEST("plug-hostdev-pci");
+    DO_TEST("plug-network");
 
     return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }
-- 
2.24.1

Re: [libvirt PATCH] tests: fix missing test data for network port XML
Posted by Michal Privoznik 4 years, 1 month ago
On 2/25/20 12:09 PM, Daniel P. Berrangé wrote:
> The network port XML files were not including any usage of vlan
> tags or port options, and one of the files was not even processed.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/virnetworkportxml2xmldata/plug-network.xml | 5 +++++
>   tests/virnetworkportxml2xmltest.c                | 1 +
>   2 files changed, 6 insertions(+)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal