From nobody Sun May 5 05:21:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582570766; cv=none; d=zohomail.com; s=zohoarc; b=jzEUVVqzgov8EwgbCvLNoZxZygM3O19hUyF2svRM63QFdyOL+uIynqVCsv1F7Oc/z/Ilc91U56E8wDR7+8epaPssz1puY8MRxPYh5xO+UiKvjCUJVdJBkMkpQMGDbWzvUNSAiumK2gqR7pJsETqhQg2ZN1/izqZ+AExeeQGj8pU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582570766; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=uK2tx/ZmcwanSpMbWHfdvg3wpeibYXkT/wz+A83kf8M=; b=ED7Amo/ygMD+MOx40eunNr5WiyyJuQ9YhuLO2+pfIeBBz68fBhmS1y6V2i6XI0hN4gjyRXXbW5cMJVUdiEe6mnM8uqWyRYoOFf68MXW2gtkpsXygGq0F4wVIbhL3Uoxg/9K/hCHCHTkQE7LmpOpn4PW0Wypd8Laq9vmWFHho+Ig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1582570766352134.60954033786822; Mon, 24 Feb 2020 10:59:26 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-C_edkiQbN52jqmyFdTQ33A-1; Mon, 24 Feb 2020 13:59:20 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF526100550E; Mon, 24 Feb 2020 18:59:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 420C51001B2D; Mon, 24 Feb 2020 18:59:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 477E2860DF; Mon, 24 Feb 2020 18:59:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01OIx8Um009327 for ; Mon, 24 Feb 2020 13:59:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 35DD1DBF30; Mon, 24 Feb 2020 18:59:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F9BCEC4AD for ; Mon, 24 Feb 2020 18:59:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0EFEB1017E46 for ; Mon, 24 Feb 2020 18:59:01 +0000 (UTC) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-gQUxdz_ROC6usMwgXilFmA-1; Mon, 24 Feb 2020 13:58:56 -0500 Received: by mail-pf1-f196.google.com with SMTP id n7so5828755pfn.0; Mon, 24 Feb 2020 10:58:56 -0800 (PST) Received: from localhost.localdomain ([139.5.254.49]) by smtp.gmail.com with ESMTPSA id v8sm13451897pfn.172.2020.02.24.10.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2020 10:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582570765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uK2tx/ZmcwanSpMbWHfdvg3wpeibYXkT/wz+A83kf8M=; b=PYWgsA1tLI4lGcf2Fp4tmaIdFFKMlCj46YZvtzG+IOCVKFX/rfHPaz2ee3RhV3hPFqFAjJ SCqLcHTZNw75aSzMoOTHSXtH+RfRFqZ19F5KnGFITEqi5OqHBNBozWCG3rpz7N0WON7Rbq y//RlREVRVIk44ppfh1v6sACeVd5N5E= X-MC-Unique: C_edkiQbN52jqmyFdTQ33A-1 X-MC-Unique: gQUxdz_ROC6usMwgXilFmA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S7zaPKtZaEmTHl2+p8aNwCuDwjFYnvYrf9x4N7Mlav8=; b=mUn0ugMUPmr6gb8uk7uqtHrFU+q6+HMR6kzcUaKWSXxnXP0mzpaypxm1zJNIaiGZAc 3qsrb+nFE68DJ9x1AGAYw3xiKGQBFaURqPXYv9I6MooVLWxtDr7fKiW0Mi2U6uMHWQgs AvGwv8A2gIgNreQGqXUAr114qAf99On2I0jtbwXe2CHm83q5luKaYhpflb+sqEPDJLsu xEmbICVBdKaiVqQ+dYGOQitKCrZzSoRcwUZyaQfmnGNntWZKUeOa6N6Q3UTlZX0Kaj/8 y4eAvxBgkImjRklxw7gpCTUeo9D3kPzAI/I/AsnJRGv2JHaG83dxbUwaVPTPkmo+rYzZ Dzrw== X-Gm-Message-State: APjAAAU9DipMEFJX2YbGLqvk9fd1JISLWABOJAJSSvAY0qu/30V8IyzY ZmFFrmMAU/o4mO2G4QVbVNcfBLdJFYk= X-Google-Smtp-Source: APXvYqzz5MceB69IrxyLU3oI3hK1l0FUmt6l4VoXpvniHI1EPCMkMCcXGHHzf1SGoA+6rlqHPfGZMQ== X-Received: by 2002:a63:c643:: with SMTP id x3mr51345580pgg.299.1582570735080; Mon, 24 Feb 2020 10:58:55 -0800 (PST) From: Gaurav Agrawal To: libvir-list@redhat.com, crobinso@redhat.com Subject: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors Date: Tue, 25 Feb 2020 00:28:45 +0530 Message-Id: <20200224185845.202506-1-agrawalgaurav@gnome.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 01OIx8Um009327 X-loop: libvir-list@redhat.com Cc: GAURAV AGRAWAL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_= linux.c index 7bbde5c6a9..fde33b5d38 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -22,6 +22,7 @@ #include =20 #include "viralloc.h" +#include "virerror.h" #include "virfile.h" #include "viriptables.h" #include "virstring.h" @@ -53,7 +54,7 @@ static void networkSetupPrivateChains(void) if (rc < 0) { VIR_DEBUG("Failed to create global IPv4 chains: %s", virGetLastErrorMessage()); - errInitV4 =3D virSaveLastError(); + virErrorPreserveLast(&errInitV4); virResetLastError(); } else { virFreeError(errInitV4); @@ -70,7 +71,7 @@ static void networkSetupPrivateChains(void) if (rc < 0) { VIR_DEBUG("Failed to create global IPv6 chains: %s", virGetLastErrorMessage()); - errInitV6 =3D virSaveLastError(); + virErrorPreserveLast(&errInitV6); virResetLastError(); } else { virFreeError(errInitV6); --=20 2.24.1