[PATCH] build: stop running aclocal manually

Daniel P. Berrangé posted 1 patch 4 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200224175017.2716772-1-berrange@redhat.com
autogen.sh | 1 -
1 file changed, 1 deletion(-)
[PATCH] build: stop running aclocal manually
Posted by Daniel P. Berrangé 4 years, 1 month ago
The autoreconf script will already run aclocal for us,
so there's no need todo that ahead of time.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 autogen.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 671dd63eb6..4e1bbceb0a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -15,7 +15,6 @@ cd "$srcdir"
 
 git submodule update --init || exit 1
 
-aclocal --install || exit 1
 autoreconf --verbose --force --install || exit 1
 
 if test "x$1" = "x--system"; then
-- 
2.24.1

Re: [PATCH] build: stop running aclocal manually
Posted by Ján Tomko 4 years, 1 month ago
On Mon, Feb 24, 2020 at 05:50:17PM +0000, Daniel P. Berrangé wrote:
>The autoreconf script will already run aclocal for us,
>so there's no need todo that ahead of time.

s/todo/to do/

>
>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> autogen.sh | 1 -
> 1 file changed, 1 deletion(-)
>

Neat, that's 3.5 s for free.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano