From nobody Mon May 6 13:26:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1582533232; cv=none; d=zohomail.com; s=zohoarc; b=BdpitYryVkgvktar5dRZc35jjV/j9oQEaw5bsY7TPlc8x4aN93pxbiLEKOLkh3U5b7icoEe4IhZgMPSEONyjycKGu2Dl+xaO4H3dIPi8pJR6eudiibqVAoepeAuX1mLB97rEiQAUhuaPd0TepabHPrno/tVIjT79wzcaXBoqnCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582533232; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yKvMYCE9IFghNesnURvxn7ZOUtAHuyBQB0ZMkZIX8V8=; b=fFU/PSJBW2t+/B1L+gag27VerfjzYI14i9dlZutep3Nv0bcx1cOz3W+6NUdNX4ESukOzYFcI9XPIj3XquDIqk3EyhmOR2w2cmxE3RI/v8zpiZw3MHyZN36A4o9rLvDQIopwujQh2lm6o6Odl7iy8Z+ZEBLqZZ92gIhemoRyu51E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1582533232830466.31465387061223; Mon, 24 Feb 2020 00:33:52 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-8jtGmQFgOMmFw07W22wzYA-1; Mon, 24 Feb 2020 03:33:49 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D09AB800D50; Mon, 24 Feb 2020 08:33:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52D4D909E5; Mon, 24 Feb 2020 08:33:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2E016860D2; Mon, 24 Feb 2020 08:33:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01MNMbwo030213 for ; Sat, 22 Feb 2020 18:22:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id BA3A42166B2E; Sat, 22 Feb 2020 23:22:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5DA02166B2B for ; Sat, 22 Feb 2020 23:22:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20DD285A304 for ; Sat, 22 Feb 2020 23:22:35 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-oZjq73rRP6a1vHAWlHqBrg-1; Sat, 22 Feb 2020 18:22:32 -0500 Received: by mail-lj1-f196.google.com with SMTP id x14so5996646ljd.13 for ; Sat, 22 Feb 2020 15:22:31 -0800 (PST) Received: from localhost.localdomain (h-158-174-186-59.NA.cust.bahnhof.se. [158.174.186.59]) by smtp.gmail.com with ESMTPSA id q14sm3687236lfc.60.2020.02.22.15.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2020 15:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582533231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yKvMYCE9IFghNesnURvxn7ZOUtAHuyBQB0ZMkZIX8V8=; b=DhCvhmwk8OgXl57qpR0f33WeRTjdaYUTRJfnW1hWBsa43TsZm0Z7YUBmt4rD0iOzTacFsj J7YcJH7k8/Jtnh2X3qvuH3ftZC9S0grKJLPUZrxEBX1EO7n6XMd9/xHHx0mEQhpF4s1E/L MdHvcLbI+cxLShFLS0sQIPJdKtsJWe0= X-MC-Unique: 8jtGmQFgOMmFw07W22wzYA-1 X-MC-Unique: oZjq73rRP6a1vHAWlHqBrg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Aw+SL7j2Xmy8uKsEqNnYLUy2P6ymt1k21jHWWlYeMf4=; b=XDwPQ1WiUTY/4Qq1V2tjwHMhehvZ1u9lzcHdjXbzJQMDo654K9DzRYDocKjOZWJkAc LnxthFOOQzv96sBN67Vgd7H0FI2m8uthJgr1MFdOjg9rvwhqxPBYS5vvvXYVc5UBYd5N mRL48fGHOr1sM28T0lsYIFzojvJImygcche3Z1Ck1jcL5bLP8eEGMuzkHsQRpcQWn9Hw hdWQddZQBYZ7tCZMAiB0kZnjq7gnrfpFPmyxOI2zFp/RoIVR84HolDaEXQDyJUaE7+q5 YVNlVpMl73OqTgr9A8CdXhvdq/ODSQf16xV9AyxLDy9Gv2Uqc+ueYIeXdw6S3wfHy9kP srVA== X-Gm-Message-State: APjAAAXpAMcy3OK3iKb856UwxPruqQMHVlLEZzpdGBBqrkw4AZgcIIMQ wlaEBtLuUjSL6N2YaTZ2YY92mH3kuvQ= X-Google-Smtp-Source: APXvYqx8JyfFekm/5HCt7ge1l5fGvksnt+zi5XlhDHDxPo271mwrqxkOotCapXahrtfbBELYd/I2cA== X-Received: by 2002:a2e:8544:: with SMTP id u4mr26026530ljj.31.1582413750530; Sat, 22 Feb 2020 15:22:30 -0800 (PST) From: Rikard Falkeborn To: libvir-list@redhat.com Subject: [libvirt PATCH] esx: Same order of arguments in definition and declaration Date: Sun, 23 Feb 2020 00:22:25 +0100 Message-Id: <20200222232225.192648-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 01MNMbwo030213 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Mon, 24 Feb 2020 03:33:38 -0500 Cc: Rikard Falkeborn X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The order of arguments were not the same in the definition and declaration. All callers use the same order as the definition, so there is no bug, but change the function declaration to match the implementation to avoid confusion. Signed-off-by: Rikard Falkeborn Reviewed-by: J=C3=A1n Tomko --- src/esx/esx_vi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h index 5c60fd58f4..b960c0900a 100644 --- a/src/esx/esx_vi.h +++ b/src/esx/esx_vi.h @@ -204,8 +204,8 @@ struct _esxVI_Context { =20 int esxVI_Context_Alloc(esxVI_Context **ctx); void esxVI_Context_Free(esxVI_Context **ctx); -int esxVI_Context_Connect(esxVI_Context *ctx, const char *ipAddress, - const char *url, const char *username, +int esxVI_Context_Connect(esxVI_Context *ctx, const char *url, + const char *ipAddress, const char *username, const char *password, esxUtil_ParsedUri *parsedU= ri); int esxVI_Context_LookupManagedObjects(esxVI_Context *ctx); int esxVI_Context_LookupManagedObjectsByPath(esxVI_Context *ctx, const cha= r *path); --=20 2.25.1