From nobody Tue Nov 26 08:39:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=ixsystems.com ARC-Seal: i=1; a=rsa-sha256; t=1582353606; cv=none; d=zohomail.com; s=zohoarc; b=QJp0oFKN4LBl6yxgr61J+K+fKllIYHmiFuwseiXyH3zIfFpjmSmx/l9HBbDNGTXIpPmGbBAOwKneDM3qSZznauacIU4C49SVZrfwhJTFabpTVo3tcd5rzcXYyJMtR4zyzohmXCxpxgls5oSwEWfWDIRwobGm2RvA9gu03dHou00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582353606; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BvjK3lVN6YYG4jkKhWkC2HoA91yxqzVbnaWPTNKwugI=; b=kRO2zQ/Dp4UbT0sE5ggy4HEu95d1fgcPUoKXkGYvu++4MHRlrhvm2rTVMFblildLqybP5YQNjgVDWzIy9lC3NIkbCNTXNO31fJmUrvXzmFLowyMepX0H/zrpEecdBbuVG0c6OAcdhVzbXIra3S7qv7TxS+MzBTeFDzRQdRQPqHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1582353606029912.0049381896597; Fri, 21 Feb 2020 22:40:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-L2-TxL5QPa6DPbcuwQLgDQ-1; Sat, 22 Feb 2020 01:40:02 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B279D1005510; Sat, 22 Feb 2020 06:39:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87F4D60C87; Sat, 22 Feb 2020 06:39:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3F363860D5; Sat, 22 Feb 2020 06:39:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01M6dVqH021686 for ; Sat, 22 Feb 2020 01:39:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5DED41032530; Sat, 22 Feb 2020 06:39:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 594791032523 for ; Sat, 22 Feb 2020 06:39:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 351D2185A78F for ; Sat, 22 Feb 2020 06:39:29 +0000 (UTC) Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-HG9K5zoSPcq1TR8cidDdMQ-1; Sat, 22 Feb 2020 01:39:27 -0500 Received: by mail-yw1-f67.google.com with SMTP id i126so2628527ywe.7 for ; Fri, 21 Feb 2020 22:39:27 -0800 (PST) Received: from xeon-freebsd.freqlabs.com. (69-228-200-148.lightspeed.knvltn.sbcglobal.net. [69.228.200.148]) by smtp.gmail.com with ESMTPSA id c84sm2482131ywa.1.2020.02.21.22.39.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 22:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582353604; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BvjK3lVN6YYG4jkKhWkC2HoA91yxqzVbnaWPTNKwugI=; b=bJtyeSHwwYNu3vt3PDQm1kpdBbQaMnnShLHsgAmtOYyDm0ot5+fUvjVgsYdInYPntzx6aJ Y+OYF2GX2ITUq6DuBIkfWwTNY7k60cQsa+UdjrG0oqtRCKAuehhedxYqw4lZ9kCXXd2lh3 ZWrkZNFuHhprTcTLfcX+BT2uNwX2Ih0= X-MC-Unique: L2-TxL5QPa6DPbcuwQLgDQ-1 X-MC-Unique: HG9K5zoSPcq1TR8cidDdMQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xbGOSJx65rrTxio/MbUsElJcbqwpboECb3kLNRuRv5E=; b=jTyW35J9qifmuupX5npsjUt1uZGIMQVObEwKonDsEzlR6YFPi0Kk/vh3VqCc4/4MS/ 1k17sWz5I9KRAQitwZ7/Qxem/Rddgr9P1tn0skY6+qUXAr+JeAzVcIzuB1CrzREZS73d JcPaPMLq+W7FVSp3K27RjWWy8jA1w6f6lNN4VZyd29jPQnpKpmN5hMIitYqJRnWpjYmF rLbq2EgQTxDLUxd7CegmGoLtC3Rez2yk491M7B5r2ZyAWkaKUi+SwOACNlZGokOg41oo nyBXCzf5LE+QNHZmVRg9QWAVNECcarhrjET3ugdhbLsrzWw33R62P4wRlSQK2BBC5wj7 W8cQ== X-Gm-Message-State: APjAAAV1u2fzxJcRxmrAmLN3RKLf0QO46J+1s8b+42MFIDlO+olZlTyd g5yT3SnZZxSpokZcEHHr6mUAL8AMIpNcwhx8KIa3oPprT/Zf8XBZOKy+HfPQERBIiwD6Rq2vXS2 iPv+PDizsxm89HmO2fnVrgsDE5PV6armIsOxXdVoQtJUL4zUOpfS8hEmgY6/71t+K2Qk= X-Google-Smtp-Source: APXvYqxZxgyDYJtckLo46eSxxlvhO5MjdARV+UfVHvyVtksLE/BlNJo22p4IRnYUO1yNxHrasS2Gcw== X-Received: by 2002:a25:8081:: with SMTP id n1mr40450976ybk.398.1582353566454; Fri, 21 Feb 2020 22:39:26 -0800 (PST) From: Ryan Moeller X-Google-Original-From: Ryan Moeller To: libvir-list@redhat.com Subject: [PATCH 05/16] Eliminate rc variable Date: Sat, 22 Feb 2020 01:38:44 -0500 Message-Id: <20200222063855.89637-6-ryan@iXsystems.com> In-Reply-To: <20200222063855.89637-1-ryan@iXsystems.com> References: <20200222063855.89637-1-ryan@iXsystems.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 01M6dVqH021686 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Ryan Moeller Reviewed-by: J=C3=A1n Tomko --- src/bhyve/bhyve_monitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_monitor.c b/src/bhyve/bhyve_monitor.c index b9ad4520d9..0e55e19772 100644 --- a/src/bhyve/bhyve_monitor.c +++ b/src/bhyve/bhyve_monitor.c @@ -130,7 +130,6 @@ bhyveMonitorOpen(virDomainObjPtr vm, bhyveConnPtr drive= r) { bhyveMonitorPtr mon =3D NULL; struct kevent kev; - int rc; =20 if (VIR_ALLOC(mon) < 0) return NULL; @@ -145,8 +144,7 @@ bhyveMonitorOpen(virDomainObjPtr vm, bhyveConnPtr drive= r) } =20 EV_SET(&kev, vm->pid, EVFILT_PROC, EV_ADD, NOTE_EXIT, 0, mon); - rc =3D kevent(mon->kq, &kev, 1, NULL, 0, NULL); - if (rc < 0) { + if (kevent(mon->kq, &kev, 1, NULL, 0, NULL) < 0) { virReportError(VIR_ERR_SYSTEM_ERROR, "%s", _("Unable to register process kevent")); goto cleanup; --=20 2.24.1