From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1581085650719644.9731385126204; Fri, 7 Feb 2020 06:27:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-o0Cohju1P9-YgS5qHXQR2Q-1; Fri, 07 Feb 2020 09:27:25 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AD48106BBDE; Fri, 7 Feb 2020 14:27:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BEBA790E5; Fri, 7 Feb 2020 14:27:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 40AD318089CE; Fri, 7 Feb 2020 14:27:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERG0e004467 for ; Fri, 7 Feb 2020 09:27:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id F16D75C28C; Fri, 7 Feb 2020 14:27:16 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77ED55C299 for ; Fri, 7 Feb 2020 14:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085647; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jAySZaAjjurLDvaRKOiWylKgIPOukswSJ3N8/PJavws=; b=NQQ+Umxk9a2tomjzMZ1VV7k9+GM7PK8lTnCwyfPicMEDjPmjzxrZlxFbaaE44fHzvBveLo q3qHfdMSzcwO2Aj3uCskKmN4A1BYPc872oeSslTubkQLfbhd8mwDQRxjgNdpai1F+Up9pE QwCbTCcy4T4+UeDXcI6THTPeZOEndk8= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 1/8] qemu: Use switch statement in qemuBuildCpuCommandLine() Date: Fri, 7 Feb 2020 15:27:01 +0100 Message-Id: <20200207142708.6315-2-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: o0Cohju1P9-YgS5qHXQR2Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Make sure we are taking all possible virDomainTimerNameType values into account. This will make upcoming changes easier. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko Reviewed-by: Masayoshi Mizuma --- src/qemu/qemu_command.c | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0dbd78124b..52a74c7acf 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6594,16 +6594,30 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, for (i =3D 0; i < def->clock.ntimers; i++) { virDomainTimerDefPtr timer =3D def->clock.timers[i]; =20 - if (timer->name =3D=3D VIR_DOMAIN_TIMER_NAME_KVMCLOCK && - timer->present !=3D -1) { - qemuBuildCpuFeature(qemuCaps, &buf, "kvmclock", - !!timer->present); - } else if (timer->name =3D=3D VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK && - timer->present =3D=3D 1) { - virBufferAddLit(&buf, ",hv-time"); - } else if (timer->name =3D=3D VIR_DOMAIN_TIMER_NAME_TSC && - timer->frequency > 0) { - virBufferAsprintf(&buf, ",tsc-frequency=3D%lu", timer->frequen= cy); + switch ((virDomainTimerNameType)timer->name) { + case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: + if (timer->present !=3D -1) { + qemuBuildCpuFeature(qemuCaps, &buf, "kvmclock", + !!timer->present); + } + break; + case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: + if (timer->present =3D=3D 1) + virBufferAddLit(&buf, ",hv-time"); + break; + case VIR_DOMAIN_TIMER_NAME_TSC: + if (timer->frequency > 0) + virBufferAsprintf(&buf, ",tsc-frequency=3D%lu", timer->fre= quency); + break; + case VIR_DOMAIN_TIMER_NAME_PLATFORM: + case VIR_DOMAIN_TIMER_NAME_PIT: + case VIR_DOMAIN_TIMER_NAME_RTC: + case VIR_DOMAIN_TIMER_NAME_HPET: + break; + case VIR_DOMAIN_TIMER_NAME_LAST: + default: + virReportEnumRangeError(virDomainTimerNameType, timer->name); + return -1; } } =20 --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1581085650509900.257427027987; Fri, 7 Feb 2020 06:27:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-2lyjAK8zM2S0lKQ9jtOILg-1; Fri, 07 Feb 2020 09:27:26 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 305FE801F7E; Fri, 7 Feb 2020 14:27:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F35475C3FD; Fri, 7 Feb 2020 14:27:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AC8BB18089CE; Fri, 7 Feb 2020 14:27:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERHvo004472 for ; Fri, 7 Feb 2020 09:27:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id C1C8A5C299; Fri, 7 Feb 2020 14:27:17 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AB835C28C for ; Fri, 7 Feb 2020 14:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MrXJ9GYaMVPphO/FjwNK7CnS6WmHd3jO4wJ3zKeWD70=; b=J8b4VTlTtpFyt7Ax0RHrl60HMUm27gXsCLTS8qHETJLUENg5SnHvoxCjkKiJjzVPiwDhQw fltAdLZjBxeuuZ9FyM7R3qHknIokPiDT8BQcXA1U/3Ju0MpjURbc21A6DU0M2mlTFsWkEf lONH2ER0qMwGcvtAhXsY8zVf65Zjw+c= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 2/8] qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability Date: Fri, 7 Feb 2020 15:27:02 +0100 Message-Id: <20200207142708.6315-3-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 2lyjAK8zM2S0lKQ9jtOILg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We will use this capability to detect whether the QEMU binary supports the kvm-no-adjvtime CPU feature. Reviewed-by: J=C3=A1n Tomko Signed-off-by: Andrea Bolognani Reviewed-by: Masayoshi Mizuma --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + 3 files changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index dd2311cfa9..0e727093bc 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -559,6 +559,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "rng-builtin", "virtio-net.failover", "tpm-spapr", + "cpu.kvm-no-adjvtime", ); =20 =20 @@ -1562,6 +1563,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjec= tPropsMemoryBackendMemfd[] =20 static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsMaxCPU[] =3D { { "unavailable-features", QEMU_CAPS_CPU_UNAVAILABLE_FEATURES }, + { "kvm-no-adjvtime", QEMU_CAPS_CPU_KVM_NO_ADJVTIME }, }; =20 static virQEMUCapsObjectTypeProps virQEMUCapsObjectProps[] =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 2473e64654..e6c5725a76 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -541,6 +541,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ QEMU_CAPS_OBJECT_RNG_BUILTIN, /* -object rng-builtin */ QEMU_CAPS_VIRTIO_NET_FAILOVER, /* virtio-net-*.failover */ QEMU_CAPS_DEVICE_TPM_SPAPR, /* -device tpm-spapr */ + QEMU_CAPS_CPU_KVM_NO_ADJVTIME, /* -cpu ...,kvm-no-adjvtime */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_5.0.0.aarch64.xml index 538b40dd5b..c05cea2eb7 100644 --- a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml @@ -179,6 +179,7 @@ + 4002050 0 61700241 --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1581086077302407.8568052669027; Fri, 7 Feb 2020 06:34:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-Uo1d8CwUPoyW_F-fPv06BQ-1; Fri, 07 Feb 2020 09:27:40 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0202D1081FB3; Fri, 7 Feb 2020 14:27:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5CD2863CC; Fri, 7 Feb 2020 14:27:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 77740866A3; Fri, 7 Feb 2020 14:27:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERIuS004480 for ; Fri, 7 Feb 2020 09:27:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id 92C335C299; Fri, 7 Feb 2020 14:27:18 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B5955C28C for ; Fri, 7 Feb 2020 14:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581086074; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oYtRVe9UkOmnRFGGiSR1DXbvheQx/1t636BZn29OumI=; b=QJlSf1+U4K2ohXPENZIqZix8MAghO6+2plYe/396tOO24s9Q3HN0HptZCI1OGaCmDhGbYx dGDxlPQSOWjN7u7oQhLJpJRvaTGdLE5BKxJ1KgvCNZSIPlEUBYlCpPVA5GyGII0FHqIEap LWtrGg9QXIev3Gy/ooOXQ0qnDqqdNXw= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 3/8] conf: Introduce VIR_DOMAIN_TIMER_NAME_ARMVTIMER Date: Fri, 7 Feb 2020 15:27:03 +0100 Message-Id: <20200207142708.6315-4-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: Uo1d8CwUPoyW_F-fPv06BQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This new timer model will be used to control the behavior of the virtual timer for KVM ARM/virt guests. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko Reviewed-by: Masayoshi Mizuma --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/libxl/libxl_conf.c | 1 + src/libxl/xen_common.c | 1 + src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_domain.c | 3 +++ 7 files changed, 10 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 9577d26c2a..29b6b95357 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1239,6 +1239,7 @@ hpet pit + armvtimer diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 51ae520897..78d964ed9e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1063,6 +1063,7 @@ VIR_ENUM_IMPL(virDomainTimerName, "tsc", "kvmclock", "hypervclock", + "armvtimer", ); =20 VIR_ENUM_IMPL(virDomainTimerTrack, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 2db3c19473..867a9c7661 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1993,6 +1993,7 @@ typedef enum { VIR_DOMAIN_TIMER_NAME_TSC, VIR_DOMAIN_TIMER_NAME_KVMCLOCK, VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK, + VIR_DOMAIN_TIMER_NAME_ARMVTIMER, =20 VIR_DOMAIN_TIMER_NAME_LAST } virDomainTimerNameType; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index ee6b23895c..56deca7b7c 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -359,6 +359,7 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: case VIR_DOMAIN_TIMER_NAME_RTC: case VIR_DOMAIN_TIMER_NAME_PIT: + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unsupported timer type (name) '%s'"), virDomainTimerNameTypeToString(clock.timers[i]-= >name)); diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 415549a42c..9a385eba0d 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -2182,6 +2182,7 @@ xenFormatCPUFeatures(virConfPtr conf, virDomainDefPtr= def) case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: case VIR_DOMAIN_TIMER_NAME_RTC: case VIR_DOMAIN_TIMER_NAME_PIT: + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unsupported timer type (name) '%s'"), virDomainTimerNameTypeToString(def->clock.timer= s[i]->name)); diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 52a74c7acf..71ae1f72e5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6199,6 +6199,7 @@ qemuBuildClockCommandLine(virCommandPtr cmd, case VIR_DOMAIN_TIMER_NAME_TSC: case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: /* Timers above are handled when building -cpu. */ case VIR_DOMAIN_TIMER_NAME_LAST: break; @@ -6609,6 +6610,7 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, if (timer->frequency > 0) virBufferAsprintf(&buf, ",tsc-frequency=3D%lu", timer->fre= quency); break; + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: case VIR_DOMAIN_TIMER_NAME_PLATFORM: case VIR_DOMAIN_TIMER_NAME_PIT: case VIR_DOMAIN_TIMER_NAME_RTC: diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1b4825a539..68348464a8 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5428,6 +5428,9 @@ qemuDomainDefValidateClockTimers(const virDomainDef *= def, return -1; } break; + + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: + break; } } =20 --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1581085757005440.2341353678662; Fri, 7 Feb 2020 06:29:17 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-wWDjB6U1N_Sv92kIjsmlqQ-1; Fri, 07 Feb 2020 09:27:44 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D36B184AED3; Fri, 7 Feb 2020 14:27:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36AE2863CC; Fri, 7 Feb 2020 14:27:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D337B866B5; Fri, 7 Feb 2020 14:27:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERJUI004487 for ; Fri, 7 Feb 2020 09:27:19 -0500 Received: by smtp.corp.redhat.com (Postfix) id 66D315C299; Fri, 7 Feb 2020 14:27:19 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E00D05C3FD for ; Fri, 7 Feb 2020 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085755; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/xkuZDJDonvdd7mfkpR2RpVgOgudksKksCOqcqaYiEk=; b=ijx8E8Ji1AUKKKR6lCdwS194zZmnmVKYmAKhSVdR2PqdNowYHPEKx1/zuptWvHAJLESSPO 32wW/iKI5M6GvqibZjlqZLAiT+fZ8c9tpO+00SjSsk/wAmFcQtqzbceo6vfTPFZ++ht+EL 6m3/pd2Dk6DXPE3a60meUExQiuiI8vQ= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 4/8] qemu: Validate configuration for the armvtimer timer Date: Fri, 7 Feb 2020 15:27:04 +0100 Message-Id: <20200207142708.6315-5-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: wWDjB6U1N_Sv92kIjsmlqQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Its use is limited to certain guest types, and it only supports a subset of all possible tick policies. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko Reviewed-by: Masayoshi Mizuma --- src/qemu/qemu_domain.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 68348464a8..8036886508 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5430,6 +5430,39 @@ qemuDomainDefValidateClockTimers(const virDomainDef = *def, break; =20 case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: + if (def->virtType !=3D VIR_DOMAIN_VIRT_KVM || + !qemuDomainIsARMVirt(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Configuring the '%s' timer is not suppor= ted " + "for virtType=3D%s arch=3D%s machine=3D%s= guests"), + virDomainTimerNameTypeToString(timer->name), + virDomainVirtTypeToString(def->virtType), + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_KVM_NO_ADJVTIME)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Configuring the '%s' timer is not suppor= ted " + "with this QEMU binary"), + virDomainTimerNameTypeToString(timer->name)= ); + return -1; + } + + switch (timer->tickpolicy) { + case -1: + case VIR_DOMAIN_TIMER_TICKPOLICY_DELAY: + case VIR_DOMAIN_TIMER_TICKPOLICY_DISCARD: + break; + case VIR_DOMAIN_TIMER_TICKPOLICY_CATCHUP: + case VIR_DOMAIN_TIMER_TICKPOLICY_MERGE: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("The '%s' timer does not support " + "tickpolicy '%s'"), + virDomainTimerNameTypeToString(timer->name), + virDomainTimerTickpolicyTypeToString(timer-= >tickpolicy)); + return -1; + } break; } } --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1581085677396175.82917059243061; Fri, 7 Feb 2020 06:27:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-Jnc57epWOJ-D1iVdv3aS7w-1; Fri, 07 Feb 2020 09:27:38 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 640778E7F9; Fri, 7 Feb 2020 14:27:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D6BE5C541; Fri, 7 Feb 2020 14:27:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E8342866A5; Fri, 7 Feb 2020 14:27:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERKow004492 for ; Fri, 7 Feb 2020 09:27:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 36B5C5C28C; Fri, 7 Feb 2020 14:27:20 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B36435C3FD for ; Fri, 7 Feb 2020 14:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/ERAnIIfJ6cZ0SiAnU0EiTnZTqQvYdwbGoFBNzfZ45g=; b=WKJRUfGSUnVx/Ng+La5nG8Bsgao4QyvCyR5qRplGOLBGv0vaoLeg7QVj7rHl49QHki1J7D f7eScWGJhZWhBUO0NDZgIUqEJVDGrd1vvtb/XtuikT4VtMRLqqD7ssWFYN6ggZpX+26eyo lCJQpFQBDIR11CIF1kNXlKq8InN7Ln4= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 5/8] qemu: Format the armvtimer timer on the command line Date: Fri, 7 Feb 2020 15:27:05 +0100 Message-Id: <20200207142708.6315-6-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: Jnc57epWOJ-D1iVdv3aS7w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Its behavior is controlled by a KVM-specific CPU feature. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko Reviewed-by: Masayoshi Mizuma --- src/qemu/qemu_command.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 71ae1f72e5..60f8820c64 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6611,6 +6611,19 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, virBufferAsprintf(&buf, ",tsc-frequency=3D%lu", timer->fre= quency); break; case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: + switch (timer->tickpolicy) { + case VIR_DOMAIN_TIMER_TICKPOLICY_DELAY: + virBufferAddLit(&buf, ",kvm-no-adjvtime=3Doff"); + break; + case VIR_DOMAIN_TIMER_TICKPOLICY_DISCARD: + virBufferAddLit(&buf, ",kvm-no-adjvtime=3Don"); + break; + case -1: + case VIR_DOMAIN_TIMER_TICKPOLICY_CATCHUP: + case VIR_DOMAIN_TIMER_TICKPOLICY_MERGE: + break; + } + break; case VIR_DOMAIN_TIMER_NAME_PLATFORM: case VIR_DOMAIN_TIMER_NAME_PIT: case VIR_DOMAIN_TIMER_NAME_RTC: --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1581085676090191.1007255665961; Fri, 7 Feb 2020 06:27:56 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-DIKISZ4DOzCHgtkb0jYSaA-1; Fri, 07 Feb 2020 09:27:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04045107B0E1; Fri, 7 Feb 2020 14:27:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0DA91001281; Fri, 7 Feb 2020 14:27:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8A4F618089D0; Fri, 7 Feb 2020 14:27:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERL4q004500 for ; Fri, 7 Feb 2020 09:27:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0792D5C541; Fri, 7 Feb 2020 14:27:21 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84ACA5C28C for ; Fri, 7 Feb 2020 14:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KiF8NrPiU8f0DhbWDhW4JK0klghfr8X1V0EXt0RBkkg=; b=EcChqDFnxHJtq87o1FfgKCL56kbIpESKh8KI/vdIgDQ+D5LlVwKUJv7uHDIzIEAoneCPcP Mfo214gy1nEtAoxHNO4ZGw5+EHN25uVd04MemMK2tBZRYf/5YcT5Bck3QHVDhziTe2HymX tqmmyw+4NnRW6965RtbIFLX7LXUOVqo= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 6/8] tests: Add test case for the armvtimer timer Date: Fri, 7 Feb 2020 15:27:06 +0100 Message-Id: <20200207142708.6315-7-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: DIKISZ4DOzCHgtkb0jYSaA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- .../clock-timer-armvtimer.aarch64-latest.args | 32 +++++++++++++++++++ .../clock-timer-armvtimer.xml | 27 ++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ .../clock-timer-armvtimer.aarch64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + 5 files changed, 63 insertions(+) create mode 100644 tests/qemuxml2argvdata/clock-timer-armvtimer.aarch64-la= test.args create mode 100644 tests/qemuxml2argvdata/clock-timer-armvtimer.xml create mode 120000 tests/qemuxml2xmloutdata/clock-timer-armvtimer.aarch64-= latest.xml diff --git a/tests/qemuxml2argvdata/clock-timer-armvtimer.aarch64-latest.ar= gs b/tests/qemuxml2argvdata/clock-timer-armvtimer.aarch64-latest.args new file mode 100644 index 0000000000..a1faa97b9f --- /dev/null +++ b/tests/qemuxml2argvdata/clock-timer-armvtimer.aarch64-latest.args @@ -0,0 +1,32 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/tmp/lib/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/tmp/lib/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/tmp/lib/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/tmp/lib/domain--1-guest/.config \ +QEMU_AUDIO_DRV=3Dnone \ +/usr/bin/qemu-system-aarch64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object secret,id=3DmasterKey0,format=3Draw,\ +file=3D/tmp/lib/domain--1-guest/master-key.aes \ +-machine virt,accel=3Dkvm,usb=3Doff,dump-guest-core=3Doff,gic-version=3D3 \ +-cpu host,kvm-no-adjvtime=3Don \ +-m 4096 \ +-overcommit mem-lock=3Doff \ +-smp 4,sockets=3D4,cores=3D1,threads=3D1 \ +-uuid 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server,nowait \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-no-acpi \ +-boot strict=3Don \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,\ +resourcecontrol=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/clock-timer-armvtimer.xml b/tests/qemux= ml2argvdata/clock-timer-armvtimer.xml new file mode 100644 index 0000000000..295ab64d75 --- /dev/null +++ b/tests/qemuxml2argvdata/clock-timer-armvtimer.xml @@ -0,0 +1,27 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 4194304 + 4194304 + 4 + + hvm + + + + + + + + + + destroy + restart + destroy + + /usr/bin/qemu-system-aarch64 + + + + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 028364a06c..efa0ec9477 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2729,6 +2729,8 @@ mymain(void) /* SVE aarch64 CPU features work on modern QEMU */ DO_TEST_CAPS_ARCH_LATEST("aarch64-features-sve", "aarch64"); =20 + DO_TEST_CAPS_ARCH_LATEST("clock-timer-armvtimer", "aarch64"); + qemuTestSetHostArch(&driver, VIR_ARCH_NONE); =20 DO_TEST("kvm-pit-delay", QEMU_CAPS_KVM_PIT_TICK_POLICY); diff --git a/tests/qemuxml2xmloutdata/clock-timer-armvtimer.aarch64-latest.= xml b/tests/qemuxml2xmloutdata/clock-timer-armvtimer.aarch64-latest.xml new file mode 120000 index 0000000000..4bfddd6573 --- /dev/null +++ b/tests/qemuxml2xmloutdata/clock-timer-armvtimer.aarch64-latest.xml @@ -0,0 +1 @@ +../qemuxml2argvdata/clock-timer-armvtimer.xml \ No newline at end of file diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ecd12c3d30..4b1699db7e 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -269,6 +269,7 @@ mymain(void) DO_TEST("clock-catchup", QEMU_CAPS_KVM_PIT_TICK_POLICY); DO_TEST("kvmclock", NONE); DO_TEST("clock-timer-hyperv-rtc", NONE); + DO_TEST_CAPS_ARCH_LATEST("clock-timer-armvtimer", "aarch64"); =20 DO_TEST("cpu-eoi-disabled", NONE); DO_TEST("cpu-eoi-enabled", NONE); --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1581085674368268.0086264858785; Fri, 7 Feb 2020 06:27:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-4NXASKVyNQSCHd7rR69uHA-1; Fri, 07 Feb 2020 09:27:51 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1D02802C9F; Fri, 7 Feb 2020 14:27:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 705F31BC6D; Fri, 7 Feb 2020 14:27:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 21920866B7; Fri, 7 Feb 2020 14:27:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERLdB004515 for ; Fri, 7 Feb 2020 09:27:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id CDDD35C28C; Fri, 7 Feb 2020 14:27:21 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55C095C553 for ; Fri, 7 Feb 2020 14:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085673; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zoAm4fRjDfP7w+TRwSuy/+75zQcS1eEE+fNapRJeF8U=; b=UUifbNs7mJPZj/cmIpB8Kgh2jv9U1ZqvY2KuyNCUYCrWgDwupQxHBIh7IblLlhVzrquB3x OD5GBNH05KBIyRghdmLxKtql8Ig8rS2d1yb6fv7An9z/XZWdxDHPlLBwV9CyIjoLrvEvYI mNqjZlho9QvBPLOOpb+RE7lRMlDfu18= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 7/8] docs: List the armvtimer timer among all others Date: Fri, 7 Feb 2020 15:27:07 +0100 Message-Id: <20200207142708.6315-8-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 4NXASKVyNQSCHd7rR69uHA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 44e2062d01..3e899ffe4e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2466,9 +2466,9 @@ "platform" (currently unsupported), "hpet" (libxl, xen, qemu), "kvmclock" (qemu), "pit" (qemu), "rtc" (qemu), "tsc" (libxl, qemu - - since 3.2.0) - or "hypervclock" - (qemu - since 1.2.2). + since 3.2.0), "hypervclock" + (qemu - since 1.2.2) or + "armvtimer" (qemu - since 6.1.0). =20 The hypervclock timer adds support for the reference time counter and the reference page for iTSC --=20 2.24.1 From nobody Fri Apr 19 20:13:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1581085668294927.6289861817356; Fri, 7 Feb 2020 06:27:48 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-LV2ZknmiNT-oO6OZS3ufeg-1; Fri, 07 Feb 2020 09:27:44 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44FFF1081FC6; Fri, 7 Feb 2020 14:27:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E3F45C554; Fri, 7 Feb 2020 14:27:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BDA4F18089D6; Fri, 7 Feb 2020 14:27:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 017ERM9P004527 for ; Fri, 7 Feb 2020 09:27:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9DE405C299; Fri, 7 Feb 2020 14:27:22 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.43.2.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 274EA5C28C for ; Fri, 7 Feb 2020 14:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=I46n/pveaJWXbNvTQ3nLbSGDyl6WPw6k6+P532X7IU4=; b=L9UePtrMsEzRX6BqlzIX1lrvyP6xJhQQ1Id+WwwcHrXzcLnFZyL/di+0yzOo4jj1rmpHYw xyBjDFD01Kd6crfW6oX2/b0gvN+dyl16TUq2hzKauVbZC9We64Ki04SW8HC2nLwtIscFyD 0lNTwkfNb/yDbCHQLgn2mNlQ4N30NcM= From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 8/8] news: Mention the armvtimer timer Date: Fri, 7 Feb 2020 15:27:08 +0100 Message-Id: <20200207142708.6315-9-abologna@redhat.com> In-Reply-To: <20200207142708.6315-1-abologna@redhat.com> References: <20200207142708.6315-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: LV2ZknmiNT-oO6OZS3ufeg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f567a1182e..5aa9d081a7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -82,6 +82,16 @@ "type" and "persistent" attributes. + + + qemu: Introduce the 'armvtimer' timer type + + + QEMU 5.0 introduces the ability to control the behavior of the + virtual timer for KVM ARM/virt guests, and this new timer type + exposes the same capability to libvirt users. + +
--=20 2.24.1