From nobody Sun May 5 17:49:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1580481837762921.575347117567; Fri, 31 Jan 2020 06:43:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-assmRrFCOhexvFkNTcvocA-1; Fri, 31 Jan 2020 09:43:46 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FF001005512; Fri, 31 Jan 2020 14:43:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6223A5E241; Fri, 31 Jan 2020 14:43:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1883C85CD2; Fri, 31 Jan 2020 14:43:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00VEhbGH020664 for ; Fri, 31 Jan 2020 09:43:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id D3B63103F27B; Fri, 31 Jan 2020 14:43:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBE93103F27F for ; Fri, 31 Jan 2020 14:43:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBC45803B58 for ; Fri, 31 Jan 2020 14:43:35 +0000 (UTC) Received: from m4a0072g.houston.softwaregrp.com (m4a0072g.houston.softwaregrp.com [15.124.2.130]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-efr_0fylOWaB549Nv0sXJA-1; Fri, 31 Jan 2020 09:43:33 -0500 Received: FROM m4a0072g.houston.softwaregrp.com (15.120.17.146) BY m4a0072g.houston.softwaregrp.com WITH ESMTP FOR libvir-list@redhat.com; Fri, 31 Jan 2020 14:42:06 +0000 Received: from M4W0335.microfocus.com (2002:f78:1193::f78:1193) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 31 Jan 2020 14:39:05 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.124.8.14) by M4W0335.microfocus.com (15.120.17.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Fri, 31 Jan 2020 14:39:05 +0000 Received: from BY5PR18MB3315.namprd18.prod.outlook.com (10.255.139.204) by BY5PR18MB3315.namprd18.prod.outlook.com (10.255.139.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Fri, 31 Jan 2020 14:39:03 +0000 Received: from BY5PR18MB3315.namprd18.prod.outlook.com ([fe80::e837:42bb:9b5f:45c4]) by BY5PR18MB3315.namprd18.prod.outlook.com ([fe80::e837:42bb:9b5f:45c4%7]) with mapi id 15.20.2686.028; Fri, 31 Jan 2020 14:39:03 +0000 Received: from jfehlig1.provo.novell.com (137.65.135.33) by BY5PR17CA0050.namprd17.prod.outlook.com (2603:10b6:a03:167::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22 via Frontend Transport; Fri, 31 Jan 2020 14:39:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580481836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bvGwjNn6vY4CYIlNTB8D/YXEjboZ2GRo+Z6EDG1fRbY=; b=JxqhcdIz6heap3iWaDZX7W43JzaG2C3qPjNPqZ0ZlUtWYTKcPAn5BmYFUHju5FcmtEBDno 0zDHb+156WEZ6esHKqwuaWljPUjKXwGrNHZqn8At3Vu8DMLSR3Hzuw2s7sDgtXhKmnXpyv XkJe+g+4zYGyZirzYKb51p+XpEIsEvI= From: Jim Fehlig To: Subject: [PATCH] build: Drop execute permissions on virsh bash completion command Date: Fri, 31 Jan 2020 07:38:49 -0700 Message-ID: <20200131143849.13227-1-jfehlig@suse.com> X-ClientProxiedBy: BY5PR17CA0050.namprd17.prod.outlook.com (2603:10b6:a03:167::27) To BY5PR18MB3315.namprd18.prod.outlook.com (2603:10b6:a03:196::12) MIME-Version: 1.0 X-Originating-IP: [137.65.135.33] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3473066-a376-41a7-180e-08d7a65b5166 X-MS-TrafficTypeDiagnostic: BY5PR18MB3315: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 029976C540 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(199004)(189003)(66556008)(66476007)(4326008)(8676002)(6512007)(107886003)(81166006)(6486002)(81156014)(478600001)(956004)(2616005)(36756003)(86362001)(2906002)(8936002)(52116002)(6506007)(66946007)(1076003)(6666004)(5660300002)(316002)(26005)(6916009)(186003)(16526019); DIR:OUT; SFP:1102; SCL:1; SRVR:BY5PR18MB3315; H:BY5PR18MB3315.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eTdiMAEe4UtoK1f5HRXewQOkEd+EV4ZRdmKeeUW8eWs+ksdwA1sZ/yxlhZ/G/JuJ4IrVcHbNo5LmPJfGixkXZ3aRcAIAV+v30q/zxJIeOIzg3IcfgPFjXhWbKdzxs0PyBswzvk6g81YMTabvgR79P6bhtBMRop3HAWxg6AHySPhVqIK2pPF/vbUmGmG80xCELbzVKqQnIblC/5Irq2cEr8tbWTrzg3BqqkyAZgGs/5nHxG1prMGy6szDo9Ua701izFRwXyhrCaDjItJsNeELQLiRoVubZDpx9VU+YOsWts0ybD0uvGL/O6xJfgWsCh8HPNTotq2DBE0HCIiiuxIloYh4RfAlznAOoanth77sY8GSlX7nkkVhJ+fTZKnXPE3Yrk+VJCbSThJPW/gzWnHYZSqftUFYFRy8VaQ1tsKfC6t1DQuBf+vosyLYv5qn+2Bn X-MS-Exchange-AntiSpam-MessageData: phHPDxY1LathWnRH7wDRwoB+o5tKAJkC8wQZV2qdcEke9qWu398tvHu2iNraWt6QuhjyyLIsFoDD+BeYuZBxZRVs8DodfzCT3wHxwY9NND1kuCJzps/4c6UolM/Ie6syO2QLB6UVE4BQlDMS6tTzLA== X-MS-Exchange-CrossTenant-Network-Message-Id: f3473066-a376-41a7-180e-08d7a65b5166 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2020 14:39:03.6243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sq49WG7lCz3LUDPCBYkKH//XCY0Mjf56A+V8Jqo4vIe9WA0bMkoYE1eSNpHwP96psehcOROyj4uNx5O+NcReuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3315 X-OriginatorOrg: suse.com X-MC-Unique: efr_0fylOWaB549Nv0sXJA-1 X-MC-Unique: assmRrFCOhexvFkNTcvocA-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 00VEhbGH020664 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" rpmlint complains about "script-without-shebang" due to the execute permissions on /usr/share/bash-completion/completions/vsh. Use INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessary execute permissions. Signed-off-by: Jim Fehlig Reviewed-by: Michal Privoznik --- BTW, of the nearly 800 files in /usr/share/bash-completion/completions/ on my installation, only vsh has execute permissions set. tools/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 426a6ba661..d9d1a2f43f 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -357,7 +357,7 @@ libvirt-guests.service: libvirt-guests.service.in $(top= _builddir)/config.status if WITH_BASH_COMPLETION install-bash-completion: $(MKDIR_P) "$(DESTDIR)$(BASH_COMPLETIONS_DIR)" - $(INSTALL_SCRIPT) $(srcdir)/bash-completion/vsh \ + $(INSTALL_DATA) $(srcdir)/bash-completion/vsh \ "$(DESTDIR)$(BASH_COMPLETIONS_DIR)/vsh" ( cd $(DESTDIR)$(BASH_COMPLETIONS_DIR) && \ rm -f virsh virt-admin && \ --=20 2.16.4