From nobody Wed May 8 21:39:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1580132806524632.5612390766544; Mon, 27 Jan 2020 05:46:46 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-4mrfjPydOwyYM-W-MY2y-w-1; Mon, 27 Jan 2020 08:46:42 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5487800EBB; Mon, 27 Jan 2020 13:46:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A46153B7; Mon, 27 Jan 2020 13:46:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F3FB18089C8; Mon, 27 Jan 2020 13:46:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00RDkZ6t030079 for ; Mon, 27 Jan 2020 08:46:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id F42385C21A; Mon, 27 Jan 2020 13:46:35 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1AE8D5C219; Mon, 27 Jan 2020 13:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580132805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HGTkRWGmmEP2pmpZ83GFG1BAKkcKHoNft1ZTVsk2dUc=; b=ifq3FOBWpF6miioyiuwpfmiK4bVstm1R3XyAzuLARhF3sn9ypXG/DLd7b4HIxVXSoYVIUU 8LSovu/LRbMnSMQ0rTefKR+cTib+JG634Lh0nRTaQoHZWGR5Vwfn/I1K4PkmCib8CTuGJA vGyi4khmjvNfE/uj4bX7JGJBRiXzEDs= From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [PATCH] qemu: fix linking virt-qemu-run on some distros Date: Mon, 27 Jan 2020 13:46:29 +0000 Message-Id: <20200127134629.1326509-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 4mrfjPydOwyYM-W-MY2y-w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Debian/Ubuntu linkers are more strict that other distros requiring glib to be linked explicitly. macOS needs -export-dynamic instead of -Wl,--export-dynamic Signed-off-by: Daniel P. Berrang=C3=A9 --- Pushed as a CI build fix for Debian/Ubuntu/macOS src/qemu/Makefile.inc.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index c6b04c3217..d04a87e659 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -253,6 +253,9 @@ bin_PROGRAMS +=3D virt-qemu-run =20 virt_qemu_run_SOURCES =3D $(QEMU_SHIM_SOURCES) =20 -virt_qemu_run_LDADD =3D libvirt.la -virt_qemu_run_LDFLAGS =3D -Wl,--export-dynamic +virt_qemu_run_LDADD =3D \ + libvirt.la \ + $(GLIB_LIBS) \ + $(NULL) +virt_qemu_run_LDFLAGS =3D -export-dynamic endif WITH_QEMU --=20 2.24.1