From nobody Mon Apr 29 15:27:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1579545166; cv=none; d=zohomail.com; s=zohoarc; b=oF0RzHS7ras8SbJesOjgbDC/Oz9mFBN3Ii1H59NF5GGsnsqLPl6D4vNJXWciiJIlnkCfkfMoSIHVR/tZgI0njUP8exPHWqipYdlELkwFbBBiE27++taKT3XcXRFvquL18DlKUKkTDGT4xSKCR4ZBUbEfieeo2sMB+fXcYsspCZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579545166; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IoXw1nuYOX5QzLbHAQzehom7zpX83vPy7S6Rbf6eIxY=; b=LZ8n1CaVZ7lONgPStB+ZhDaw09d8DnzLNujiTanafjJZl2RskRR3FzX6mFk2Y2UmOI2MpafWY47aOPJ9AEsD+BUm21mXeZQrhJggy/ZvHzspR2BbM9T5gpAzF76Wair8q0qdeTiruSgxovlNA1fxvrsflLfiSdv8rzN56rjDNZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1579545166283647.1611584726586; Mon, 20 Jan 2020 10:32:46 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-LMsqEdMyNcKXHaI__GCT9A-1; Mon, 20 Jan 2020 13:32:43 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65886800EBF; Mon, 20 Jan 2020 18:32:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B60510027A9; Mon, 20 Jan 2020 18:32:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EDD601832D67; Mon, 20 Jan 2020 18:32:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00KIWSOm032544 for ; Mon, 20 Jan 2020 13:32:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id BDA9FC68E5; Mon, 20 Jan 2020 18:32:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9B51B351E for ; Mon, 20 Jan 2020 18:32:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DFB5800146 for ; Mon, 20 Jan 2020 18:32:26 +0000 (UTC) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-nRE_OR6qPGOLrJtWpJxoDQ-1; Mon, 20 Jan 2020 13:32:22 -0500 Received: by mail-qk1-f194.google.com with SMTP id z76so191750qka.2; Mon, 20 Jan 2020 10:32:22 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c6:380c:8032:97ce:253e:253a]) by smtp.gmail.com with ESMTPSA id s26sm17770268qtq.22.2020.01.20.10.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 10:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579545165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IoXw1nuYOX5QzLbHAQzehom7zpX83vPy7S6Rbf6eIxY=; b=AXIiZUARjrfdKL6KJPp31bCkT1HX7kKB/+gpWeAWDWDO+B5nZdtIhfdtbwcmzt2P2pvTnT nr92F/o+buFNCjw8MOiPtUyiix6xVQPalCM3uqUa1jROLSurEUW9JILChdf/tKXfDB5D+f DqGP36oFYKn7QypLC5EvEdoYgfvGrh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bRcbKBWuhjuav/MsTSq6S59hcjpPgycYvh499+zBBtc=; b=mRHA3e0RPIuBRBFyy56SaLrmdfEHkk9oF4fDaiUrhmkanXAqc+rwa24qLgusGmFhAT D1oQH9OWbCPuUmt74YTkyqgSOn0ICOA0zLVmalVwCdR9cQWAXzg4s9rNkXntSNAzMudR hUWPJWcVA8bd4YmjvamOeKkgHK4We9ppHqtvW+eu29xsk3wD5wVRRMqN1a4ZsmmQ5SFV 5B0KSFliy6RcQq6ALbotfxT1TV6+NaGNN1Pn5NuZDc4eZWKfMXjFDyMTv9Gh9FibRZzv 8wQo17604oLEWZX159vaa/FjzU4MWcueaODCMBxAcYGFcJ3KSUacvIpDZ7osQRI9VPpS 333g== X-Gm-Message-State: APjAAAXqX+EUW2LdAj73fwLmcYObRAzDHL5/ST4xuY+YKsogws7Ls5pF 6k7Y0xQnaoNGztGIcvbv4RFJkYSt X-Google-Smtp-Source: APXvYqyloPSxd75fxrtmzjNYjZHsbhIwgPhxfBqPL0ucmzbRqf71tOvziijAN9AXxUmQgp8EuOeXpA== X-Received: by 2002:a37:65c7:: with SMTP id z190mr809820qkb.261.1579545141886; Mon, 20 Jan 2020 10:32:21 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH] Fix syntax-check 'always true header test' for virvsock.c Date: Mon, 20 Jan 2020 15:32:13 -0300 Message-Id: <20200120183213.1716459-1-danielhb413@gmail.com> MIME-Version: 1.0 X-MC-Unique: nRE_OR6qPGOLrJtWpJxoDQ-1 X-MC-Unique: LMsqEdMyNcKXHaI__GCT9A-1 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 00KIWSOm032544 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit 05a38d4c4a ("src: conditionalize / remove use of sys/ioctl.h") aimed to remove imports of ioctl.h and conditionalize them for compilation on Windows. However, the change made in virvsock.c: -#include +#ifdef HAVE_SYS_IOCTL_H +# include +#endif Makes the 'sc_prohibit_always_true_header_tests' rule complain about the redundancy of this test when building it on Linux. ../src/util/virvsock.c:20:#ifdef HAVE_SYS_IOCTL_H build-aux/syntax-check.mk: do not test the above HAVE_
_H symbol(s); with the corresponding gnulib module, they are always true make: *** [../build-aux/syntax-check.mk:1679: sc_prohibit_always_true_heade= r_tests] Error 1 make: *** Waiting for unfinished jobs.... This patch fixes it by changing the conditional to #ifndef WIN32 instead, like the other changes made by that patch. CC: Daniel P. Berrang=C3=A9 Signed-off-by: Daniel Henrique Barboza --- src/util/virvsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virvsock.c b/src/util/virvsock.c index 2638c5095a..1e2eb553d2 100644 --- a/src/util/virvsock.c +++ b/src/util/virvsock.c @@ -17,7 +17,7 @@ =20 #include =20 -#ifdef HAVE_SYS_IOCTL_H +#ifndef WIN32 # include #endif =20 --=20 2.24.1