From nobody Sat Feb 7 06:35:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579076874; cv=none; d=zohomail.com; s=zohoarc; b=mYL4qfydhkBLxyJGx44WlHXdmRh5JofCMNzTFYeCyqd4dlWqBHKq924BBje2HJHfQ1Kwq2Iomt5CM0VkM5EfmFN1zb6YIBLA/F1Vz2zoKKnxaOqeHh6tNgc1jhXR2LUVdg1onWDWFoti1zqzkpK2ACZ7/Ias/7SMRlBFU7vPp98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579076874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O72duUmPPdPZx5xSjwU1SxwVxngmaZO36bWckGc/TLY=; b=QRG67NWaSq2fNqThli6SWDm/9ZjNyhYUBW3auNEgTkG1qbBhiel6xq9BnxXGXwNBOgxarsbGs+gVpPzTljQoiRvbibJU1YdlVn5KgYEa/xhlwQZZSDaKiDMknylh4UGTi3vF4R/qforipNIgGc5TLYivgyjM8AFrBua4wR+FdiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1579076874128565.497507926557; Wed, 15 Jan 2020 00:27:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-ex8CkdA1N1Ka3S6WApk46g-1; Wed, 15 Jan 2020 03:27:50 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48273185432F; Wed, 15 Jan 2020 08:27:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22CC519C70; Wed, 15 Jan 2020 08:27:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D8E648250D; Wed, 15 Jan 2020 08:27:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00F8Rb0O016826 for ; Wed, 15 Jan 2020 03:27:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 876F45C541; Wed, 15 Jan 2020 08:27:37 +0000 (UTC) Received: from hansolo.redhat.com (ovpn-12-195.pek2.redhat.com [10.72.12.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FF625C1D6; Wed, 15 Jan 2020 08:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579076873; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=O72duUmPPdPZx5xSjwU1SxwVxngmaZO36bWckGc/TLY=; b=U1YtV9c0LOH5mqd30SA30dXpT1xrEin404QaaUp5Dg6Xtgnp3QUUVUgYNgQG0ligHLzo0o uQsed+j44L5O/7X5hnc+90pgN4QIRDQEnzJaAcvODk/GodqIQjJYfZnQMmQAliogtF2MfO cMSOLd/1xsEQGuC1ZJsnuOF2Bzuaf0E= From: Han Han To: libvir-list@redhat.com Date: Wed, 15 Jan 2020 16:24:58 +0800 Message-Id: <20200115082458.4926-5-hhan@redhat.com> In-Reply-To: <20200115082458.4926-1-hhan@redhat.com> References: <20200115082458.4926-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Han Han , devel@ovirt.org Subject: [libvirt] [PATCH 4/4] libxl: Drop cdrom media update support in live disk attch APIs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: ex8CkdA1N1Ka3S6WApk46g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- src/libxl/libxl_driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f021ec9c5d..b481e950da 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3030,8 +3030,10 @@ libxlDomainAttachDeviceDiskLive(virDomainObjPtr vm, = virDomainDeviceDefPtr dev) =20 switch (l_disk->device) { case VIR_DOMAIN_DISK_DEVICE_CDROM: - ret =3D libxlDomainChangeEjectableMedia(vm, l_disk); - break; + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + "%s", _("cdrom update is not supported in this = API. " + "Use virDomainUpdateDeviceFlags instead.")); + goto cleanup; case VIR_DOMAIN_DISK_DEVICE_DISK: if (l_disk->bus =3D=3D VIR_DOMAIN_DISK_BUS_XEN) { if (virDomainDiskIndexByName(vm->def, l_disk->dst, true) >= =3D 0) { --=20 2.24.0.rc1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list