From nobody Sat Feb 7 06:35:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579076870; cv=none; d=zohomail.com; s=zohoarc; b=gcb/j7YkAue5TXDaXbDVTcpWWdK5eXFkkNGvx73UzTGcnspETkV7K0JEhLP57OMwNRLa/b+x2kN0HQwBgkYfDV4uf4FxGxmFHr2sxssLzzXqVpgoqLfn34CVayry/NWVpbxiWeThK7ohbC97AHSrCohRBnvcWNFiMN9mRaFiRhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579076870; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LUnOgZkg5GGTTYPhWMMY8OYz3u8TqOj543kYj2ucoYE=; b=C/BRU5bj2BOj6i2aNkTejOYuxlMVHNVj14MppO9iOlf5umdihhthJSWqvu9EnDWipCkMZtMSGOYwWgC4YMOkOspmTtMxdDy7jSzmNmYaZROeM+Zq3Qzbth5gGS4xIvS5qCKODAorlWuH73Mxeg1VGBtX7sisAz1q04XnxkWKLpU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1579076870292161.8328599991686; Wed, 15 Jan 2020 00:27:50 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-5GtzTCEhMEGGGzOP5R_UdA-1; Wed, 15 Jan 2020 03:27:47 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E186A107ACCA; Wed, 15 Jan 2020 08:27:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7FEE842BE; Wed, 15 Jan 2020 08:27:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7A38018089D5; Wed, 15 Jan 2020 08:27:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00F8RWCv016801 for ; Wed, 15 Jan 2020 03:27:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1D3B65C3F8; Wed, 15 Jan 2020 08:27:32 +0000 (UTC) Received: from hansolo.redhat.com (ovpn-12-195.pek2.redhat.com [10.72.12.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 275AB5C1D6; Wed, 15 Jan 2020 08:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579076869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LUnOgZkg5GGTTYPhWMMY8OYz3u8TqOj543kYj2ucoYE=; b=JekvgvH+7B44uZGSFQwe0T3su769YVHL0tFW7WCa7Jdw0ATFl1Du4JIgq8Jkeyk2ZPq6lM Ljz17Co0L4p+85RjpBAdTH0IqBCGcbXEgUtN0CUxJTaGCmUIAMkAtaYo4DBqjQCXc+zu3r pzZCMEW+0e3yeLGKPljTvlwZb2V3ufM= From: Han Han To: libvir-list@redhat.com Date: Wed, 15 Jan 2020 16:24:56 +0800 Message-Id: <20200115082458.4926-3-hhan@redhat.com> In-Reply-To: <20200115082458.4926-1-hhan@redhat.com> References: <20200115082458.4926-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Han Han , devel@ovirt.org Subject: [libvirt] [PATCH 2/4] libvirt: Remove comments of media update in virDomainAttachDeviceFlags X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 5GtzTCEhMEGGGzOP5R_UdA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- src/libvirt-domain.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index eb66999f07..a6a246c3a4 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8208,10 +8208,6 @@ virDomainAttachDevice(virDomainPtr domain, const cha= r *xml) * return failure if LIVE is specified but it only supports modifying the * persisted device allocation. * - * For compatibility, this method can also be used to change the media - * in an existing CDROM/Floppy device, however, applications are - * recommended to use the virDomainUpdateDeviceFlag method instead. - * * Be aware that hotplug changes might not persist across a domain going * into S4 state (also known as hibernation) unless you also modify the * persistent domain definition. --=20 2.24.0.rc1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list