From nobody Sat Feb 7 06:36:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579076859; cv=none; d=zohomail.com; s=zohoarc; b=Jr4TTWuWdfQ95vMrTYUHR2z/rP/ec+cEY+9M8oR5iK7TcQOuLcGIm1kn+kQOBwRGz5l5HHvFlXp62TjDdWRTYWDQaay0RnwPckxErdUL0ygHc30g6Jk/uCJLCvLX5jJrxqbSFivjRhtXjwgTswRPK5fu73g01fisyalsbKLNZ8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579076859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eYfUbQ6Llh8r6AyoC14yQZH4YbUoFqwX5Bgrx82RXi8=; b=IA/oCHYRxF9KfiyGP9mjJg5tpc5HQph6/ZOvYN01PQ4tSSSUGQTp+2CBy/6rktu7OcBjcmRzfOCa32AS1iyvTJ9qsr652qFiBMgCS1195hwilf2tUGsMvYxgmmCvAQI7XfhBoMeON3bJMMefoikvato++qpqjVJ/VOX1RWYyWx8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1579076859377273.37712601622195; Wed, 15 Jan 2020 00:27:39 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-9e_c4ZyqOJqEVxUap70YpA-1; Wed, 15 Jan 2020 03:27:37 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C35A107ACC5; Wed, 15 Jan 2020 08:27:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 261BD19C70; Wed, 15 Jan 2020 08:27:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2FAD518095FF; Wed, 15 Jan 2020 08:27:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00F8RTSW016790 for ; Wed, 15 Jan 2020 03:27:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id 754E35C219; Wed, 15 Jan 2020 08:27:29 +0000 (UTC) Received: from hansolo.redhat.com (ovpn-12-195.pek2.redhat.com [10.72.12.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2691D5C1D6; Wed, 15 Jan 2020 08:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579076858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eYfUbQ6Llh8r6AyoC14yQZH4YbUoFqwX5Bgrx82RXi8=; b=iVP6Y+qwE/Pk8PpApjWH+2oFTqPAHj/g/PS+BlZjlC501JWBdJwE8xLLyLxd9G1vUmP5yx 4h/Ak+WyNYFoaki4cRAlWT74eeQaiUiMgEf9boJzPqEEITXj4qFgNVewODjopn31SX76Oj 73FXWvdHF/jvfLWQMpG0XI79qdXBd8U= From: Han Han To: libvir-list@redhat.com Date: Wed, 15 Jan 2020 16:24:55 +0800 Message-Id: <20200115082458.4926-2-hhan@redhat.com> In-Reply-To: <20200115082458.4926-1-hhan@redhat.com> References: <20200115082458.4926-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Han Han , devel@ovirt.org Subject: [libvirt] [PATCH 1/4] virsh.rst: Mention media update is not supported in attach-{disk, device} X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 9e_c4ZyqOJqEVxUap70YpA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- docs/manpages/virsh.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index c637caa583..92f113fbde 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4391,9 +4391,7 @@ as the top-level element. See the documentation at libvirt XML format for a device. If *--config* is specified the command alters the persistent domain configuration with the device attach taking effect the next time libvirt starts the domain. -For cdrom and floppy devices, this command only replaces the media -within an existing device; consider using ``update-device`` for this -usage. For passthrough host devices, see also ``nodedev-detach``, +For passthrough host devices, see also ``nodedev-detach``, needed if the PCI device does not use managed mode. =20 If *--live* is specified, affect a running domain. @@ -4408,7 +4406,8 @@ an offline domain, and like *--live* *--config* for a= running domain. =20 ``Note``: using of partial device definition XML files may lead to unexpec= ted results as some fields may be autogenerated and thus match devices other t= han -expected. +expected. It doesn't support replace the media within the existing virtual +cdrom or floppy device. Use ``update-device`` or ``change-media`` instead. =20 =20 attach-disk @@ -4442,9 +4441,7 @@ of the disk source, such as *raw* or *qcow2*. Hyperv= isor default will be used if *subdriver* is not specified. However, the default may not be correct, esp. for QEMU as for security reasons it is configured not to det= ect disk formats. *type* can indicate *lun*, *cdrom* or *floppy* as -alternative to the disk default, although this use only replaces the media -within the existing virtual cdrom or floppy device; consider using -``update-device`` for this usage instead. +alternative to the disk default. *alias* can set user supplied alias. *mode* can specify the two specific mode *readonly* or *shareable*. *sourcetype* can indicate the type of source (block|file) @@ -4476,6 +4473,9 @@ For compatibility purposes, *--persistent* behaves li= ke *--config* for an offline domain, and like *--live* *--config* for a running domain. Likewise, *--shareable* is an alias for *--mode shareable*. =20 +``Note``: It doesn't support replace the media within the existing virtual +cdrom or floppy device. Use ``update-device`` or ``change-media`` instead. + =20 attach-interface ---------------- --=20 2.24.0.rc1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list