From nobody Tue Feb 10 05:26:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578699176; cv=none; d=zohomail.com; s=zohoarc; b=iXXKAnJ09NVPS2U/ssOFNX0d6Lfe+e2wQjVUY6vXdQwCXvQAlmonG4jbxe8sQ2GBFuUoKbYvcOp4SLNev0uFD6+24+JA6f2M0Pc2oml1L42f1ULWSMCSVZ4BCwgDqnCH6eo/tSRPcx/7gBQ1GWJf37jVK5QgEpkg+c+T/YZRjh8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578699176; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/1qQIiQJ/PNR40yaspX7GYFPnQQf0m9WIDSrPRsyB5Y=; b=GEz16nPUigflp6GJqt+Pk9uKktEQUstsc83sBidkHWaHYEFSXqqWaP7QhvWuKJwuzA4XqTzte5Y8VdmeoO1+dCGqFK5NnezRP54kRkXdj/7mKA0T2WRapnturRXSJof2FyvsxOjNsa5BO8nu+/bMA8tf9aS2KYErkga/Rna4U8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1578699176806659.7682306428308; Fri, 10 Jan 2020 15:32:56 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-10VJfMT5Oser7W-fdOqm1w-1; Fri, 10 Jan 2020 18:32:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80C75800A02; Fri, 10 Jan 2020 23:32:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39EDF5C1D4; Fri, 10 Jan 2020 23:32:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A24E7503CC; Fri, 10 Jan 2020 23:32:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00ANWMKe018722 for ; Fri, 10 Jan 2020 18:32:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id F31805D72B; Fri, 10 Jan 2020 23:32:21 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-117-214.phx2.redhat.com [10.3.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD8147C408; Fri, 10 Jan 2020 23:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578699175; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/1qQIiQJ/PNR40yaspX7GYFPnQQf0m9WIDSrPRsyB5Y=; b=XW20kK4Q9RCw602jILUaX43sWSLO2u2GPpPhLZ+Ez0kc8IRaqKs9sE6YR036lywg84Ji10 pl5YHzp4DHffP9F5/hbmTp3J0cDV66pt0MKw2Sos8KL7mf9Sq3dWv+NcTtgxU92TUqGt5l 1kE7oSMoehDQvlQOk8Entdou5++W3yo= From: Jonathon Jongsma To: libvir-list@redhat.com Date: Fri, 10 Jan 2020 17:32:10 -0600 Message-Id: <20200110233217.18770-2-jjongsma@redhat.com> In-Reply-To: <20200110233217.18770-1-jjongsma@redhat.com> References: <20200110233217.18770-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com Subject: [libvirt] [PATCH v2 1/8] qemu: rename qemuAgentGetFSInfoInternalDisk() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 10VJfMT5Oser7W-fdOqm1w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function name doesn't give a good idea of what the function does. Rename to qemuAgentGetFSInfoFillDisks() to make it more obvious than it is filling in the disk information in the fsinfo struct. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5fa8d24a91..8b54786ed8 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1929,9 +1929,9 @@ qemuAgentFSInfoToPublic(qemuAgentFSInfoPtr agent) } =20 static int -qemuAgentGetFSInfoInternalDisk(virJSONValuePtr jsondisks, - qemuAgentFSInfoPtr fsinfo, - virDomainDefPtr vmdef) +qemuAgentGetFSInfoFillDisks(virJSONValuePtr jsondisks, + qemuAgentFSInfoPtr fsinfo, + virDomainDefPtr vmdef) { size_t ndisks; size_t i; @@ -2143,7 +2143,7 @@ qemuAgentGetFSInfoInternal(qemuAgentPtr mon, goto cleanup; } =20 - if (qemuAgentGetFSInfoInternalDisk(disk, info_ret[i], vmdef) < 0) + if (qemuAgentGetFSInfoFillDisks(disk, info_ret[i], vmdef) < 0) goto cleanup; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list