From nobody Tue May 7 10:48:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578406538; cv=none; d=zohomail.com; s=zohoarc; b=Wd+IhVwhr17TsaZg+LKVH81tXXUN3QL46XrJOwmW6j2YLulDGNHXOOTfLsPKS8sMHUiexerLZQPtFkywyJ5rUunP2Im8yeALSzEtAUUppA9vlD1YxO3BXb+BExa5YRbhI+kceVXJacgD1XTIoEkcS1dIbouDEyExt05kQgQQn/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578406538; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=zde1hrhV92elMjbZ2x+Er5NRGqTLmnxZAR/G+/1a+xE=; b=Cu75AI+Iz6tx4v29vGx2j8YwmUHKN+rI3OSGbWsDjUW9lHSYUTx6nUdtHH41+ncbZjjWQB6nuhLF6jeN+1IRHuVMfzU8n9f5phEHTv9aW3H77D73Yas3HRCR0lUlZ+oU9MTugvCzMDmCRe1NCgkZYt6dMtRXi9zrzQQyrM184Fg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1578406538289262.56468417735107; Tue, 7 Jan 2020 06:15:38 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-GObReV-wNu6T5jCL4XU_PA-1; Tue, 07 Jan 2020 09:15:35 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97009107ACC9; Tue, 7 Jan 2020 14:15:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA8F85C1B0; Tue, 7 Jan 2020 14:15:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B369281C66; Tue, 7 Jan 2020 14:15:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 007EFOtH030184 for ; Tue, 7 Jan 2020 09:15:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id A5ADE271A5; Tue, 7 Jan 2020 14:15:24 +0000 (UTC) Received: from localhost.localdomain (unknown [10.36.118.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF53A272A7; Tue, 7 Jan 2020 14:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578406537; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zde1hrhV92elMjbZ2x+Er5NRGqTLmnxZAR/G+/1a+xE=; b=hneiEFhJSv18Fqk6EfKoKPKP3E9MUP9U066pvzbN04ZiZmHW7FUnlort5A4909yuBEpEun DKsS5Y/mrsTHm9c+cVwq3v8Q6/Aeg8MR0Ojq2NgcvtbvHn2k/LBLQ1a/xAzMfibeNo4hvW e2JK9+RETIRYLB74rG3emHdkdKY9F+g= From: Sebastian Mitterle To: libvir-list@redhat.com Date: Tue, 7 Jan 2020 14:15:19 +0000 Message-Id: <20200107141519.15856-1-smitterl@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Sebastian Mitterle Subject: [libvirt] [PATCH] Improve security driver error message X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: GObReV-wNu6T5jCL4XU_PA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Currently, when security driver is not available users are informed that it wasn't found which can be confusing. 1. Update error message 2. Add comment to domain doc Signed-off-by Sebastian Mitterle Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/formatdomain.html.in | 3 ++- src/security/security_manager.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index dd04a05f09..3040448df1 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -9011,7 +9011,8 @@ qemu-kvm -net nic,model=3D? /dev/null
model
A valid security model name, matching the currently - activated security model + activated security model. Model dac is not available + when guest is run by unprivileged user.
relabel
Either yes or no. This must always diff --git a/src/security/security_manager.c b/src/security/security_manage= r.c index 952675381d..f229d94570 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -769,7 +769,7 @@ static int virSecurityManagerCheckModel(virSecurityMana= gerPtr mgr, } =20 virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Unable to find security driver for model %s"), + _("Security driver model '%s' is not available"), secmodel); cleanup: VIR_FREE(sec_managers); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list