From nobody Sat Feb 7 20:44:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=ixsystems.com ARC-Seal: i=1; a=rsa-sha256; t=1578045514; cv=none; d=zohomail.com; s=zohoarc; b=YV3yaaPCrG69pxPoc5ttJD6zxfGBFJvFKdQnUG9YMp4lciD1KqJXRaTDNYdsyOqrJBuQSVhAmHTFIF8flzhggBMik+cIPr7+fs987WFeO0JVRho9glMvd0wTld+vYBfRE4CRr8U+LiuKn4E6QPzJoa+gVQyZbhC7ZgnBEaR57jo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578045514; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QzhqnFFq3DooC/VzBSUDAftdMc3uFSfbhu8H1VI9XFU=; b=M2mm/IZPZNkxNU0ReRhyRV6UxPYEqVZWaTXgQFzTGiWcePhdPQhIIidw1KKGESwmVm7t7pQTO6pv5cE8pCiYOFdFyh/Ld+FZyXtYpLEWfZoOl3R6iXmLjjDc+IW3MwoCxmdv+oDOyG3H5McpWf+J37YkjTFta3lXDFu0KMDVCYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1578045514890431.6345217863769; Fri, 3 Jan 2020 01:58:34 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-PGVSLjP4OFa07VT1TfAjaA-1; Fri, 03 Jan 2020 04:58:31 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72788DB25; Fri, 3 Jan 2020 09:58:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B86CA4B60; Fri, 3 Jan 2020 09:58:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 09AE5104907; Fri, 3 Jan 2020 09:58:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 002Hkpro017517 for ; Thu, 2 Jan 2020 12:46:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 68CE510CD679; Thu, 2 Jan 2020 17:46:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63D0310CD658 for ; Thu, 2 Jan 2020 17:46:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44B1A8012BC for ; Thu, 2 Jan 2020 17:46:51 +0000 (UTC) Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426--joMcnmiOnGpKirhByK5Dg-1; Thu, 02 Jan 2020 12:46:48 -0500 Received: by mail-yb1-f193.google.com with SMTP id k128so6606502ybc.13 for ; Thu, 02 Jan 2020 09:46:48 -0800 (PST) Received: from mp03.tn.ixsystems.com ([12.189.233.131]) by smtp.gmail.com with ESMTPSA id a202sm21904073ywe.8.2020.01.02.09.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 09:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578045513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QzhqnFFq3DooC/VzBSUDAftdMc3uFSfbhu8H1VI9XFU=; b=W4enOrxrggf61TUoEb+GVFMZbVJqLXe9YLKk/b3zbh4ShtlRkFjjqRycBZP+5zg8Hhl+r1 CWcYsDf26BBOFSJsR5Qzo2Ud2ykYQzxb+g0PAmJqusOEnNCLf05z8Rj5mnQkxqBejx4ByE T4X8OVPfuVeDyMjcEq/ormiDIdsFkcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kYw0r+7VJb+DVD7tDya1RkHqc651r9DSC/0ExTz262g=; b=JCjLzMZiQ2SPcGLN5/U23OpQSuS6n398fgh5WK2cnh6f3etV/Ws2zuGSY2DvTlAjrN vrh3GMRiVxsFMIfVXEavKQiYYlu/z+SWCmDwGlJ2aKrC6vaWw6lp5mNMl0pECcNXSjwM 654Vu3YdUNltxB3iY1fgfmuajqoObuSE5SOcBcqdiR62kirb9isS27g74fNNBxfXjC5C 6B/MpnHVmR4R6pW//sxuMoLdWRkCopnpA+Bq6Y9HF5JYMPMv+g4nJMPMFT/QXygiITvk zuBjTokmCnTUSr4lxorQ0kP1NJqwakDmzDWuqeBZlX8PeJk7CWMN1uEYUdU1YDH7w/y/ Ja0Q== X-Gm-Message-State: APjAAAWXhmc7VM5GOjn3dcbaPFuFm/elERFyD8Fyaqs9HH9uKdGriEGg mWRJVCKvzc8SB5wZd7r4hJOsroJPakl21/JKHOnQb0ueUn5qVnLxt4MD4XVxrYuQSQz/CFIAJ4N KQl4bFTyIU8fGiNfhBpzJHph/ZLy4Crb6GpmCIjb/y3tiIKyOlXMYLkQ2MtlD690DGN0= X-Google-Smtp-Source: APXvYqzXP0T01AXWa7ZRQDuoLo5nWFO997rB/4kPA/tkdC0YQo4RI+igyrJl/4oBg1gRbfWv3j4emw== X-Received: by 2002:a25:9381:: with SMTP id a1mr32070690ybm.88.1577987207471; Thu, 02 Jan 2020 09:46:47 -0800 (PST) From: Ryan Moeller X-Google-Original-From: Ryan Moeller To: libvir-list@redhat.com Date: Thu, 2 Jan 2020 17:46:28 +0000 Message-Id: <20200102174635.7231-6-ryan@iXsystems.com> In-Reply-To: <20200102174635.7231-1-ryan@iXsystems.com> References: <20200102174635.7231-1-ryan@iXsystems.com> MIME-Version: 1.0 X-MC-Unique: -joMcnmiOnGpKirhByK5Dg-1 X-MC-Unique: PGVSLjP4OFa07VT1TfAjaA-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 002Hkpro017517 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Fri, 03 Jan 2020 04:57:56 -0500 Cc: Ryan Moeller Subject: [libvirt] [PATCH v2 05/12] Factor out conn X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Ryan Moeller Reviewed-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_driver.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index d591ff63e3..a862921c87 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -947,7 +947,8 @@ bhyveDomainCreateXML(virConnectPtr conn, static int bhyveDomainDestroyFlags(virDomainPtr dom, unsigned int flags) { - bhyveConnPtr privconn =3D dom->conn->privateData; + virConnectPtr conn =3D dom->conn; + bhyveConnPtr privconn =3D conn->privateData; virDomainObjPtr vm; virObjectEventPtr event =3D NULL; int ret =3D -1; @@ -957,7 +958,7 @@ bhyveDomainDestroyFlags(virDomainPtr dom, unsigned int = flags) if (!(vm =3D bhyveDomObjFromDomain(dom))) goto cleanup; =20 - if (virDomainDestroyFlagsEnsureACL(dom->conn, vm->def) < 0) + if (virDomainDestroyFlagsEnsureACL(conn, vm->def) < 0) goto cleanup; =20 if (virDomainObjCheckActive(vm) < 0) @@ -1061,7 +1062,8 @@ bhyveDomainSetMetadata(virDomainPtr dom, const char *uri, unsigned int flags) { - bhyveConnPtr privconn =3D dom->conn->privateData; + virConnectPtr conn =3D dom->conn; + bhyveConnPtr privconn =3D conn->privateData; virDomainObjPtr vm; int ret =3D -1; =20 @@ -1071,7 +1073,7 @@ bhyveDomainSetMetadata(virDomainPtr dom, if (!(vm =3D bhyveDomObjFromDomain(dom))) return -1; =20 - if (virDomainSetMetadataEnsureACL(dom->conn, vm->def, flags) < 0) + if (virDomainSetMetadataEnsureACL(conn, vm->def, flags) < 0) goto cleanup; =20 ret =3D virDomainObjSetMetadata(vm, type, metadata, key, uri, --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list