From nobody Sat Feb 7 21:08:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=ixsystems.com ARC-Seal: i=1; a=rsa-sha256; t=1578045521; cv=none; d=zohomail.com; s=zohoarc; b=auYTotn4LtipCD5dr71msRfsSRylPnc9CKjg58Y7iPl3BoaEkyVNNRtVHDyUCxIHN8cwMaxHIW5MNcq+yox3kJVfBUgtwe/8vTPQyx7oXyrRfzFJqjRw/4IcticMUjOA+bHM2lxOV2i7oqYPCSDkGSF2Dh63/REiU6iqB45g0cE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578045521; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m2YzPKaQEoOrk0G13hLlsWWnL8s/o3Zuujne3nCeGjY=; b=ZxfuiiKOhXN7W//cYfcq+u7AUPISlZkvI5IaSKkvPQtKxUANo7dcguIOHtej+4jDbHRapK7Te6Okkg4Hbv5Lu35lu1XjF0DzLOkKUlCVXKgGHPkDjdtu9MxYMiNxewGUOF+s/T+hRS7K1DATlsyi7+YA9m+yelLmDDGgr9k01O4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 157804552113560.61751843017612; Fri, 3 Jan 2020 01:58:41 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-ZLQw_LfJMcqJnxrQ2QGSRA-1; Fri, 03 Jan 2020 04:58:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27E4DDB24; Fri, 3 Jan 2020 09:58:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFD005C545; Fri, 3 Jan 2020 09:58:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AEACF1808855; Fri, 3 Jan 2020 09:58:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 002Hks04017575 for ; Thu, 2 Jan 2020 12:46:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id C1F062022AC6; Thu, 2 Jan 2020 17:46:54 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCF032026D69 for ; Thu, 2 Jan 2020 17:46:54 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DBC285A301 for ; Thu, 2 Jan 2020 17:46:54 +0000 (UTC) Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-HQVWnUrhPRG9GUVTB495Vg-1; Thu, 02 Jan 2020 12:46:52 -0500 Received: by mail-yb1-f195.google.com with SMTP id a124so17605737ybg.2 for ; Thu, 02 Jan 2020 09:46:52 -0800 (PST) Received: from mp03.tn.ixsystems.com ([12.189.233.131]) by smtp.gmail.com with ESMTPSA id a202sm21904073ywe.8.2020.01.02.09.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 09:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578045519; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=m2YzPKaQEoOrk0G13hLlsWWnL8s/o3Zuujne3nCeGjY=; b=V7ScMII4stNKb1EpqToqIpMT9DlOhrhZ6y2cvb5B7BuwUT54a71OXjLuRO40O7wd0Ad3yH r5OHk5V7oEUE8kTjgh7a/W16uJzjleoDVmlTRbL8D6JE2AQuYoKb+kwYVOQKZ+Hvw5fUm5 DPj2MDGpiWmCv84cvU29TI6duYCrMkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hMWpl1gvyJO1+eTbhmJf2MLnljgTyifDqQOFQ/uDbTo=; b=mVrQOOl6z2tvqr+dszcUmqqztuds9Z9VH9rAlRaO4Pz5lrkE/CzW2ynvrucOaRNUbv 93mq8t3/KJTyRE43dDrIBZH6QHPCWd7I30Xp0zMk3SC8wi6GNDjwFDPz0yGWRd61HorW o00pLRPT6Djg/6T9aTW1RtbIZ271PvyFanH7p0/TXzjj5gHECBJvFqBCyezwOJXLfWLw TqVpNHH2id+E7ZeRhA39C7o0HCCXwC2NeZHX81whjT7Hz6Au+SnMLAfRTvNlV0PJlloD HjNWY6/UWRlcAELJQDShZt6IsWimdtBZoLPv9L2Ps6mXS9Whg8EkbvPq3WMdLSYVqEoE 69Pg== X-Gm-Message-State: APjAAAWJYgD21H1aTy1xudtdByIhjdYn3WHKAOc18Wei+R7dyGbDnfHm vrt0S1YhHkHm2Es9WPadVax59gWvAfrJAPuLF0usQxVRjRxnP2xtaqsnq1az2+UgT0AQDauw9/n igo3hEdwiSvSwAFfYWhTyLsr/3zRX1f9E4OgvotK/gaJPqnRD+bK2cqup1T5IqGSi18A= X-Google-Smtp-Source: APXvYqwMfwgO8gLIeOF4JlrfWNZclHLZkp6nkqU3ynSvHOxPqylRBW9rUeIUVGS34arUK5Dpeuhcmg== X-Received: by 2002:a25:6887:: with SMTP id d129mr60011601ybc.345.1577987209667; Thu, 02 Jan 2020 09:46:49 -0800 (PST) From: Ryan Moeller X-Google-Original-From: Ryan Moeller To: libvir-list@redhat.com Date: Thu, 2 Jan 2020 17:46:32 +0000 Message-Id: <20200102174635.7231-10-ryan@iXsystems.com> In-Reply-To: <20200102174635.7231-1-ryan@iXsystems.com> References: <20200102174635.7231-1-ryan@iXsystems.com> MIME-Version: 1.0 X-MC-Unique: HQVWnUrhPRG9GUVTB495Vg-1 X-MC-Unique: ZLQw_LfJMcqJnxrQ2QGSRA-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 002Hks04017575 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Fri, 03 Jan 2020 04:57:56 -0500 Cc: Ryan Moeller Subject: [libvirt] [PATCH v2 09/12] Don't bother seeking to the end of a file opened O_APPEND X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Ryan Moeller Reviewed-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_process.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 4da2a702e6..75e12c8a8f 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -121,8 +121,6 @@ virBhyveProcessStart(virConnectPtr conn, char *devicemap =3D NULL; char *logfile =3D NULL; int logfd =3D -1; - off_t pos =3D -1; - char ebuf[1024]; virCommandPtr cmd =3D NULL; virCommandPtr load_cmd =3D NULL; bhyveConnPtr driver =3D conn->privateData; @@ -196,9 +194,6 @@ virBhyveProcessStart(virConnectPtr conn, =20 /* Log generated command line */ virCommandWriteArgLog(load_cmd, logfd); - if ((pos =3D lseek(logfd, 0, SEEK_END)) < 0) - VIR_WARN("Unable to seek to end of logfile: %s", - virStrerror(errno, ebuf, sizeof(ebuf))); =20 VIR_DEBUG("Loading domain '%s'", vm->def->name); if (virCommandRun(load_cmd, NULL) < 0) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list