From nobody Mon May 6 13:00:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1577980873; cv=none; d=zohomail.com; s=zohoarc; b=Gd9kzpWLn8qgGKoD9JJ6vAEAcba7fmdhnT74tKraosJfkNQldGF1ak23i7mSSnTN3MMKO1xDszzDx2+LiNBt0LkJZRCo+KArR2TtWKjLsCvZSe9LQwkYKnOrHJrhObjURdRpuWpVy6IIC9rgzidhYkOAMJz+4D5W/5R5nypmaO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577980873; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JTn0w+Xt/dhRyXHq30VVFSv11NAtyoRpGQa/yzKUu6w=; b=f3rEQHM9quJT1k5MqM6DPxC8b6eyyXIjyXQ0xd/HMzjmYuvwCztIK31ZVEANa3/PpUwIPWEfMhqNAIIUAKOhvtGvzxmE3EZWce/Wv0L+KIa2TVCzfsV8eMQnZxxP+3zV+mh0wT97l5bj4Kbk+R/teXhkZbH80stvIYOKozTh4Hw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1577980873200262.97086663566165; Thu, 2 Jan 2020 08:01:13 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-y03fLKFhPPubXToZyn6EYA-1; Thu, 02 Jan 2020 11:01:10 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B24E0107ACC7; Thu, 2 Jan 2020 16:00:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 770BA6FF0F; Thu, 2 Jan 2020 16:00:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 267A418089D0; Thu, 2 Jan 2020 16:00:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 002G0pKH014393 for ; Thu, 2 Jan 2020 11:00:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 889BD2022EA7; Thu, 2 Jan 2020 16:00:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83F2A2026D69 for ; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6042B800158 for ; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from heinz.dinsnail.net (heinz.dinsnail.net [81.169.187.250]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-OhLi8O1yOdmkhph2HVt4RA-3; Thu, 02 Jan 2020 11:00:46 -0500 Received: from heinz.dinsnail.net ([IPv6:0:0:0:0:0:0:0:1]) by heinz.dinsnail.net (8.15.2/8.15.2) with ESMTP id 002G0Y63004167; Thu, 2 Jan 2020 17:00:34 +0100 Received: (from michael@localhost) by heinz.dinsnail.net (8.15.2/8.15.2/Submit) id 002G0Yxr004166; Thu, 2 Jan 2020 17:00:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577980872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JTn0w+Xt/dhRyXHq30VVFSv11NAtyoRpGQa/yzKUu6w=; b=gYPmu94jOGgGKnA17nmsRZ/m6iPgn7aAkuUdciYQk2FE34Yo8LA/840JTRkGFx/i7vO8vY fZSb+3ATaK5vYz7vJaHqXnmUaviL80Y/wjTaOFcF/F38or+RPnbAt2mh0FJX6Zm6Zx7kEq XvKTbtV7IrKAVKtYmIJDwYseAXEaq8A= From: Michael Weiser To: libvir-list@redhat.com Date: Thu, 2 Jan 2020 17:00:24 +0100 Message-Id: <20200102160026.2997988-2-michael.weiser@gmx.de> In-Reply-To: <20200102160026.2997988-1-michael.weiser@gmx.de> References: <20200102160026.2997988-1-michael.weiser@gmx.de> MIME-Version: 1.0 X-dinsnail-net-MailScanner-Information: Please contact the ISP for more information X-dinsnail-net-MailScanner-ID: 002G0Y63004167 X-dinsnail-net-MailScanner: Found to be clean X-dinsnail-net-MailScanner-From: michael@heinz.dinsnail.net X-Spam-Status: No X-MC-Unique: OhLi8O1yOdmkhph2HVt4RA-3 X-MC-Unique: y03fLKFhPPubXToZyn6EYA-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 002G0pKH014393 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , Michael Weiser , Cole Robinson Subject: [libvirt] [PATCH v2 1/3] qemu: Warn of restore with managed save being risky X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Internal snapshots of a non-running domain do not carry any memory state and restoring such a snapshot will not replace existing saved memory state. This allows a scenario, where a user first suspends a domain into managedsave, restores a non-running snapshot and then resumes the domain from managedsave. After that, the guest system will run with its previous memory state atop a different disk state. The most obvious possible fallout from this is extensive file system corruption. Swap content and RAID bitmaps might also be off. This has been discussed[1] and fixed[2] from the end-user perspective for virt-manager. This patch marks the restore operation as risky at the libvirt level, requiring the user to remove the saved memory state first or force the operation. [1] https://www.redhat.com/archives/virt-tools-list/2019-November/msg00011.= html [2] https://www.redhat.com/archives/virt-tools-list/2019-December/msg00049.= html Signed-off-by: Michael Weiser Reviewed-by: Daniel Henrique Barboza Cc: Cole Robinson --- src/qemu/qemu_driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ec8faf384c..691a9b45c7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16652,6 +16652,15 @@ qemuDomainRevertToSnapshot(virDomainSnapshotPtr sn= apshot, _("must respawn qemu to start inactive snapshot= ")); goto endjob; } + if (vm->hasManagedSave && + !(snapdef->state =3D=3D VIR_DOMAIN_SNAPSHOT_RUNNING || + snapdef->state =3D=3D VIR_DOMAIN_SNAPSHOT_PAUSED)) { + virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, "%s", + _("snapshot without memory state, removal of " + "existing managed saved state strongly " + "recommended to avoid corruption")); + goto endjob; + } } =20 if (snap->def->dom) { --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 13:00:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1577980863; cv=none; d=zohomail.com; s=zohoarc; b=L1Re/LkXV5gVPxYRTCzBWFavS3ykcAfmxsmbsB0Rxm05XKiLUKo5eI2FWu6SmJlZwnOjLpqMuF0EHD7Zp9cJlpacyZPfZJyM7/lYAwQhC7m+DZD/Ge362O+wHu1le6emjYlIiQTV6BUh8ZTXBOcMG4nqHr9uz1AEIXAkqsz9q+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577980863; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7aDbWBbEfPjM45Ud8yjDvZvT4+mjlQy3eR3uDMmn1mQ=; b=GmHsYfisR9RS74oSakycfVHeWh6GMeOf4bi/TxYNTuzQjNlbfzV6sG5wnnVGmm5A5LQGfyZxCl/SOjUxAWPI0MUlPrIy7DIZO0bwODco2mLCrkxn1MuLK9WxbsoSi9SZur5RD91OXTubBJ1dihaCFM1XVqIaZ5lN0YkCAjcR8gE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1577980863033345.9661878655005; Thu, 2 Jan 2020 08:01:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-EKgJ_74ZPlKrGeTXk8Mrxg-1; Thu, 02 Jan 2020 11:00:59 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 195FE800D41; Thu, 2 Jan 2020 16:00:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D23747A04F; Thu, 2 Jan 2020 16:00:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2DA1C81E1F; Thu, 2 Jan 2020 16:00:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 002G0nq6014373 for ; Thu, 2 Jan 2020 11:00:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 09838A4854; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 030BFA4852 for ; Thu, 2 Jan 2020 16:00:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82D9B185AB72 for ; Thu, 2 Jan 2020 16:00:46 +0000 (UTC) Received: from heinz.dinsnail.net (heinz.dinsnail.net [81.169.187.250]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-HxPEuO8VNK-zwrrajnxvXw-1; Thu, 02 Jan 2020 11:00:43 -0500 Received: from heinz.dinsnail.net ([IPv6:0:0:0:0:0:0:0:1]) by heinz.dinsnail.net (8.15.2/8.15.2) with ESMTP id 002G0Ztg004172; Thu, 2 Jan 2020 17:00:35 +0100 Received: (from michael@localhost) by heinz.dinsnail.net (8.15.2/8.15.2/Submit) id 002G0ZV8004171; Thu, 2 Jan 2020 17:00:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577980861; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7aDbWBbEfPjM45Ud8yjDvZvT4+mjlQy3eR3uDMmn1mQ=; b=OXihG9aJd6/VcM90xjQT0fAMdGqMXYVra7EbZTENUZWnC5QZst5W6xYBP+bI5RggVeWokM 7ilTnSh+hBArXJH73TovjoErpeOKvIdKiE4gwS+D5Fw9QVgkwuVeN5EAXqo67yAmCRJ5zr m8JrMdt4fvBjH8XBa92JkSprmd8NlWQ= From: Michael Weiser To: libvir-list@redhat.com Date: Thu, 2 Jan 2020 17:00:25 +0100 Message-Id: <20200102160026.2997988-3-michael.weiser@gmx.de> In-Reply-To: <20200102160026.2997988-1-michael.weiser@gmx.de> References: <20200102160026.2997988-1-michael.weiser@gmx.de> MIME-Version: 1.0 X-dinsnail-net-MailScanner-Information: Please contact the ISP for more information X-dinsnail-net-MailScanner-ID: 002G0Ztg004172 X-dinsnail-net-MailScanner: Found to be clean X-dinsnail-net-MailScanner-From: michael@heinz.dinsnail.net X-Spam-Status: No X-MC-Unique: HxPEuO8VNK-zwrrajnxvXw-1 X-MC-Unique: EKgJ_74ZPlKrGeTXk8Mrxg-1 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 002G0nq6014373 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , Michael Weiser , Cole Robinson Subject: [libvirt] [PATCH v2 2/3] docs: Reformat snapshot-revert force reasons X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Reformat explanations of the snapshot-revert force reasons in preparation for more to be added. This is a simple reformat without any wording changes. Signed-off-by: Michael Weiser Cc: Cole Robinson Reviewed-by: Daniel Henrique Barboza --- docs/manpages/virsh.rst | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index fea0527caf..f5f962cba1 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -6952,20 +6952,22 @@ transient domains cannot be inactive, it is require= d to use one of these flags when reverting to a disk snapshot of a transient domain. =20 There are two cases where a snapshot revert involves extra risk, which -requires the use of *--force* to proceed. One is the case of a -snapshot that lacks full domain information for reverting -configuration (such as snapshots created prior to libvirt 0.9.5); -since libvirt cannot prove that the current configuration matches what -was in use at the time of the snapshot, supplying *--force* assures -libvirt that the snapshot is compatible with the current configuration -(and if it is not, the domain will likely fail to run). The other is -the case of reverting from a running domain to an active state where a -new hypervisor has to be created rather than reusing the existing -hypervisor, because it implies drawbacks such as breaking any existing -VNC or Spice connections; this condition happens with an active -snapshot that uses a provably incompatible configuration, as well as -with an inactive snapshot that is combined with the *--start* or -*--pause* flag. +requires the use of *--force* to proceed: + + * One is the case of a snapshot that lacks full domain information for + reverting configuration (such as snapshots created prior to libvirt + 0.9.5); since libvirt cannot prove that the current configuration matc= hes + what was in use at the time of the snapshot, supplying *--force* assur= es + libvirt that the snapshot is compatible with the current configuration + (and if it is not, the domain will likely fail to run). + + * The other is the case of reverting from a running domain to an active + state where a new hypervisor has to be created rather than reusing the + existing hypervisor, because it implies drawbacks such as breaking any + existing VNC or Spice connections; this condition happens with an acti= ve + snapshot that uses a provably incompatible configuration, as well as w= ith + an inactive snapshot that is combined with the *--start* or *--pause* + flag. =20 =20 snapshot-delete --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 13:00:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1577980863; cv=none; d=zohomail.com; s=zohoarc; b=A+UYqqMsESd9iNcSvTzTSJhIqLfsoXzTm603SzZ4H/1MNPuwSDyFmheaKnXpfj6S6jTJCtEoOxGQ5iPHDrtrLCf7zvdh8dOS4r+fvs807mHPJM5bbMK/An7sixGXtzsJ2F7lJ6gCWGg+oqVw2kuHjyi3M/z5jzcUboIEHhZAHbE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577980863; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nT7R1gVHN/Nb1m2ybLnaSZU1ytlby4z0e28NWWZkgpE=; b=HSUBlpHJEc1rc4O4cEzVu8i1wIxbbu4j5BfJzu6O9B92I2xRdgBQagrL2fHplBCaflfkmoI97kf5T2sU78s3GF71gr6+1QhxIfwOni+dzavp/zac5q9pSrrIgGpAvs9vTdumbBPMwiyk62WZtZ4/CTabpD6TjH05JpWc/Za2Dog= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1577980863204513.823983081691; Thu, 2 Jan 2020 08:01:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-DscGApeHOauNzJ8cFS0YIQ-1; Thu, 02 Jan 2020 11:00:59 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EC75DBE6; Thu, 2 Jan 2020 16:00:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 246527A04F; Thu, 2 Jan 2020 16:00:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CD13C18089C8; Thu, 2 Jan 2020 16:00:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 002G0n1Z014378 for ; Thu, 2 Jan 2020 11:00:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 910B0A4851; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C6E8A4850 for ; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F6C28023BD for ; Thu, 2 Jan 2020 16:00:49 +0000 (UTC) Received: from heinz.dinsnail.net (heinz.dinsnail.net [81.169.187.250]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-w7sAfhZgMWCL2BegLZHqiw-1; Thu, 02 Jan 2020 11:00:43 -0500 Received: from heinz.dinsnail.net ([IPv6:0:0:0:0:0:0:0:1]) by heinz.dinsnail.net (8.15.2/8.15.2) with ESMTP id 002G0a2J004177; Thu, 2 Jan 2020 17:00:36 +0100 Received: (from michael@localhost) by heinz.dinsnail.net (8.15.2/8.15.2/Submit) id 002G0anu004176; Thu, 2 Jan 2020 17:00:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577980862; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nT7R1gVHN/Nb1m2ybLnaSZU1ytlby4z0e28NWWZkgpE=; b=AXY84vuz8+YJevZV2WghYn6GE+ev93JP/EfbqRwjz4J+i93c+Hif9DlthQm5Wr6DPhtDrs os5Kvx5/N5u9PKeT/nvS7tpUvNoSLaIIuQSqp8w0CrSM2mfVqVrqPCIECKm+im+5xlvN3l wT8Kf0PALEHZCPkMgmmRpYy3oz3T9cY= From: Michael Weiser To: libvir-list@redhat.com Date: Thu, 2 Jan 2020 17:00:26 +0100 Message-Id: <20200102160026.2997988-4-michael.weiser@gmx.de> In-Reply-To: <20200102160026.2997988-1-michael.weiser@gmx.de> References: <20200102160026.2997988-1-michael.weiser@gmx.de> MIME-Version: 1.0 X-dinsnail-net-MailScanner-Information: Please contact the ISP for more information X-dinsnail-net-MailScanner-ID: 002G0a2J004177 X-dinsnail-net-MailScanner: Found to be clean X-dinsnail-net-MailScanner-From: michael@heinz.dinsnail.net X-Spam-Status: No X-MC-Unique: w7sAfhZgMWCL2BegLZHqiw-1 X-MC-Unique: DscGApeHOauNzJ8cFS0YIQ-1 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 002G0n1Z014378 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , Michael Weiser , Cole Robinson Subject: [libvirt] [PATCH v2 3/3] docs: Add snapshot-revert qemu managedsave force X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Add documentation for additional reason why snapshot-revert might need to be forced. This explains why restoring an inactive snapshot while there is managed saved state is refused by default. Signed-off-by: Michael Weiser Cc: Cole Robinson Reviewed-by: Daniel Henrique Barboza --- docs/manpages/virsh.rst | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index f5f962cba1..09be872fdf 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -6951,7 +6951,7 @@ no vm state leaves the domain in an inactive state. = Passing either the transient domains cannot be inactive, it is required to use one of these flags when reverting to a disk snapshot of a transient domain. =20 -There are two cases where a snapshot revert involves extra risk, which +There are a number of cases where a snapshot revert involves extra risk, w= hich requires the use of *--force* to proceed: =20 * One is the case of a snapshot that lacks full domain information for @@ -6961,7 +6961,7 @@ requires the use of *--force* to proceed: libvirt that the snapshot is compatible with the current configuration (and if it is not, the domain will likely fail to run). =20 - * The other is the case of reverting from a running domain to an active + * Another is the case of reverting from a running domain to an active state where a new hypervisor has to be created rather than reusing the existing hypervisor, because it implies drawbacks such as breaking any existing VNC or Spice connections; this condition happens with an acti= ve @@ -6969,6 +6969,13 @@ requires the use of *--force* to proceed: an inactive snapshot that is combined with the *--start* or *--pause* flag. =20 + * Also, libvirt will refuse to restore snapshots of inactive qemu domains + while there is managed saved state. This is because those snapshots do= not + contain memory state and will therefore not replace the exising memory + state. This ends up switching a disk underneath a running system and w= ill + likely cause extensive filesystem corruption or crashes due to swap co= ntent + mismatches when run. + =20 snapshot-delete --------------- --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list