From nobody Sat May 4 23:22:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576837543; cv=none; d=zohomail.com; s=zohoarc; b=R3hiJblxPkDxS7D+8Q3xkUGAafgdBZc9hsuJ6l8Aahjj/L0vW6gx13N3r59DhyqOgLzPrmXXjyg1LBrwilIHd9cI2NZRpWrjyGcfqjOUhyzJ+fN/mnWRhbRi8YsqCzIF/oOAlqxTwCVbChRj//mQOb8VfoKhUm79qhhlLJaopN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576837543; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GM+mN76+aexE2Kg0805VNx1OWd+KuxqunGfVStLk8TE=; b=Gg70Nq4fMCJuzlLng3tjsQ7YIrXC9RwpUVfbWhpdBhEez+L4AgkdN3zqoBkelBCwngkw8Yn2mgwsytqz8BYEMZY2y8VXuftye2LC5UJd6omUaHYt7bNDRn1fJuOf+KR52ywUYhvLRAM1I7x8Y+IvWSGNiSJV3dt/eqGUj0R3TJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576837543863142.341989539957; Fri, 20 Dec 2019 02:25:43 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-9Bwyqo-_Nk2ubMg4OTtBxA-1; Fri, 20 Dec 2019 05:25:40 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34187911EA; Fri, 20 Dec 2019 10:25:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AEF01001B00; Fri, 20 Dec 2019 10:25:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 43CE4252C1; Fri, 20 Dec 2019 10:25:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBKAPVCW023574 for ; Fri, 20 Dec 2019 05:25:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id F2CC17D9D9; Fri, 20 Dec 2019 10:25:30 +0000 (UTC) Received: from localhost (unknown [10.36.118.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id E998F7E473; Fri, 20 Dec 2019 10:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576837542; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GM+mN76+aexE2Kg0805VNx1OWd+KuxqunGfVStLk8TE=; b=L9YEQCHzYQhVX2ZkjanqQJTt1hIJ4gtjCNDLKNtj3KNGohRMMr5MK/zgh+W6mHBDJy53Xn pn6sYK45PO6noIrpZmdh04dMkE49hSgWdzkkztFvr70B8uEZ8U5cEuLz0LxeDGpB+nVoHr sU4zxErAPPClVNWZdTSVQPTD4Tlm5OI= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Fri, 20 Dec 2019 10:25:18 +0000 Message-Id: <20191220102520.1637190-2-stefanha@redhat.com> In-Reply-To: <20191220102520.1637190-1-stefanha@redhat.com> References: <20191220102520.1637190-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Peter Maydell , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, libvir-list@redhat.com, Jason Wang , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , Christoph Hellwig Subject: [libvirt] [PULL 1/3] virtio-blk: deprecate SCSI passthrough X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 9Bwyqo-_Nk2ubMg4OTtBxA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough support. Deprecate this feature in QEMU too. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Reviewed-by: Christoph Hellwig Reviewed-by: Thomas Huth Message-id: 20191213144626.1208237-1-stefanha@redhat.com Message-Id: <20191213144626.1208237-1-stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi --- qemu-deprecated.texi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 62680f7bd5..259cb9ce9e 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -278,6 +278,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=3Dv1.9.= 1`` command line argument. =20 @section Device options =20 +@subsection Emulated device options + +@subsubsection -device virtio-blk,scsi=3Don|off (since 5.0.0) + +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTI= O 1.0 +and later do not support it because the virtio-scsi device was introduced = for +full SCSI support. Use virtio-scsi instead when SCSI passthrough is requi= red. + +Note this also applies to ``-device virtio-blk-pci,scsi=3Don|off'', which = is an +alias. + @subsection Block device options =20 @subsubsection "backing": "" (since 2.12.0) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 23:22:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576837548; cv=none; d=zohomail.com; s=zohoarc; b=JHQcstEXNvK0yMYWXs0Xab6XxoS5n3GSD1J20381yJ5Xwg4ESrs+U9Ei846Pk2/qMc+Hl6LCRjUV8Wz7bGW2kZ0AJ75WMSR4pailhL7YFgX/PpV5N4I+B0R3auo9XcXBWIDPJNGXYUEK0AHwrVKkGIJwhaD1z0tR0kUQYMFvhkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576837548; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iZpuQ8Ha8Cd55m+fZ+OxKVlY8Du27ho37rcp4lpT2MY=; b=RXonTrVY/IFTtbnxFwTXi7ODQKjK7WeSAq7iX0qGWKytX/qJsxG4rsPUm5JzAT10GR4O/gijcXG4L2v8XFjNy0BNj7Phr50moBZgJ5hdyXG76Tn23FxzzNT5dnGe7GeT9UU9vzAN3D/dKo3wEVC3uhk0XhzTUzl6PS+Br/4Ai90= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1576837548380617.7080946346579; Fri, 20 Dec 2019 02:25:48 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-zMmxMVbeOGea_b3lxS50pA-1; Fri, 20 Dec 2019 05:25:45 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38E63800D41; Fri, 20 Dec 2019 10:25:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F6BE383; Fri, 20 Dec 2019 10:25:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BC0A318089CF; Fri, 20 Dec 2019 10:25:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBKAPcbH023587 for ; Fri, 20 Dec 2019 05:25:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id 038D860E1C; Fri, 20 Dec 2019 10:25:38 +0000 (UTC) Received: from localhost (unknown [10.36.118.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id D56B660BF3; Fri, 20 Dec 2019 10:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576837546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iZpuQ8Ha8Cd55m+fZ+OxKVlY8Du27ho37rcp4lpT2MY=; b=MmELbYQnhl+5ETZVeHyt+wlEBVSttnMeUyZyJiRWrfYX/0AcWmcq4xcGOJv8iqdPO43RVY ZYAq2laNfjDgSlKGTgZIjwuqsahj/T0aPtNXSW+gFtS5Wz6+B9j+N1pzUUDBW1Nbz0aT5J ksUb4x/0grQwDcPIzcehZGqCr+BCxZk= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Fri, 20 Dec 2019 10:25:19 +0000 Message-Id: <20191220102520.1637190-3-stefanha@redhat.com> In-Reply-To: <20191220102520.1637190-1-stefanha@redhat.com> References: <20191220102520.1637190-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Peter Maydell , Eduardo Habkost , qemu-block@nongnu.org, libvir-list@redhat.com, Jason Wang , Max Reitz , Stefan Hajnoczi Subject: [libvirt] [PULL 2/3] docs: fix rst syntax errors in unbuilt docs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: zMmxMVbeOGea_b3lxS50pA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The .rst files outside docs/{devel,interop,specs} aren't built yet and therefore a few syntax errors have slipped through. Fix them. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20191111094411.427174-1-stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi --- docs/arm-cpu-features.rst | 6 +++--- docs/virtio-net-failover.rst | 4 ++-- docs/virtio-pmem.rst | 19 ++++++++++--------- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst index 1b367e22e1..9b537a75e6 100644 --- a/docs/arm-cpu-features.rst +++ b/docs/arm-cpu-features.rst @@ -41,9 +41,9 @@ CPU type is possible with the `query-cpu-model-expansion`= QMP command. Below are some examples where `scripts/qmp/qmp-shell` (see the top comment block in the script for usage) is used to issue the QMP commands. =20 -(1) Determine which CPU features are available for the `max` CPU type - (Note, we started QEMU with qemu-system-aarch64, so `max` is - implementing the ARMv8-A reference manual in this case):: +1. Determine which CPU features are available for the `max` CPU type + (Note, we started QEMU with qemu-system-aarch64, so `max` is + implementing the ARMv8-A reference manual in this case):: =20 (QEMU) query-cpu-model-expansion type=3Dfull model=3D{"name":"max"} { "return": { diff --git a/docs/virtio-net-failover.rst b/docs/virtio-net-failover.rst index 22f64c7bc8..6002dc5d96 100644 --- a/docs/virtio-net-failover.rst +++ b/docs/virtio-net-failover.rst @@ -1,6 +1,6 @@ -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D QEMU virtio-net standby (net_failover) -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 This document explains the setup and usage of virtio-net standby feature w= hich is used to create a net_failover pair of devices. diff --git a/docs/virtio-pmem.rst b/docs/virtio-pmem.rst index e77881b26f..4bf5d00443 100644 --- a/docs/virtio-pmem.rst +++ b/docs/virtio-pmem.rst @@ -27,17 +27,18 @@ virtio pmem usage ----------------- =20 A virtio pmem device backed by a memory-backend-file can be created on - the QEMU command line as in the following example: + the QEMU command line as in the following example:: =20 - -object memory-backend-file,id=3Dmem1,share,mem-path=3D./virtio_pmem.img= ,size=3D4G - -device virtio-pmem-pci,memdev=3Dmem1,id=3Dnv1 + -object memory-backend-file,id=3Dmem1,share,mem-path=3D./virtio_pmem.i= mg,size=3D4G + -device virtio-pmem-pci,memdev=3Dmem1,id=3Dnv1 =20 - where: - - "object memory-backend-file,id=3Dmem1,share,mem-path=3D, size= =3D" - creates a backend file with the specified size. + where: =20 - - "device virtio-pmem-pci,id=3Dnvdimm1,memdev=3Dmem1" creates a virtio = pmem - pci device whose storage is provided by above memory backend device. + - "object memory-backend-file,id=3Dmem1,share,mem-path=3D, size= =3D" + creates a backend file with the specified size. + + - "device virtio-pmem-pci,id=3Dnvdimm1,memdev=3Dmem1" creates a virtio p= mem + pci device whose storage is provided by above memory backend device. =20 Multiple virtio pmem devices can be created if multiple pairs of "-objec= t" and "-device" are provided. @@ -50,7 +51,7 @@ memory backing has to be added via 'object_add'; afterwar= ds, the virtio pmem device can be added via 'device_add'. =20 For example, the following commands add another 4GB virtio pmem device to -the guest: +the guest:: =20 (qemu) object_add memory-backend-file,id=3Dmem2,share=3Don,mem-path=3Dvir= tio_pmem2.img,size=3D4G (qemu) device_add virtio-pmem-pci,id=3Dvirtio_pmem2,memdev=3Dmem2 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 4 23:22:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576837580; cv=none; d=zohomail.com; s=zohoarc; b=QSlDWxMiEAagjNixxa1wk2NusQGmoY07At3Mv+zdXvoAM7E0UK818ei6drpwez9m81Exv/V6FtKWpRiItiit4/HagcAwfN1R8bzvDPDQHF7TyA40+HvzPaD7NPsWK5udovOBSmON5JzlMM/fM56IFlsjWldU4BltK2n2uVl+C1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576837580; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cbdbFL7gAJjs6YCJRctscwCdL9GqFqSyjm8ZrJd7Qqg=; b=jhIeClitFx1M2yjXqWiguSffwkGs+swOkyCAQKfCF4MVBCCAUU3jh9a4eKOE4sDyvCXUAmRpSY9/T2P+JODYIbPciEtxbE+qJ9d5V86WEU8202n2sBnTTqTEoyUDycQxV51Qjpc4pWzsXp125TUVJvZ2DM2/V3XY/R1XeEJGDYg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576837580804578.086292658629; Fri, 20 Dec 2019 02:26:20 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-3g5wCfRwPUWH0Yltz4uG2A-1; Fri, 20 Dec 2019 05:25:52 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CE68800053; Fri, 20 Dec 2019 10:25:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 742F363F66; Fri, 20 Dec 2019 10:25:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2AC80252D4; Fri, 20 Dec 2019 10:25:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBKAPe3C023598 for ; Fri, 20 Dec 2019 05:25:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6225560C87; Fri, 20 Dec 2019 10:25:40 +0000 (UTC) Received: from localhost (unknown [10.36.118.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 360BA60C18; Fri, 20 Dec 2019 10:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576837579; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cbdbFL7gAJjs6YCJRctscwCdL9GqFqSyjm8ZrJd7Qqg=; b=Oh1KaXJhUL3+uDJZ7itKLhiRpAH7xX7JOlgTN1PM45IBdu0ggHzyCryzmLXMnV2NcX5oH5 cNEGmr4fL2nzFdiEDQgeP4pcxekwHsSbqbjJW4vMZfZGhhypgrFpTQdhbI5HBIGCaI4nAF BgoG7OsT/suqQ5Z9PG7jPXf16PgX0EM= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Fri, 20 Dec 2019 10:25:20 +0000 Message-Id: <20191220102520.1637190-4-stefanha@redhat.com> In-Reply-To: <20191220102520.1637190-1-stefanha@redhat.com> References: <20191220102520.1637190-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Peter Maydell , Xie Yongji , Eduardo Habkost , qemu-block@nongnu.org, libvir-list@redhat.com, Jason Wang , qemu-stable@nongnu.org, Max Reitz , Chai Wen , Stefan Hajnoczi , Li Hangjing Subject: [libvirt] [PULL 3/3] virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 3g5wCfRwPUWH0Yltz4uG2A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Li Hangjing When the number of a virtio-blk device's virtqueues is larger than BITS_PER_LONG, the out-of-bounds access to bitmap[ ] will occur. Fixes: e21737ab15 ("virtio-blk: multiqueue batch notify") Cc: qemu-stable@nongnu.org Cc: Stefan Hajnoczi Signed-off-by: Li Hangjing Reviewed-by: Xie Yongji Reviewed-by: Chai Wen Message-id: 20191216023050.48620-1-lihangjing@baidu.com Message-Id: <20191216023050.48620-1-lihangjing@baidu.com> Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-bl= k.c index 119906a5fe..1b52e8159c 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -67,7 +67,7 @@ static void notify_guest_bh(void *opaque) memset(s->batch_notify_vqs, 0, sizeof(bitmap)); =20 for (j =3D 0; j < nvqs; j +=3D BITS_PER_LONG) { - unsigned long bits =3D bitmap[j]; + unsigned long bits =3D bitmap[j / BITS_PER_LONG]; =20 while (bits !=3D 0) { unsigned i =3D j + ctzl(bits); --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list