From nobody Mon Feb 9 17:57:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576750026; cv=none; d=zohomail.com; s=zohoarc; b=K7wg/oCzB0WTJkZjAfg9adlP0xoK+3LCNaI3VrL8Lcy+GOrDrGqk9MBfP2b0oiGFULvo8u0XGtVtVgErxr+jTlFfJ1pmrsMmlWRyRi1FUnTxLPUCvoLsLso3jds9bJWFkL36eUC86AdnS04RalFU47unW3motG7uwiHvgpeearE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576750026; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G8HFRvtpyQlXPY6NF6jQFsIx50n3riKYsEdL/uf82NU=; b=QdO9dBxMIeFZOm6AuZ0LK7+mGdNl1dMhI2gB0mjTyLwBPzg2+BHsael8VsPAFDF8l0SCJyMpIKyu5OxHhXW68yeFeWH3qhEARV6MLgIGnXurSTMKtwqJQuijhOBt0SyCLSoHvD/X703FtPAWM0ShOdrLI4OsjPyMI3UaQtjcrG8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576750026668799.3593812593173; Thu, 19 Dec 2019 02:07:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-kUf5L7WjNtG6eh9ORuiNZg-1; Thu, 19 Dec 2019 05:06:03 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B25F218FE870; Thu, 19 Dec 2019 10:05:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88DB75C1B0; Thu, 19 Dec 2019 10:05:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4327A18034FD; Thu, 19 Dec 2019 10:05:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBJA5YVj011098 for ; Thu, 19 Dec 2019 05:05:34 -0500 Received: by smtp.corp.redhat.com (Postfix) id 405B026DF9; Thu, 19 Dec 2019 10:05:34 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9299126E4E; Thu, 19 Dec 2019 10:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576750025; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=G8HFRvtpyQlXPY6NF6jQFsIx50n3riKYsEdL/uf82NU=; b=czP+mvjKXHBgAl6xuBc0xulNkFxPT8ElWm8ytnPChLaSzox8duoe7MKPPqpHqdbfphrXDK bjHH7tdpgwzZlyBYw2fquFIswAZrrKDX8umsebnjUfBV/bKKnP2OhQIewKoc4iOVsTYvXB 69+Q3FCyiZQYFaPKWM8DUQMzkU6MCBY= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Thu, 19 Dec 2019 11:04:36 +0100 Message-Id: <20191219100447.210836-32-fidencio@redhat.com> In-Reply-To: <20191219100447.210836-1-fidencio@redhat.com> References: <20191219100447.210836-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 31/42] network: Don't check the output of virGetUserRuntimeDirectory() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: kUf5L7WjNtG6eh9ORuiNZg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 98aa530715..c9c45df758 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -741,8 +741,6 @@ networkStateInitialize(bool privileged, } else { configdir =3D virGetUserConfigDirectory(); rundir =3D virGetUserRuntimeDirectory(); - if (!rundir) - goto error; =20 network_driver->networkConfigDir =3D g_strdup_printf("%s/qemu/netw= orks", configdir); network_driver->networkAutostartDir =3D g_strdup_printf("%s/qemu/n= etworks/autostart", configdir); --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list