From nobody Tue Feb 10 03:37:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576750107; cv=none; d=zohomail.com; s=zohoarc; b=oAbW0sRWiAlkLpA9XiNl8pCRJDcCY/rJkQCO8cd/FGGMhI9q5YyyMdUAhpnGDSgAyQ2yRFP2PQ+AZra8SY3fil/WAAfBiN+AadaMERmSOtt9CWiGHjpCF3cZ01EdL7tzomFBvWxDYPN0XpSmbxMJf9qFKtSV4AsmgY4ScQE5eTY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576750107; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sPp7nNWNBayZFYu9FAKXBpZqCJ+64xcdoppv98g6/zs=; b=gjfC5sHRVGrK/3wuAZINMMhdqqYrBxc3O5HnpCstRNiLIEQL1dMgb1ulXKrTiRIPFvxgGScHPiZZNcGy1rfB8YjTAID+UxdCK7DykWcW//a3tm0APsR+7ldoJtlPNA0CNrgWjLZ34CSoDSTvX1soyF6I+aIToCuIxl+fsfksFks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576750107570228.39827593008386; Thu, 19 Dec 2019 02:08:27 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-KLju_YY0PXOr16pcgP5Cvw-1; Thu, 19 Dec 2019 05:05:41 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33CAEDB68; Thu, 19 Dec 2019 10:05:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E09B7D9A8; Thu, 19 Dec 2019 10:05:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C2C3A827F6; Thu, 19 Dec 2019 10:05:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBJA5HCc010956 for ; Thu, 19 Dec 2019 05:05:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7A14E26DF9; Thu, 19 Dec 2019 10:05:17 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCA6626E55; Thu, 19 Dec 2019 10:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576750106; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sPp7nNWNBayZFYu9FAKXBpZqCJ+64xcdoppv98g6/zs=; b=LjdzGDwFW4jNV0Wkgkaw8SZD+9+az2uIhOpgSl63l7G/z2pDSEK/9ET8UGDccker21K1vb BtYo29tzwUA1JLpQIpcom1MNsYWgbkU2YQ0raZFbGFtUDKUQTyXaUTaNk19t+HGpQsf/zY nEu6xdfpgmczuFXyjpWjhU8BwVTza50= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Thu, 19 Dec 2019 11:04:24 +0100 Message-Id: <20191219100447.210836-20-fidencio@redhat.com> In-Reply-To: <20191219100447.210836-1-fidencio@redhat.com> References: <20191219100447.210836-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 19/42] network: Don't check the output of virGetUserConfigDirectory() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: KLju_YY0PXOr16pcgP5Cvw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index e360645969..98aa530715 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -741,7 +741,7 @@ networkStateInitialize(bool privileged, } else { configdir =3D virGetUserConfigDirectory(); rundir =3D virGetUserRuntimeDirectory(); - if (!(configdir && rundir)) + if (!rundir) goto error; =20 network_driver->networkConfigDir =3D g_strdup_printf("%s/qemu/netw= orks", configdir); --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list