From nobody Mon Feb 9 17:57:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576750149; cv=none; d=zohomail.com; s=zohoarc; b=VkQFWnwXEeeOAsES1AIzdDXmbpq/aie9jZxdRChTCNzGL07ZLpx7gDZkebdarOKHfO+7ES7oC/VRhAT7Uk3v6nR3ccvkLTCINUfosQgnlcqwe+lmw7JurUJC6jC2mcTUr5Djh5CH4pGOLfDpSri2mMb7zlKTAcgti2wBSbxV6zE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576750149; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BpD0VIBFZd1o+pDErGkZaUupYee0+sXWpSgsYEejLgE=; b=IS/SvbBvMQKijC2uUPo96lSAAyTB78mABAvdsA5jAhNSCJdiQHb39xUmA3Rx8SO7UN6dEp0NyWmj2+++8rKJgrfBarNqUeiWO/5iVYOUxZHjwts6KPwuafkDd3fJ/CLlCsRdJRODiuf2p4vMAQWNjuX5vrpbFTR5JwfNK0urELk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1576750149318955.6953691371472; Thu, 19 Dec 2019 02:09:09 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-l7HwALLwPVGCOskFed4U6g-1; Thu, 19 Dec 2019 05:05:47 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CE32DB66; Thu, 19 Dec 2019 10:05:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 290FF6046B; Thu, 19 Dec 2019 10:05:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D77061803C33; Thu, 19 Dec 2019 10:05:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBJA5FVJ010934 for ; Thu, 19 Dec 2019 05:05:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8313E26E4E; Thu, 19 Dec 2019 10:05:15 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id D539526DF9; Thu, 19 Dec 2019 10:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576750148; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BpD0VIBFZd1o+pDErGkZaUupYee0+sXWpSgsYEejLgE=; b=Ds1uIpWFbek/RAs2ZLDBUbA7SU2YtRWDg+wOPN+Ntna4vynccrvq7/aBt3hbvzaSp2JS9S QLRcCSIuU3oP0R9iSZFws4DwbRSnbLYceHfL/6Psk/4XwhUc4H1WBkMpHbtqCM/mP9apyW ZlfAg+o7lzgItmvSsm1rFunNejYfgPE= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Thu, 19 Dec 2019 11:04:22 +0100 Message-Id: <20191219100447.210836-18-fidencio@redhat.com> In-Reply-To: <20191219100447.210836-1-fidencio@redhat.com> References: <20191219100447.210836-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [PATCH 17/42] remote: Don't check the output of virGetUserConfigDirectory() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: l7HwALLwPVGCOskFed4U6g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: J=C3=A1n Tomko --- src/remote/remote_daemon_config.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/remote/remote_daemon_config.c b/src/remote/remote_daemon_c= onfig.c index ae6b491686..84e331474b 100644 --- a/src/remote/remote_daemon_config.c +++ b/src/remote/remote_daemon_config.c @@ -81,17 +81,13 @@ daemonConfigFilePath(bool privileged, char **configfile) } else { char *configdir =3D NULL; =20 - if (!(configdir =3D virGetUserConfigDirectory())) - goto error; + configdir =3D virGetUserConfigDirectory(); =20 *configfile =3D g_strdup_printf("%s/%s.conf", configdir, DAEMON_NA= ME); VIR_FREE(configdir); } =20 return 0; - - error: - return -1; } =20 struct daemonConfig* --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list