[libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point

marcandre.lureau@redhat.com posted 1 patch 4 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191210150853.1725560-1-marcandre.lureau@redhat.com
docs/formatsecret.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point
Posted by marcandre.lureau@redhat.com 4 years, 3 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Support by usage name can be considered separately (with a 'usage'
attribute?).

Cc: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 docs/formatsecret.html.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
index 8d0630a7c3..8f5383cf64 100644
--- a/docs/formatsecret.html.in
+++ b/docs/formatsecret.html.in
@@ -334,8 +334,8 @@ Secret value set
       of the vTPM.
       The <code>&lt;usage type='vtpm'&gt;</code> element must contain
       a single <code>name</code> element that specifies a usage name
-      for the secret.  The vTPM secret can then be used by UUID or by
-      this usage name via the <code>&lt;encryption&gt;</code> element of
+      for the secret.  The vTPM secret can then be used by UUID
+      via the <code>&lt;encryption&gt;</code> element of
       a <a href="formatdomain.html#elementsTpm">tpm</a> when using an
       emulator.
       <span class="since">Since 5.6.0</span>. The following is an example
-- 
2.24.0.308.g228f53135a

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point
Posted by Christophe de Dinechin 4 years, 3 months ago

> On 10 Dec 2019, at 16:08, marcandre.lureau@redhat.com wrote:
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Support by usage name can be considered separately (with a 'usage'
> attribute?).
> 
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> docs/formatsecret.html.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
> index 8d0630a7c3..8f5383cf64 100644
> --- a/docs/formatsecret.html.in
> +++ b/docs/formatsecret.html.in
> @@ -334,8 +334,8 @@ Secret value set
>       of the vTPM.
>       The <code>&lt;usage type='vtpm'&gt;</code> element must contain
>       a single <code>name</code> element that specifies a usage name
> -      for the secret.  The vTPM secret can then be used by UUID or by
> -      this usage name via the <code>&lt;encryption&gt;</code> element of
> +      for the secret.  The vTPM secret can then be used by UUID
> +      via the <code>&lt;encryption&gt;</code> element of
>       a <a href="formatdomain.html#elementsTpm">tpm</a> when using an
>       emulator.
>       <span class="since">Since 5.6.0</span>. The following is an example
> -- 
> 2.24.0.308.g228f53135a

Reminds me of our discussion :-)

Reviewed-by: Christophe de Dinechin <dinechin@redhat.com>

> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point
Posted by Stefan Berger 4 years, 3 months ago
On 12/10/19 10:08 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Support by usage name can be considered separately (with a 'usage'
> attribute?).
>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
>   docs/formatsecret.html.in | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
> index 8d0630a7c3..8f5383cf64 100644
> --- a/docs/formatsecret.html.in
> +++ b/docs/formatsecret.html.in
> @@ -334,8 +334,8 @@ Secret value set
>         of the vTPM.
>         The <code>&lt;usage type='vtpm'&gt;</code> element must contain
>         a single <code>name</code> element that specifies a usage name
> -      for the secret.  The vTPM secret can then be used by UUID or by
> -      this usage name via the <code>&lt;encryption&gt;</code> element of
> +      for the secret.  The vTPM secret can then be used by UUID
> +      via the <code>&lt;encryption&gt;</code> element of
>         a <a href="formatdomain.html#elementsTpm">tpm</a> when using an
>         emulator.
>         <span class="since">Since 5.6.0</span>. The following is an example



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point
Posted by Cole Robinson 4 years, 3 months ago
On 12/10/19 10:08 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Support by usage name can be considered separately (with a 'usage'
> attribute?).
> 
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  docs/formatsecret.html.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
> index 8d0630a7c3..8f5383cf64 100644
> --- a/docs/formatsecret.html.in
> +++ b/docs/formatsecret.html.in
> @@ -334,8 +334,8 @@ Secret value set
>        of the vTPM.
>        The <code>&lt;usage type='vtpm'&gt;</code> element must contain
>        a single <code>name</code> element that specifies a usage name
> -      for the secret.  The vTPM secret can then be used by UUID or by
> -      this usage name via the <code>&lt;encryption&gt;</code> element of
> +      for the secret.  The vTPM secret can then be used by UUID
> +      via the <code>&lt;encryption&gt;</code> element of
>        a <a href="formatdomain.html#elementsTpm">tpm</a> when using an
>        emulator.
>        <span class="since">Since 5.6.0</span>. The following is an example
> 

I've pushed this now

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list