From nobody Sat May 4 21:29:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575652723; cv=none; d=zohomail.com; s=zohoarc; b=MgChHEIGasgJQBuBqjFC419uorgj7gdrhT/5Fq0X1UdHGd7XJQTZpSY6MCCI+kGk2oBDfTR5MDZvxNcqqT9MtSjE7a3AVQjXbM2YjHwInipFu+w4TdowCmq56ClP7dXr4qzOMp9MGl0hWFUo9FnzRP8NX2Atjis3QnZS+oHMC+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575652723; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SQsmbReRH3D5W0x0gm+G5tXT6KRtyi5PR+e3WXM5yoA=; b=lxNw/sszsBc8/e4H5B7lVRV/Lf4x4P0VjmvFm9JJkW5pr/217KwpDezJ0ELyrq19mEySZfZuHLQ0eZKOiCuoKoGwu91DcmTLs8uiS2uQlIMsjouFNeVg64h/qp1DVEKdw+Qx5MeYH9zmqJwFDZumM/hAN3mQiVAKWpI5BvgHuBo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1575652723085323.0826859274481; Fri, 6 Dec 2019 09:18:43 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-jdikmYbSNgq9DIqMGHbCdA-1; Fri, 06 Dec 2019 12:18:39 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A46C800D5B; Fri, 6 Dec 2019 17:18:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E745960BF4; Fri, 6 Dec 2019 17:18:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A31F86B4C3; Fri, 6 Dec 2019 17:18:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB6HIMh2029831 for ; Fri, 6 Dec 2019 12:18:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id C40276B8EB; Fri, 6 Dec 2019 17:18:22 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAEE26B8EA; Fri, 6 Dec 2019 17:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575652721; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SQsmbReRH3D5W0x0gm+G5tXT6KRtyi5PR+e3WXM5yoA=; b=exMOZIPAeFrZm0/3LNOeqyfiCjDIYhcEXAastL0dXBwWxPQqQpCZEH1WBnHNpEw6WN7VV5 HbTn/VRyC6wkoTczzOMgZg8MVBhnr7hYNEeYQoHYX2sb/6+nqUOeqiRt72zQEZsuFPAWrG ytA5HFQSmsaQeAcmCuUf72BRqPAdLZI= From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 6 Dec 2019 17:18:16 +0000 Message-Id: <20191206171816.3932978-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] scripts: ignore remote protocol checks if pdwtags crashes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: jdikmYbSNgq9DIqMGHbCdA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote protocol files. This crash was previously ignored by 'make check' because of the way we piped the pdwtags output to the perl post-processing scripts. When this was converted to use python it mistakenly started being a fatal error. We need to explicitly ignore pdwtags output if it exited with non-zero return code. Signed-off-by: Daniel P. Berrang=C3=A9 --- scripts/check-remote-protocol.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protoc= ol.py index 201166fd9e..25caa19563 100644 --- a/scripts/check-remote-protocol.py +++ b/scripts/check-remote-protocol.py @@ -86,8 +86,12 @@ out, err =3D pdwtagsproc.communicate() out =3D out.decode("utf-8") err =3D err.decode("utf-8") =20 -if out =3D=3D "" and err !=3D "": - print("WARNING: no output, pdwtags appears broken:", file=3Dsys.stderr) +if out =3D=3D "" or pdwtagsproc.returncode !=3D 0: + if out =3D=3D "": + print("WARNING: no output, pdwtags appears broken:", file=3Dsys.st= derr) + else: + print("WARNING: exit code %d, pdwtags appears broken:" % + pdwtagsproc.returncode, file=3Dsys.stderr) for l in err.strip().split("\n"): print("WARNING: %s" % l, file=3Dsys.stderr) print("WARNING: skipping the remote protocol test", file=3Dsys.stderr) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list