From nobody Wed May 1 17:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575476376; cv=none; d=zohomail.com; s=zohoarc; b=Wbr5Cqhlhuxw/9Jw1vdZyMkEIIP2QJa2GsHHfrzqYTASPmdZwZkOEbKGJR711ipJZ6ULey4/CBsg3NZ3vUTs57/F77FSwFxDizeWe+WIY6X9U8t4pR16dcMpLTFcRheMzIdIJk2Km+VAP0YB5UeBC4JWctO0VJ2VTxib/6f2lwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575476376; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mBEtd8oxdgymOC5KGks1TVXHjN8Exusc9kNLeAIumZk=; b=CSrQQL1y5d9+zRoQBoa1+jDt6JP2qNE/xmg6iPDmFGr+ZQkTW4lXBXll0wSOlPCDAiBBRyGWPOHuc8M4LBEFMUMntEPtyaxITYWgdav3UV35EdalZiYq381hYK1aY87y5uz9/tcOEu5naHo/Vd0xhFFgSbAmKxphWCSLMov5y+k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575476376513720.4273025775633; Wed, 4 Dec 2019 08:19:36 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-OWwdAxdyPEyVzLXfipxZIw-1; Wed, 04 Dec 2019 11:19:32 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E49D8017DF; Wed, 4 Dec 2019 16:19:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 242EA6117D; Wed, 4 Dec 2019 16:19:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1757318034E9; Wed, 4 Dec 2019 16:19:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB4GJNZl015555 for ; Wed, 4 Dec 2019 11:19:23 -0500 Received: by smtp.corp.redhat.com (Postfix) id 909495D6BB; Wed, 4 Dec 2019 16:19:23 +0000 (UTC) Received: from laerte.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 861595D6AE; Wed, 4 Dec 2019 16:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575476375; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mBEtd8oxdgymOC5KGks1TVXHjN8Exusc9kNLeAIumZk=; b=N3/VrtvjOREdXrdCLGdLHyCoHnU8l1k2iyMd+jZqN++SRJR84CUrg+otRv1Gd9Nxrwa7UM 6M5zK/FCE0K3w5AQoQv4RP0kP6TQnQZa9mXUcaZoTgobJGgbi6I+tb6s48iGMtWijKEDQF 7KQjxdjrrn8F7M1htaDsWkoUkfhAiVk= From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Wed, 4 Dec 2019 17:19:17 +0100 Message-Id: <20191204161917.1880301-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [jenkins-ci PATCH] lcitool: Add 'install=' to the extra_arg X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: OWwdAxdyPEyVzLXfipxZIw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Add "install=3D" unconditionally to the extra_arg parameter passed to virt-install. It's needed as the virt-install present on CentOS CI host does not use the correct kernel URL argument when installing OpenSUSE. This does not cause issues on other installations as the other distros will just ignore the argument passed. Signed-off-by: Fabiano Fid=C3=AAncio --- I've verified this solution works on a CentOS 7 host. I've verified this solution doesn't cause regressions on a Fedora 31 host. --- guests/lcitool | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 0e27796..c7f949d 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -542,8 +542,13 @@ class Application: # but we need to point anaconda in the right direction through # the 'ks' kernel parameter. We can use 'ks' unconditionally # for simplicity's sake, because distributions that don't use - # kickstart for unattended installation will simply ignore it - extra_arg =3D "console=3DttyS0 ks=3Dfile:/{}".format(install_c= onfig) + # kickstart for unattended installation will simply ignore it. + # Similarly to how we can use 'ks' unconditionally, we also can + # do the same with 'install' argument, needed to workaround a + # a bug on virt-install as it does not use the correct kernel + # URL argument when installing an OpenSUSE guest. + extra_arg =3D ("console=3DttyS0 ks=3Dfile:/{} install=3D{}". + format(install_config, facts["install_url"])) =20 virt_install =3D distutils.spawn.find_executable("virt-install= ") if virt_install is None: --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list