From nobody Sun Feb 8 18:49:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575469391; cv=none; d=zohomail.com; s=zohoarc; b=Zk1nhDTt7EObq8HGzzU9kLT0tfaqHyB+lxyDoVNT2J7YT21mnnv5qz0iiB1MOBYsWdSAHYbdXy8pviRLnmU2Bg54yQmd3sRckjG5uDj4vEGXq7BTrzDdf2BtCJbTkPxGrXLIfFjSMDKwQDih4rd4LW55NRaHpwkltsRxAs7Kpi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575469391; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9DE8hzlyCNL/KBye1JE30+AsY842PDSRDQxJ/pyhkRA=; b=PzLwOEnmk8fCh6phNq69tQ6RVnj3deT3FfQ32fn/4E2W3y2y/DtVF2aJGtZeUDRmleidDT1ZzOZuAa/qOiqk1+G+kYc3wuSOt7qLp/0JIX5OwkeDrnvXdRllPzwWEnNoNpF+Qyk21WmWCfZFhXfoL5BK9+gzKDX4oyGHXDX7F8U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575469391128484.21333579303575; Wed, 4 Dec 2019 06:23:11 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-4I9Zdg5BMV2Sp1zIZtrPtw-1; Wed, 04 Dec 2019 09:21:52 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3820E100EC09; Wed, 4 Dec 2019 14:21:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 097E819C7F; Wed, 4 Dec 2019 14:21:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B3E99180887A; Wed, 4 Dec 2019 14:21:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB4ELWnZ008166 for ; Wed, 4 Dec 2019 09:21:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id B7D54608F7; Wed, 4 Dec 2019 14:21:32 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3284691A3; Wed, 4 Dec 2019 14:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575469389; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9DE8hzlyCNL/KBye1JE30+AsY842PDSRDQxJ/pyhkRA=; b=S6Mvkh/V8d+VGcl52bk85Yh67RCVrbKCPDSrmm+KStuxMk/GirQtdzKipa4+GrgpWB8JtV H77d6dQWAvsQZzfqOMLaIlLwQiTA2uZalDlyJkgeqoKWQCl5PkhjQZcj9h9itufDvwb8qC 9riPoaYflSk+3ngIskH/DVnqFF0bDnw= From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 4 Dec 2019 14:20:54 +0000 Message-Id: <20191204142113.2961028-12-berrange@redhat.com> In-Reply-To: <20191204142113.2961028-1-berrange@redhat.com> References: <20191204142113.2961028-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 11/30] conf: drop virCapsPtr param from assign addresses callback X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 4I9Zdg5BMV2Sp1zIZtrPtw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The virCapsPtr param is not used by any of the virt drivers providing this callback. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_domain.c | 1 - src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 1 - src/qemu/qemu_domain.c | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index eebf5a7650..a321be54f4 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -167,7 +167,6 @@ bhyveDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, =20 static int bhyveDomainDefAssignAddresses(virDomainDef *def, - virCapsPtr caps G_GNUC_UNUSED, unsigned int parseFlags G_GNUC_UNUSED, void *opaque G_GNUC_UNUSED, void *parseOpaque G_GNUC_UNUSED) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8acc91de74..8dd1ff1017 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5870,7 +5870,7 @@ virDomainDefPostParse(virDomainDefPtr def, goto cleanup; =20 if (xmlopt->config.assignAddressesCallback) { - ret =3D xmlopt->config.assignAddressesCallback(def, caps, parseFla= gs, + ret =3D xmlopt->config.assignAddressesCallback(def, parseFlags, xmlopt->config.priv, data.parseOpaque); if (virDomainDefPostParseCheckFailure(def, parseFlags, ret) < 0) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index af57e288e9..7e925f45d8 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2660,7 +2660,6 @@ typedef int (*virDomainDeviceDefPostParseCallback)(vi= rDomainDeviceDefPtr dev, * @opaque is opaque data set by driver (usually pointer to driver * private data). */ typedef int (*virDomainDefAssignAddressesCallback)(virDomainDef *def, - virCapsPtr caps, unsigned int parseFlags, void *opaque, void *parseOpaque); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0076349558..362d644475 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -8116,7 +8116,6 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr de= v, =20 static int qemuDomainDefAssignAddresses(virDomainDef *def, - virCapsPtr caps G_GNUC_UNUSED, unsigned int parseFlags G_GNUC_UNUSED, void *opaque, void *parseOpaque) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list