From nobody Mon Feb 9 10:28:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575452303; cv=none; d=zohomail.com; s=zohoarc; b=AZwjjHYkmMrmtPfnyolPM7lIwpcsgpka1IO2TevrUOaLTFDS2orr6TRMZv/yOx1heJj72m6uTRIr6uqk8lqpcfL4taUqLGc/48KXNkcR1JRGq7UzOCTxITrnZ+sLfDAcANgM7YhOKza9hY0rjuGedwnfuDQd6HXMEFNZ/j/3B2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575452303; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TR5QBpyNp7tgC+YJ5Lzh69spjYvFblIgHEC1l+KP7lY=; b=SAR7uDd8GdGjsnxQswGGBi8YFAsQ/AfroZ6ESccypUO0CSeIJWjxsIDJQ//75kLdS8LdB2MYcgiX1ZLg7IpoxXozrTjosSLb7ewnyZ0CQfRF8NP7UaG16YXh3hvoEpa2MboIbZjZogfqw7Ss/y13KEi8ePeMr9iOd0witR/VmI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 157545230324448.64377395396741; Wed, 4 Dec 2019 01:38:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-We0P3R6UMV-LuOq_XeUpmw-1; Wed, 04 Dec 2019 04:36:55 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF5C9800D5C; Wed, 4 Dec 2019 09:36:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 861C95DA75; Wed, 4 Dec 2019 09:36:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1D9A718089CD; Wed, 4 Dec 2019 09:36:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB49aael022584 for ; Wed, 4 Dec 2019 04:36:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id B0E6260C85; Wed, 4 Dec 2019 09:36:36 +0000 (UTC) Received: from hansolo.pek2.redhat.com (wlc-trust-29.pek2.redhat.com [10.72.3.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CA0760C87; Wed, 4 Dec 2019 09:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575452302; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TR5QBpyNp7tgC+YJ5Lzh69spjYvFblIgHEC1l+KP7lY=; b=YHIovRvT8fwMTIOX7kWBlCjjyF9kRhK7AfkPLRa7O21zH2u8B+93SEyx+Ljl6BvuqsLG/f 5a5Z17sWlMwmgecGBFowag0ytqg7uSWbiY91RtLfK75Na+Ia2XNOBmBcra/qLdgwr43jrO iVV+rzi840QbSkmF5oU2s98yEmZhbp0= From: Han Han To: libvir-list@redhat.com Date: Wed, 4 Dec 2019 17:35:37 +0800 Message-Id: <20191204093539.7655-2-hhan@redhat.com> In-Reply-To: <20191204093539.7655-1-hhan@redhat.com> References: <20191204093539.7655-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: fiuczy@linux.ibm.com, mprivozn@redhat.com, danielhb413@gmail.com, Han Han Subject: [libvirt] [PATCH v3 1/3] conf: fix logic error for scsi units X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: We0P3R6UMV-LuOq_XeUpmw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Introduced in c8007fdc5d2, it should use 'greater than max' instead of 'equal or greater than max' for the condition of checking invalid scsi unit. Signed-off-by: Han Han --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9580884747..badc2da487 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4850,7 +4850,7 @@ virDomainSCSIDriveAddressIsUsed(const virDomainDef *d= ef, break; } =20 - if (max !=3D -1 && addr->unit >=3D max) + if (max !=3D -1 && addr->unit > max) return true; if (reserved !=3D -1 && addr->unit =3D=3D reserved) return true; --=20 2.24.0.rc1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list