From nobody Sat Apr 27 06:35:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575386767; cv=none; d=zohomail.com; s=zohoarc; b=BY2CAOPh5Rfemnw2ggPl0R9VE4FGpQCD4CpxsFwN9I9WTnoEKwu0OFwGSRJRK9WzcKUNPNlQYXMq7oYlYgqHC1oyq7lmv4uypbds+GCgZ6CJzWPzcEqvfcdl6l3SBRU69oruNO8N8rtVs0Yg1/EkhuMd9h14HZVkSQYyAuuqnb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575386767; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cNLJ44RVgvaJiNK2VRm1tu38bNYnaTN1g0niDPgB3Fc=; b=IeRVdFS5TyU8UUUdHOD/BjrvVse6QOGPcw5eYQFJOsOEbQlHF+dSemRZm222syFK96aZqIhOVBC3alxlX5Zkw2IU9qLkdCRKsMkFE8qUx4rR8CPCNC5penJ9uaEvWEmzxGw0G+p7V1HNg4lUBc3GVvbAhkLgNWYRHOBzCTTtkYI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1575386767582248.6229198107111; Tue, 3 Dec 2019 07:26:07 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-h0-VozoYMA6zBzfEbZpiVQ-1; Tue, 03 Dec 2019 10:26:01 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D1E6802B72; Tue, 3 Dec 2019 15:25:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6C94600C8; Tue, 3 Dec 2019 15:25:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6413018089CE; Tue, 3 Dec 2019 15:25:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB3FPpAH025396 for ; Tue, 3 Dec 2019 10:25:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0E5395D6B7; Tue, 3 Dec 2019 15:25:51 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1ABA5D6AE; Tue, 3 Dec 2019 15:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575386766; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cNLJ44RVgvaJiNK2VRm1tu38bNYnaTN1g0niDPgB3Fc=; b=f7zopETMQnAjG2e9YBVjCM9qSiSw7TLEVKRQmF77lBM3iIwR1Vudl89SpInOzyawBC7QO7 QzexzcIkdLJDlGfhDE2HFHSRsQoidSA00Ss4XSQj2LcQrt2vdF+T5kBg9Vjrr+mBs8ojPa Bf9ihgEc1R6MtJOIGDxlp0qxnnWrhj0= From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Tue, 3 Dec 2019 15:25:44 +0000 Message-Id: <20191203152544.1458207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] tests: stop static linking to libvirt code in tests X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: h0-VozoYMA6zBzfEbZpiVQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) If we static link to libvirt_util.la then we can't override functions in this file by simply implementing them in the test code. Any tests should dynamic link to the main libvirt.la and ensure symbols are exported. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- src/libvirt_private.syms | 2 ++ tests/Makefile.am | 11 +++-------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 8fe0bf9365..0864de030b 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -915,6 +915,8 @@ virDomainSnapshotDefFormat; virDomainSnapshotDefIsExternal; virDomainSnapshotDefNew; virDomainSnapshotDefParseString; +virDomainSnapshotDiskDefFree; +virDomainSnapshotDiskDefParseXML; virDomainSnapshotFormatConvertXMLFlags; virDomainSnapshotIsExternal; virDomainSnapshotLocationTypeFromString; diff --git a/tests/Makefile.am b/tests/Makefile.am index e009de830c..af8fd69842 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -662,8 +662,7 @@ qemublocktest_SOURCES =3D \ $(NULL) qemublocktest_LDADD =3D \ libqemumonitortestutils.la \ - ../src/libvirt_conf.la \ - ../src/libvirt_util.la \ + ../src/libvirt.la \ $(qemu_LDADDS) \ $(NULL) =20 @@ -939,8 +938,7 @@ storagevolxml2argvtest_SOURCES =3D \ storagevolxml2argvtest_LDADD =3D \ $(LIBXML_LIBS) \ ../src/libvirt_driver_storage_impl.la \ - ../src/libvirt_conf.la \ - ../src/libvirt_util.la \ + ../src/libvirt.la \ $(LDADDS) =20 storagepoolxml2argvtest_SOURCES =3D \ @@ -949,8 +947,7 @@ storagepoolxml2argvtest_SOURCES =3D \ storagepoolxml2argvtest_LDADD =3D \ $(LIBXML_LIBS) \ ../src/libvirt_driver_storage_impl.la \ - ../src/libvirt_conf.la \ - ../src/libvirt_util.la \ + ../src/libvirt.la \ $(LDADDS) =20 storagepoolxml2xmltest_SOURCES =3D \ @@ -1150,8 +1147,6 @@ virstoragetest_SOURCES =3D \ virstoragetest.c testutils.h testutils.c virstoragetest_LDADD =3D $(LDADDS) \ ../src/libvirt.la \ - ../src/libvirt_conf.la \ - ../src/libvirt_util.la \ ../src/libvirt_driver_storage_impl.la \ ../gnulib/lib/libgnu.la \ $(NULL) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list