From nobody Thu May 2 13:41:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575372017; cv=none; d=zohomail.com; s=zohoarc; b=hLL/zAtm5cL3dtDmUwOPSg9GKfnwPioVJ8A6tUU02yKWYNC++J9Aviaq59rFqPB3u7cA1zYDK/cuDqK2sc1mGSbPBx32w3IKdXScmD7/D6DdSTyavjHq9K6lznFdrg82qYAX7D3idyJZ6QKSzZzme8UsObkidyvNz6rZLQYviXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575372017; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=eMDGRFzqigJIQm1xHhRHj83O47KmBHQ0t/odgo0ODrQ=; b=f2F3iAZB2/ezUGMrgXnsNruJuihouCRlfcoLcix1Tr1LudWiemXl/vCoCQ8I8fhifPCnQXZl1ImilNSXidG4xidf13Es6vImQG1mP1emIj06J5OD33vkS6fZZcXla3yrfPDlY8w7M8gIHLVAHEHu9hwg4BbWMSiQz8CZW1y8kK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1575372017025921.5512852595776; Tue, 3 Dec 2019 03:20:17 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-YXnCfGZCOq6qrx6b6-aaew-1; Tue, 03 Dec 2019 06:20:14 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AA001803687; Tue, 3 Dec 2019 11:20:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3040910001BD; Tue, 3 Dec 2019 11:20:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D197218089CD; Tue, 3 Dec 2019 11:20:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB3BK8lU008692 for ; Tue, 3 Dec 2019 06:20:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0299D60C05; Tue, 3 Dec 2019 11:20:08 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (ovpn-205-16.brq.redhat.com [10.40.205.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01A9360BFB; Tue, 3 Dec 2019 11:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575372015; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eMDGRFzqigJIQm1xHhRHj83O47KmBHQ0t/odgo0ODrQ=; b=Uqe09aOTPwIlmX4BdmIS2ZXF5aHzLmwQJ3byAL9TDAjPSe40Lpz/mGWBZf50mveZZLAXT7 HKJUVnlKYoMwOCDnvwXKbYZZVn33FhWyM3+L9pcpAKiao8BKfZcF28YbVP6roVDVT9xOYL sfCDk2r/4KS3kelykrYk5KlVqShYBmI= From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 3 Dec 2019 12:19:55 +0100 Message-Id: <20191203111955.13195-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: fidencio@redhat.com Subject: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: YXnCfGZCOq6qrx6b6-aaew-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It's not immediately obvious why we're using it even when installing a distribution like Debian, so explain the motivation in a comment. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index a630971..0e27796 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -540,7 +540,9 @@ class Application: # preseed files must use a well-known name to be picked up by # d-i; for kickstart files, we can use whatever name we please # but we need to point anaconda in the right direction through - # a kernel argument + # the 'ks' kernel parameter. We can use 'ks' unconditionally + # for simplicity's sake, because distributions that don't use + # kickstart for unattended installation will simply ignore it extra_arg =3D "console=3DttyS0 ks=3Dfile:/{}".format(install_c= onfig) =20 virt_install =3D distutils.spawn.find_executable("virt-install= ") --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list