From nobody Mon Feb 9 00:54:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575276192; cv=none; d=zohomail.com; s=zohoarc; b=CIF2HBVtjbn8HLn/5khCsr7GseLibw3CGp9RproGwUM0Q1jpRRPwi66UR5I39z2EGnQWozjSuTpBYnnZYFfp4qWul1oKq0DHmflnNLq9BCXTJAMq06Q57p/qtfn7ZoZ1sYCb38LXg+wbxHG0pHZtKjcsPFUq5Y/jMDZRIW6nfAA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575276192; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tAzsdAfKhxFI9j0OkPzF+24mhoPWqXHtalreGE+Hi9A=; b=VvmZv0p5ZJPpQHpWsd+b45ktDyTRn3u4Ul1xCPTL/IddiN69M50JU38n+uIgkvL9HZNLXF+RSgrnJbsntT1IS7FRyt6Rgw88szonR1IJvrVX+hz0q0eDkzAWQKjfaHNe9+mZkLzsP093T7tJNSm4EcRp7+rVSFnen/ZEilqdWmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575276192468122.07814411246216; Mon, 2 Dec 2019 00:43:12 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-DhKL-5-RORaKvrehl31Cmg-1; Mon, 02 Dec 2019 03:43:09 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9CF6800C7B; Mon, 2 Dec 2019 08:43:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77A72600C8; Mon, 2 Dec 2019 08:43:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 237CB4EA2E; Mon, 2 Dec 2019 08:43:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB28grQX011532 for ; Mon, 2 Dec 2019 03:42:53 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9C7ED5C3FD; Mon, 2 Dec 2019 08:42:53 +0000 (UTC) Received: from hansolo.pek2.redhat.com (wlc-trust-29.pek2.redhat.com [10.72.3.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C2B45C3FA; Mon, 2 Dec 2019 08:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575276191; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tAzsdAfKhxFI9j0OkPzF+24mhoPWqXHtalreGE+Hi9A=; b=N81bsEBZXGukHlyLssguAOQyOhlpPQjK+b7KfhVSMZMjF0ZiRjTgqdxjSCUTzBtyetsJCb t1jLwUeXwar+uruiPu0Qp96cpNfRPhl9bYSSJ+igz/mvrEWugTPQCbrN+jyXl9VODu8fIp MUmzwLuGpHwxjurczkr9Q92ZXJ3b14w= From: Han Han To: libvir-list@redhat.com Date: Mon, 2 Dec 2019 16:41:24 +0800 Message-Id: <20191202084124.17495-2-hhan@redhat.com> In-Reply-To: <20191202084124.17495-1-hhan@redhat.com> References: <20191202084124.17495-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH v2 1/2] conf: fix logic error for scsi units X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: DhKL-5-RORaKvrehl31Cmg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Introduced in c8007fdc5d2, it should use 'greater than max' instread of 'equal or greater than max' for the condition of checking invalid scsi unit. Signed-off-by: Han Han Reviewed-by: Boris Fiuczynski Reviewed-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9580884747..badc2da487 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4850,7 +4850,7 @@ virDomainSCSIDriveAddressIsUsed(const virDomainDef *d= ef, break; } =20 - if (max !=3D -1 && addr->unit >=3D max) + if (max !=3D -1 && addr->unit > max) return true; if (reserved !=3D -1 && addr->unit =3D=3D reserved) return true; --=20 2.24.0.rc1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list