From nobody Fri Mar 29 13:47:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575022719; cv=none; d=zohomail.com; s=zohoarc; b=Lr+rIJgUUz4CCUTGbwSH9wouUgswzBwRHsMJ+CyDDEetcDvduMixdMqM7gvvhJ5iEfhbFHRGPMNk/Q33q50QnwPaOo2Mt6oTRbllT3nYl+J1rddWMQxjrAws7+c96Quh/Mj9vKw4pIJVncEa/fX7vVcVVMtGmJCPnMs38Sd295s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575022719; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NPLkKk1Gu2i5WlcAdRO8/1wE2GfKR2ISR5XtZJ6Q1uo=; b=AB2hpk3fBHygGrpZE46TLRb/x6RYK2a9LYR+nu5ZrLrWbNOx40JTMijHluUtihtWR3KaNxJWLmQkCkpqkn2oPPidbUrShmbGBGYoQrq7j92aaWt/uq9B2ajkkhZnk5c8DVhEyU8fyZ2iyNB2APQl4r6iQSF5gX7glSLr9ego1qM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575022719955967.203563192476; Fri, 29 Nov 2019 02:18:39 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-2ris_qJ4MDWevpRcaDwMLA-1; Fri, 29 Nov 2019 05:18:36 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67DD4184CABB; Fri, 29 Nov 2019 10:18:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31CFB60BE2; Fri, 29 Nov 2019 10:18:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ABDD24E566; Fri, 29 Nov 2019 10:18:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xATAITL0007748 for ; Fri, 29 Nov 2019 05:18:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id 91BCF5D6D2; Fri, 29 Nov 2019 10:18:29 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-12-169.pek2.redhat.com [10.72.12.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13C5263BBA; Fri, 29 Nov 2019 10:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575022717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NPLkKk1Gu2i5WlcAdRO8/1wE2GfKR2ISR5XtZJ6Q1uo=; b=TmJCFiPz8/F/lXUL1yIj+PsYx9oPkA7CO9+0T+hUSxS5HAQVM+r6Wiov8/mcC7gaMJGMA2 Fe7nmVZWBshupvxvY5tMUvlqFA4+Gv/vq3tnTBYMbbMCJ/7cTku8sU2eZDphBwB3v7ryG0 53226rrO6qMm/i8LoSiY4YZNK1cFCd0= From: Han Han To: libvir-list@redhat.com Date: Fri, 29 Nov 2019 18:18:15 +0800 Message-Id: <20191129101816.130249-2-hhan@redhat.com> In-Reply-To: <20191129101816.130249-1-hhan@redhat.com> References: <20191129101816.130249-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH 1/2] conf: Allow virtio scsi to using unit 16383 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 2ris_qJ4MDWevpRcaDwMLA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In qemu, 16383 is the top valid value for virtio scsi unit number: $ /usr/libexec/qemu-kvm \ -device \ virtio-scsi-pci,id=3Dscsi0,bus=3Dpci.0,addr=3D0x6 \ -drive \ file=3DA.qcow2,format=3Dqcow2,if=3Dnone,id=3Ddrive -device \ scsi-hd,bus=3Dscsi0.0,channel=3D0,scsi-id=3D0,lun=3D16383,drive=3Ddrive,id= =3Ddisk VNC server running on ::1:5900 $ /usr/libexec/qemu-kvm \ -device \ virtio-scsi-pci,id=3Dscsi0,bus=3Dpci.0,addr=3D0x6 \ -drive \ file=3DA.qcow2,format=3Dqcow2,if=3Dnone,id=3Ddrive -device \ scsi-hd,bus=3Dscsi0.0,channel=3D0,scsi-id=3D0,lun=3D16384,drive=3Ddrive,id= =3Ddisk qemu-kvm: ...: bad scsi device lun: 16384 So adjust libvirt to use the virtio scsi unit valid range 0..16383. Signed-off-by: Han Han --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 95808847..d315b431 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4823,7 +4823,7 @@ virDomainSCSIDriveAddressIsUsed(const virDomainDef *d= ef, case VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI: case VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_TRANSITIONAL: case VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_NON_TRANSITIONAL: - max =3D 16383; + max =3D 16384; break; case VIR_DOMAIN_CONTROLLER_MODEL_SCSI_IBMVSCSI: max =3D 31; --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri Mar 29 13:47:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575022723; cv=none; d=zohomail.com; s=zohoarc; b=Vhn60lAON63h2NofiTMfHJ/ze4aIV6vFhIWoKPAUz2N6S+C2ydxWkK0CnNRO7MIr6ddTxeV4YyqszzIikQjb31vdMytk0bAxruAIWAxjyalGdNIISENvGYwbP4MPj4MaqhQ/+IqPUSRwJCl5l5PC63002wqxmYN9wRHoKPpP+xY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575022723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kwogSluhYSdPlHCH08J6OXKeDn07BZxLNjKIuwSqsKw=; b=awMS8qS7B8dWx4taL3VwLuPQc+6EeA1oHFeYyTuG1XQazCzKwkuT66wIovaxenCKUdUMQ//2JyZMRUCLvnoF8k14wnlV6d0MZ7f9L64mo3RNI2HFiud495lJDqMoVjAI52K2GzmkRWljxZeYDvtrAP67UsRvp0vSnhbkve8sC6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575022723214409.7573398954005; Fri, 29 Nov 2019 02:18:43 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-G3t_1AFlMd6hxJubU_aQXg-1; Fri, 29 Nov 2019 05:18:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D8AF0800D54; Fri, 29 Nov 2019 10:18:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67225600F2; Fri, 29 Nov 2019 10:18:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1434718089CD; Fri, 29 Nov 2019 10:18:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xATAIV0W007761 for ; Fri, 29 Nov 2019 05:18:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8C84C5D727; Fri, 29 Nov 2019 10:18:31 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-12-169.pek2.redhat.com [10.72.12.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41AED5D6D2; Fri, 29 Nov 2019 10:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575022720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kwogSluhYSdPlHCH08J6OXKeDn07BZxLNjKIuwSqsKw=; b=W++So+Zkq75n7+MyRX3bcQNkB7cUESANZiPRXvsDPZJp1xpRV9nsT3OGYWaHruUxLqOyk9 469o1kkOUnWzEC7nLvfnJNOiLNsyJhhYSCcKuNdvZ6fzBKHM/LChDMpNut45Ygs+h2W6Fx SPGYtRn03bxjUnKAMwLnXLAhwRYdHAg= From: Han Han To: libvir-list@redhat.com Date: Fri, 29 Nov 2019 18:18:16 +0800 Message-Id: <20191129101816.130249-3-hhan@redhat.com> In-Reply-To: <20191129101816.130249-1-hhan@redhat.com> References: <20191129101816.130249-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH 2/2] rng: Extend the valid range of drive unit X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: G3t_1AFlMd6hxJubU_aQXg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In the last commit, we allowed unit number of virtio scsi disk to use range 0..16383. Extend the range in rng file to match that. Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index a83c9ae7..17efcfdc 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -6460,7 +6460,7 @@ - [0-9]{1,2} + [0-9]{1,5} --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list