[libvirt] [PATCH] virsh: limit completion of 'domhostname' to active domains

Pino Toscano posted 1 patch 4 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191120133524.12477-1-ptoscano@redhat.com
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] virsh: limit completion of 'domhostname' to active domains
Posted by Pino Toscano 4 years, 4 months ago
Getting the hostname of guest usually requires a in-guest agent, or
generally can be determined only on active domains.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
---
 tools/virsh-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index b248a15c16..6be9780836 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -11668,7 +11668,7 @@ static const vshCmdInfo info_domhostname[] = {
 };
 
 static const vshCmdOptDef opts_domhostname[] = {
-    VIRSH_COMMON_OPT_DOMAIN_FULL(0),
+    VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = NULL}
 };
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: limit completion of 'domhostname' to active domains
Posted by Daniel Henrique Barboza 4 years, 4 months ago

On 11/20/19 10:35 AM, Pino Toscano wrote:
> Getting the hostname of guest usually requires a in-guest agent, or
> generally can be determined only on active domains.
> 
> Signed-off-by: Pino Toscano <ptoscano@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: limit completion of 'domhostname' to active domains
Posted by Michal Privoznik 4 years, 4 months ago
On 11/20/19 2:35 PM, Pino Toscano wrote:
> Getting the hostname of guest usually requires a in-guest agent, or
> generally can be determined only on active domains.
> 
> Signed-off-by: Pino Toscano <ptoscano@redhat.com>
> ---
>   tools/virsh-domain.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list