From nobody Sun Feb 8 17:21:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1573753505; cv=none; d=zoho.com; s=zohoarc; b=jsRN1kUtrftBd7XMuuoZ1MzaNg0YUP6Py07yoCDKNAtXcL/yahn+ny1OqkB738yshjUIN/ki13dHn9go0ITL7I1s6c218CsyIMuQWBceVelurcVaFseIrtHQTse2pe6jq/1mzeSeuGj/xsiebrA6whSyumGLqTP+lAQ2y0ru2HI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573753505; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TJtgejCDgATnWTI2MeAZv+li5cmvc3dcDjeSSRlXGrk=; b=Ql47YETvWwCc47w7VkE18CvN5Nr/+N6d0loUJK5GQVN0XZCAom9bb1Hb8dYois+B4fuPpG6QY9y1IQUOLUmESFzasqjSCUOaIxN2DDEbL6TUkq81+XyxmaeZ8dnXPilhpF2HvnVULGd+/YcKx1bnlRrK5yPGVbzD79l0D1lfA1A= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1573753505347464.9884885474561; Thu, 14 Nov 2019 09:45:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-bWTf4xNGNya9I1UKfPxitg-1; Thu, 14 Nov 2019 12:45:02 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23DF61011298; Thu, 14 Nov 2019 17:44:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4CB188E6; Thu, 14 Nov 2019 17:44:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 337EC1832D6A; Thu, 14 Nov 2019 17:44:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAEHiqHp002239 for ; Thu, 14 Nov 2019 12:44:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0B6EF10AF9D2; Thu, 14 Nov 2019 17:44:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0671F10AF9D8 for ; Thu, 14 Nov 2019 17:44:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 143C1900A86 for ; Thu, 14 Nov 2019 17:44:50 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-cyizOT0RMCOELGrG4HVE8w-1; Thu, 14 Nov 2019 12:44:48 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xAEHZ9Ah029308 for ; Thu, 14 Nov 2019 12:44:47 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2w9985x1xd-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 Nov 2019 12:44:47 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Nov 2019 17:44:45 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 14 Nov 2019 17:44:43 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAEHig4R60686552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2019 17:44:42 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6786DAE04D; Thu, 14 Nov 2019 17:44:42 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 417A4AE053; Thu, 14 Nov 2019 17:44:42 +0000 (GMT) Received: from marcibm.boeblingen.de.ibm.com (unknown [9.152.224.228]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 14 Nov 2019 17:44:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573753504; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TJtgejCDgATnWTI2MeAZv+li5cmvc3dcDjeSSRlXGrk=; b=DWJ7dhjuxG4jGx0udC4XAVrsuxQJRER36EHU+qWCwPe+V+zFaYyVn9/BWSgKVrU2NpKRBZ nwcoGnEvbOwekE0wGCmnLcgPdCMUvtKZUtqHoS29BJpbdMAu0/0sS95mb9MfSnbGNnP89N QRknYsuNvleUg7Z+3v+yEqzZV6MSniA= From: Marc Hartmayer To: Date: Thu, 14 Nov 2019 18:44:24 +0100 In-Reply-To: <20191114174425.13583-1-mhartmay@linux.ibm.com> References: <20191114174425.13583-1-mhartmay@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19111417-0020-0000-0000-000003863845 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111417-0021-0000-0000-000021DC50B1 Message-Id: <20191114174425.13583-7-mhartmay@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-11-14_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=688 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911140152 X-MC-Unique: cyizOT0RMCOELGrG4HVE8w-1 X-MC-Unique: bWTf4xNGNya9I1UKfPxitg-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id xAEHiqHp002239 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Pavel Hrdina Subject: [libvirt] [PATCH v4 6/7] remote: shrink the critical sections X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" To free the structs and save the error, it is not necessary to hold @priv->= lock, therefore move these parts after the mutex unlock. Signed-off-by: Marc Hartmayer Reviewed-by: Cole Robinson --- src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++--------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 9dc2083d715a..6ece51c2889d 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -4293,10 +4293,10 @@ remoteDispatchConnectDomainEventRegister(virNetServ= erPtr server G_GNUC_UNUSED, rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -4342,9 +4342,9 @@ remoteDispatchConnectDomainEventDeregister(virNetServ= erPtr server G_GNUC_UNUSED, rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -4522,10 +4522,10 @@ remoteDispatchConnectDomainEventRegisterAny(virNetS= erverPtr server G_GNUC_UNUSED rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -4598,11 +4598,11 @@ remoteDispatchConnectDomainEventCallbackRegisterAny= (virNetServerPtr server G_GNU rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(dom); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -4657,9 +4657,9 @@ remoteDispatchConnectDomainEventDeregisterAny(virNetS= erverPtr server G_GNUC_UNUS rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -4702,9 +4702,9 @@ remoteDispatchConnectDomainEventCallbackDeregisterAny= (virNetServerPtr server G_G rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6081,11 +6081,11 @@ remoteDispatchConnectNetworkEventRegisterAny(virNet= ServerPtr server G_GNUC_UNUSE rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(net); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6128,9 +6128,9 @@ remoteDispatchConnectNetworkEventDeregisterAny(virNet= ServerPtr server G_GNUC_UNU rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6202,11 +6202,11 @@ remoteDispatchConnectStoragePoolEventRegisterAny(vi= rNetServerPtr server G_GNUC_U rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(pool); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6248,9 +6248,9 @@ remoteDispatchConnectStoragePoolEventDeregisterAny(vi= rNetServerPtr server G_GNUC rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6322,11 +6322,11 @@ remoteDispatchConnectNodeDeviceEventRegisterAny(vir= NetServerPtr server G_GNUC_UN rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(dev); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6368,9 +6368,9 @@ remoteDispatchConnectNodeDeviceEventDeregisterAny(vir= NetServerPtr server G_GNUC_ rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6442,11 +6442,11 @@ remoteDispatchConnectSecretEventRegisterAny(virNetS= erverPtr server G_GNUC_UNUSED rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(secret); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6488,9 +6488,9 @@ remoteDispatchConnectSecretEventDeregisterAny(virNetS= erverPtr server G_GNUC_UNUS rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6558,11 +6558,11 @@ qemuDispatchConnectDomainMonitorEventRegister(virNe= tServerPtr server G_GNUC_UNUS rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); virObjectUnref(dom); - virMutexUnlock(&priv->lock); return rv; } =20 @@ -6606,9 +6606,9 @@ qemuDispatchConnectDomainMonitorEventDeregister(virNe= tServerPtr server G_GNUC_UN rv =3D 0; =20 cleanup: + virMutexUnlock(&priv->lock); if (rv < 0) virNetMessageSaveError(rerr); - virMutexUnlock(&priv->lock); return rv; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list