From nobody Sat Feb 7 08:44:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572789268; cv=none; d=zoho.com; s=zohoarc; b=mX691x1mpCrHFU8ByRFKxlENVKPMl2vf60oCHSqz61LzH3qqkojuYqvzJSJdD8nloGB5B8vMEk62m3Vp8smmwCJvbrB5hn/pY7V6d1mGeew+C0IlxEH4BHrYwDiZ2nsM3G0LVYjeQZ+CrUYqzijkkjiJ9PxH7M+rEC8HGnZ8FY4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572789268; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DAPfkw9y9t6WSukk6gcSyEst/GnebKsguD71UFlo7yY=; b=Z+wkW+pV9gKl6z1qFNgIobhEQ+dD7KZkvfoH3gYR+oub9tr0+FJliXU/LKiQ5CMWlx7/vijbY6gIYqxg7cKsduuWrQTt5x8wQ0g2n/R9Eo/S9QR2bUzJiDqLmeYA7sAOgOxoomjyfSf/6ChqglOdCQH2Zhsj8lzDBeVkXjKtavU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1572789268677205.81257650311636; Sun, 3 Nov 2019 05:54:28 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-VPfQpCL9OEuOUoSkbQNnIw-1; Sun, 03 Nov 2019 08:54:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5DBD801E68; Sun, 3 Nov 2019 13:54:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9883B6085E; Sun, 3 Nov 2019 13:54:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3115A4A460; Sun, 3 Nov 2019 13:54:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xA3DrjnT005810 for ; Sun, 3 Nov 2019 08:53:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id DE2F360874; Sun, 3 Nov 2019 13:53:45 +0000 (UTC) Received: from unknown04D3B0C4CC7D.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9ECCF6085E for ; Sun, 3 Nov 2019 13:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572789267; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DAPfkw9y9t6WSukk6gcSyEst/GnebKsguD71UFlo7yY=; b=hyA+2Tf5M653CmddbX309rxAmwKnUKLrQxciP4b28LlF0+nlSi/vmIaKkcIcU+ve2my+Gk lYBcl1l1MZVOYmrFtotJ95GTzAxbLmbcVcXEV70WIV7+/vcfZ9iCY7sFDGtsOaZK88YYl5 b6FvL3IGbvZjrfqW7iHWD0NXgXH7oI4= From: John Ferlan To: libvir-list@redhat.com Date: Sun, 3 Nov 2019 08:53:37 -0500 Message-Id: <20191103135340.3505-6-jferlan@redhat.com> In-Reply-To: <20191103135340.3505-1-jferlan@redhat.com> References: <20191103135340.3505-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/8] tests: Remove _NULLABLE in virNetDevExists mock X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: VPfQpCL9OEuOUoSkbQNnIw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The @ifname is listed as an ATTRIBUTE_NONNULL(1) parameter, so checking for _NULLABLE causes a coverity build failure - remove that and if it's NULL for the test let's fail miserably. Signed-off-by: John Ferlan --- tests/qemuxml2argvmock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index 914d2bcf9f..8143de1618 100644 --- a/tests/qemuxml2argvmock.c +++ b/tests/qemuxml2argvmock.c @@ -169,7 +169,7 @@ virNetDevSetMAC(const char *ifname G_GNUC_UNUSED, int virNetDevExists(const char *ifname) { - return STREQ_NULLABLE(ifname, "mytap0"); + return STREQ(ifname, "mytap0"); } =20 =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list