From nobody Tue Nov 26 16:40:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571794092; cv=none; d=zoho.com; s=zohoarc; b=Mx11VCRmMpYHdjt1PGL77y42bpa9rrvM6NJ18sn68rpxoQWFgxAFudF1sdiGy5DsTYl1EdrgdPhvuXHR4Gj015vymfk97/+3Wo+GGaVez7XpANhOER14wu9E464umYSNz+wZ1kNJfKmcdjyLGBPfmAJhpt7fukcgDwTo9lXUVE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571794092; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f2fpOxgZejewNT+X0RhSrtxOLoHkrRhWcesM5dc905s=; b=cQGsTKyeLTdOm/+HOxVzK17opkKKu1Ya0A1BFQsn1N7D5/DIBWxAZ5Au3MAgZk6/smxNkrdJDaqMdwiaKhYcyCkm2iw2jNItqm9wp8B10rXAA1DRmvQIojEl9tqpfkXVrKf6xy7ZN8FF1yYvikuHUy6c8Cz9m6XB2hwxJGYIYbc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1571794092123266.1692873774035; Tue, 22 Oct 2019 18:28:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-8cQNWz1aPlytpXtV6jWuOg-1; Tue, 22 Oct 2019 21:26:16 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 222A0107AD37; Wed, 23 Oct 2019 01:26:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1A6E4128; Wed, 23 Oct 2019 01:26:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 86BDE4E58B; Wed, 23 Oct 2019 01:26:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9N1OTPu030895 for ; Tue, 22 Oct 2019 21:24:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id CED345D6C8; Wed, 23 Oct 2019 01:24:29 +0000 (UTC) Received: from vhost2.laine.org (ovpn-117-114.phx2.redhat.com [10.3.117.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CAAB5D6B2 for ; Wed, 23 Oct 2019 01:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571794091; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f2fpOxgZejewNT+X0RhSrtxOLoHkrRhWcesM5dc905s=; b=ETjN1A3Nk6qqAvEcyqfgE1Q6WkpzZ3pJmqZtbXFMIKEqVST6tOvt5vxOnTBD1HAaqYcIkZ ueOQgd2BlvbYWEHFeX0OJPGgDagJktxb3m4pKqdoIHcm9dYuaKSUo2axWSKqfcqwWn5o6Y M9ErRUtzfSvYdPICBx4n72Hbi/uVbug= From: Laine Stump To: libvir-list@redhat.com Date: Tue, 22 Oct 2019 21:24:18 -0400 Message-Id: <20191023012420.21128-6-laine@redhat.com> In-Reply-To: <20191023012420.21128-1-laine@redhat.com> References: <20191023012420.21128-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/7] conf: change args/return values of remaining virDomainNetGetActual*() to const X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 8cQNWz1aPlytpXtV6jWuOg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" These all just return a scalar value, so there's no daisy-chained fallout from changing them, and they can easily be combined in a single patch. Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 10 +++++----- src/conf/domain_conf.h | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index af8c0af7c7..01a1a74946 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -29606,7 +29606,7 @@ virDomainNetGetActualType(const virDomainNetDef *if= ace) } =20 const char * -virDomainNetGetActualBridgeName(virDomainNetDefPtr iface) +virDomainNetGetActualBridgeName(const virDomainNetDef *iface) { if (iface->type =3D=3D VIR_DOMAIN_NET_TYPE_BRIDGE) return iface->data.bridge.brname; @@ -29619,7 +29619,7 @@ virDomainNetGetActualBridgeName(virDomainNetDefPtr = iface) } =20 int -virDomainNetGetActualBridgeMACTableManager(virDomainNetDefPtr iface) +virDomainNetGetActualBridgeMACTableManager(const virDomainNetDef *iface) { if (iface->type =3D=3D VIR_DOMAIN_NET_TYPE_NETWORK && iface->data.network.actual && @@ -29630,7 +29630,7 @@ virDomainNetGetActualBridgeMACTableManager(virDomai= nNetDefPtr iface) } =20 const char * -virDomainNetGetActualDirectDev(virDomainNetDefPtr iface) +virDomainNetGetActualDirectDev(const virDomainNetDef *iface) { if (iface->type =3D=3D VIR_DOMAIN_NET_TYPE_DIRECT) return iface->data.direct.linkdev; @@ -29642,7 +29642,7 @@ virDomainNetGetActualDirectDev(virDomainNetDefPtr i= face) } =20 int -virDomainNetGetActualDirectMode(virDomainNetDefPtr iface) +virDomainNetGetActualDirectMode(const virDomainNetDef *iface) { if (iface->type =3D=3D VIR_DOMAIN_NET_TYPE_DIRECT) return iface->data.direct.mode; @@ -29729,7 +29729,7 @@ virDomainNetGetActualVlan(const virDomainNetDef *if= ace) =20 =20 bool -virDomainNetGetActualTrustGuestRxFilters(virDomainNetDefPtr iface) +virDomainNetGetActualTrustGuestRxFilters(const virDomainNetDef *iface) { if (iface->type =3D=3D VIR_DOMAIN_NET_TYPE_NETWORK && iface->data.network.actual) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index b08202b092..4a7010e8a5 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3204,17 +3204,17 @@ int virDomainGraphicsListenAppendSocket(virDomainGr= aphicsDefPtr def, ATTRIBUTE_NONNULL(1); =20 virDomainNetType virDomainNetGetActualType(const virDomainNetDef *iface); -const char *virDomainNetGetActualBridgeName(virDomainNetDefPtr iface); -int virDomainNetGetActualBridgeMACTableManager(virDomainNetDefPtr iface); -const char *virDomainNetGetActualDirectDev(virDomainNetDefPtr iface); -int virDomainNetGetActualDirectMode(virDomainNetDefPtr iface); +const char *virDomainNetGetActualBridgeName(const virDomainNetDef *iface); +int virDomainNetGetActualBridgeMACTableManager(const virDomainNetDef *ifac= e); +const char *virDomainNetGetActualDirectDev(const virDomainNetDef *iface); +int virDomainNetGetActualDirectMode(const virDomainNetDef *iface); virDomainHostdevDefPtr virDomainNetGetActualHostdev(virDomainNetDefPtr ifa= ce); const virNetDevVPortProfile * virDomainNetGetActualVirtPortProfile(const virDomainNetDef *iface); const virNetDevBandwidth * virDomainNetGetActualBandwidth(const virDomainNetDef *iface); const virNetDevVlan *virDomainNetGetActualVlan(const virDomainNetDef *ifac= e); -bool virDomainNetGetActualTrustGuestRxFilters(virDomainNetDefPtr iface); +bool virDomainNetGetActualTrustGuestRxFilters(const virDomainNetDef *iface= ); const char *virDomainNetGetModelString(const virDomainNetDef *net); int virDomainNetSetModelString(virDomainNetDefPtr et, const char *model); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list