From nobody Sun Feb 8 18:49:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1571737043; cv=none; d=zoho.com; s=zohoarc; b=S19nRlQ8+SCZ0aM6WxEgoPSXXJnO9jNVnqrdmDXLrEqXv8wOV8276vBiMflFepQ7BHTmsK5sofKnVN4/8tB5FtGyCRqtFRziUgbrYyQk+9/1wKFj8qQrebYoljtxMDlYgkwBKVVQzmIYAs9qfIsLmitAuNYAjuOmBU1HTd6nslg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571737043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3IuM5I6IbaTGE9nbJDqLjk+Jx9zQbVPywNxZshmJU+E=; b=QGa9y2GJBVxZVB0/A5g1B8woeFT8pXZi29tVLUkxpkxd2ZTgD1H1Grmqs8FY7KavNOAIOSK4Do+EeGFht3CwzZpFzjVJoSYyBcN0oDQEOCiLpaOX+jYdPY5c55aP+rLaUF1AA0qPMBIsDFF8iApOeCDLxXoGp6/f7F0/brXPYas= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1571737043149153.8917884489847; Tue, 22 Oct 2019 02:37:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-mYAAI3R_OQqhwenq7ytrmA-1; Tue, 22 Oct 2019 05:37:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0481800D53; Tue, 22 Oct 2019 09:37:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A90B35D6B0; Tue, 22 Oct 2019 09:37:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 63DE718198EC; Tue, 22 Oct 2019 09:37:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9LIJjl9000633 for ; Mon, 21 Oct 2019 14:19:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 45A58196AE; Mon, 21 Oct 2019 18:19:45 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4024D8088 for ; Mon, 21 Oct 2019 18:19:34 +0000 (UTC) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C93E75117D for ; Mon, 21 Oct 2019 18:19:33 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id u22so13544802qkk.11 for ; Mon, 21 Oct 2019 11:19:33 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:7979:d16f:4e5e:8e8d:1141]) by smtp.gmail.com with ESMTPSA id d205sm9248741qke.96.2019.10.21.11.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571737042; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3IuM5I6IbaTGE9nbJDqLjk+Jx9zQbVPywNxZshmJU+E=; b=VnHRWVJYY+srwVMaAf3qw7bfoOEyv2NKmYpKgbHdO/G87L5u74sJ6C3RH6IvkuJp9NE6VZ Ivtyrq07iRtGBTMCN6YVhA/bHKDb7IDoIKqk0UuzcmKcZAMlOFQ5Of/5VSot8nl/+7WjmL cMpEJ1hFAbBCTmJadmv7nu9AR1rvXLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nAiYKD6bbmo4S/7ZYfK6RLqPiLc7NQOaXTaxcjPq4qM=; b=K6hTYUzHIzXU0r8JQGkH8xjBKPaiuBCSCn9jEjpWaj3PFRES1RDkEqYDV5cVu7SGWd M8LyTjA9TGlsHqRODHuLo4k+Tg17xs3C3qKCXJYV/VwR98UPYIOXOm5qQ1ZdfrDuE2ln 3gosbXvl+l02IJpN1Nsx21W/PhfBy6RMXPRj+alO3Qn0jVroB+AXzhPhVzTl/6a7Skff Ep0F94fUgcIYWogXh7pMFhjjsL9ZbNcSTM1QmiiCAGyuYDfP/RBls7MscIxUju1uHd7y 4ntSK/l/Hg4/Alqt3LXm9vPamoJAl4XF0DZFeP9IBxumZxkJfFBURuXmIS+1l0nQOKaR +tDA== X-Gm-Message-State: APjAAAX7e56wM9JHUM0RTFd8ckDCrkycK1WNPb3YrSCdikEb5a4nkrrg nAxbPFvq8nk2MbfffIfOkHwLvjB1ZJY= X-Google-Smtp-Source: APXvYqyH4pFN6VXa1ZdTXrAeqZzN1wy+mlOGd07yktjXfXMlNfVXBPr3R4SA9XrevfHOPneLD5+IaQ== X-Received: by 2002:a37:4ed1:: with SMTP id c200mr21636093qkb.304.1571681972961; Mon, 21 Oct 2019 11:19:32 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Date: Mon, 21 Oct 2019 15:18:57 -0300 Message-Id: <20191021181911.14986-8-danielhb413@gmail.com> In-Reply-To: <20191021181911.14986-1-danielhb413@gmail.com> References: <20191021181911.14986-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 Oct 2019 18:19:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 Oct 2019 18:19:33 +0000 (UTC) for IP:'209.85.222.172' DOMAIN:'mail-qk1-f172.google.com' HELO:'mail-qk1-f172.google.com' FROM:'danielhb413@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.15 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.222.172 mail-qk1-f172.google.com 209.85.222.172 mail-qk1-f172.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza Subject: [libvirt] [PATCH v1 07/21] secret_driver.c: remove unneeded cleanup label X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: mYAAI3R_OQqhwenq7ytrmA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Daniel Henrique Barboza Reviewed-by: J=C3=A1n Tomko --- src/secret/secret_driver.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 6d2844f3b7..2989a3acff 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -614,20 +614,15 @@ static int secretConnectSecretEventDeregisterAny(virConnectPtr conn, int callbackID) { - int ret =3D -1; - if (virConnectSecretEventDeregisterAnyEnsureACL(conn) < 0) - goto cleanup; + return -1; =20 if (virObjectEventStateDeregisterID(conn, driver->secretEventState, callbackID, true) < 0) - goto cleanup; - - ret =3D 0; + return -1; =20 - cleanup: - return ret; + return 0; } =20 =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list