From nobody Sat Feb 7 18:46:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1571423867; cv=none; d=zoho.com; s=zohoarc; b=GNStMFrqzhCerrqIbJX3rVP0a510no6/eDy16Ip7RuEBEhMP/VuErUnqRjIinJv8BW0l/WZsj8Ub7tMdgGRqQ71mhLezOjecqrn+C1nmJ7KbJCCf2MXFfjN3ubMBoF3LJ5zglcDuTZnDhfHELFcjqyurhUFkxh24FkTFzTLzv0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571423867; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D1pUclGuzVQkK4ASpRTG2fSZ92Zw5IyLBzMZHKS6EA0=; b=JJ30TcCbaKDZtaOXlR6t/vT3oyrSZsUhdnYE7fnUq2FkhrvjADfbK/YCVexIl8ckuukJTRq+LFbt/nUepadCELu07XZsjje/17VaBOATKTfwCv3R6KifFL7xLbE0Baxqaeubdgdpru+2ZIvDOKk7xLRDrAkV8Gc9LpuwUPNqzpk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571423867704132.27170747088064; Fri, 18 Oct 2019 11:37:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBB3A5AFF8; Fri, 18 Oct 2019 18:37:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9280F10027A8; Fri, 18 Oct 2019 18:37:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 490644EE69; Fri, 18 Oct 2019 18:37:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9IIawxP013261 for ; Fri, 18 Oct 2019 14:36:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7AFCC5C21E; Fri, 18 Oct 2019 18:36:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx25.extmail.prod.ext.phx2.redhat.com [10.5.110.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCB0A5C1B5; Fri, 18 Oct 2019 18:36:55 +0000 (UTC) Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32CCA10C0946; Fri, 18 Oct 2019 18:36:55 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id w2so6228630qkf.2; Fri, 18 Oct 2019 11:36:55 -0700 (PDT) Received: from localhost.localdomain ([187.119.225.130]) by smtp.gmail.com with ESMTPSA id y26sm3883005qtk.22.2019.10.18.11.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 11:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yXtaYCSnMa/mtG+84gRXJtmrASvD1O+JISEPZz9EgGU=; b=m6QD4vNISRoAOlrNyXtf5UF2AMRLquBVUJjXSBx/8twHGUcPuB+lS4bTvvvcEla3VA nvFzPc1dcTG7wO5OcowGGRfyD+klrDcQikibk3/WZ/SCwNn/+RcvCRXtunN8NOuak52J yk3GV94YGeBopdGocRcyaOvjXlT/pW1mQ6GRZZeb+Ua9XOWsEal1xv4azTqerLSD4c58 jJSSyh+ujYHjtCIworNRLq5IFRnjmzepqXzM2jmYdJUjEfr4Zhhw6MJF4I7A686pAi+f JNIG+8CH4p+ckuz1f8xEp1AA5YWj1scPWyrKeecCZLkD01sgg9KfyE2YIRlWyiJVZriM tOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yXtaYCSnMa/mtG+84gRXJtmrASvD1O+JISEPZz9EgGU=; b=JYJTWLzZ+MXsKz6ILY5MNU4SDwH768tXNE6oX1pOfSpKZo8mdAzQTHS0xTs8xAA0Bn kCR5kQPfYfiARrT53rAyAdguwES4IVTUPy01n+0zOjoloE8TZ30Ox2auLEBOheiO99f/ 5CggyBHxAqctNWZA2Rp3ntHxgYayWSS1XKpUoB+GCl/ipbuJWS/RR9y0HFXFtC1U0MPy 9MA5ALZrRnZT3hXm8urddJXVnuEX1VVHW4wc3wlAmAQBbQ0GLE4J3lfDAw7RLnJonAEP a9d4cyUGtYPRV8THxy2WPlH8wIFVIJ2n6qfdYKb990h3xtRaLDw4xQJLXM0WGijQSgd4 WLPA== X-Gm-Message-State: APjAAAUuTS7VqCTD/bGNLael+/hyOow7H2pieXaE0ukZ8MF/Tmc/YPHT 17TnyBZt/AtKBvUZGWh7kXgyOx8lsPo= X-Google-Smtp-Source: APXvYqyQXkVs8dCQ06Xk/ubnSvv8912XTFyPfeTFoO+y4jcpksntMTuLvJVel6XXY5xFzvAucQRTTw== X-Received: by 2002:a05:620a:1225:: with SMTP id v5mr10503412qkj.231.1571423814315; Fri, 18 Oct 2019 11:36:54 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Date: Fri, 18 Oct 2019 15:36:34 -0300 Message-Id: <20191018183634.15338-4-danielhb413@gmail.com> In-Reply-To: <20191018183634.15338-1-danielhb413@gmail.com> References: <20191018183634.15338-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Fri, 18 Oct 2019 18:36:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Fri, 18 Oct 2019 18:36:55 +0000 (UTC) for IP:'209.85.222.196' DOMAIN:'mail-qk1-f196.google.com' HELO:'mail-qk1-f196.google.com' FROM:'danielhb413@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.15 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.222.196 mail-qk1-f196.google.com 209.85.222.196 mail-qk1-f196.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.66 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , crobinso@redhat.com Subject: [libvirt] [PATCH v3 3/3] qemu_hotplug.c: user-friendlier setvcpus timeout error message X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 18 Oct 2019 18:37:46 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The current 'setvcpus' timeout message requires a deeper understanding of QEMU/Libvirt internals to proper react to it. One who knows how setvcpus unplug work (it is an asynchronous operation between QEMU and guest that Libvirt can't know for sure if it failed, unless an explicit error happened during the timeout period) will read the message and not assume a failed operation. But the regular user, most often than not, will read it and believe that the unplug operation failed. This leads to situations where the user isn't exactly relieved when accessing the guest and seeing that the unplug operation worked. Instead, the user feel mislead by the timeout message setvcpus threw. Changing the timeout message to let the user know that the unplug status is not known, and manual inspection in the guest is required, is not a silver bullet. But it gives a more realistic expectation of what happened, as best as we can tell from Libvirt side anyways. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 32100b140e..72015e02e2 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -6007,8 +6007,9 @@ qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver, =20 if ((rc =3D qemuDomainWaitForDeviceRemoval(vm)) <=3D 0) { if (rc =3D=3D 0) - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("vcpu unplug request timed out")); + virReportError(VIR_ERR_OPERATION_TIMEOUT, "%s", + _("vcpu unplug request timed out. Unplug result= " + "must be manually inspected in the domain")); =20 goto cleanup; } --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list