[libvirt] [PATCH] gitdm/companies: add 'ibm' file

Daniel Henrique Barboza posted 1 patch 4 years, 5 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191018144037.6300-1-danielhb413@gmail.com
docs/gitdm/companies/ibm    | 6 ++++++
docs/gitdm/companies/others | 1 -
2 files changed, 6 insertions(+), 1 deletion(-)
create mode 100644 docs/gitdm/companies/ibm
[libvirt] [PATCH] gitdm/companies: add 'ibm' file
Posted by Daniel Henrique Barboza 4 years, 5 months ago
Some people from IBM does not use 'ibm.com' domain emails.

CC: jcfaracco@gmail.com
Suggested-by: Leonardo Augusto Guimarães Garcia <lagarcia@br.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

Julio,

I didn't add you in this list because I am not sure about the
nature of your contributions to Libvirt. Let me know if you want
your email to be added here as well.


 docs/gitdm/companies/ibm    | 6 ++++++
 docs/gitdm/companies/others | 1 -
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 docs/gitdm/companies/ibm

diff --git a/docs/gitdm/companies/ibm b/docs/gitdm/companies/ibm
new file mode 100644
index 0000000000..ce0315df66
--- /dev/null
+++ b/docs/gitdm/companies/ibm
@@ -0,0 +1,6 @@
+ibm.com
+
+# These IBM employees used their personal email address when contributing
+# to libvirt and we don't have the corresponding @ibm.com address on file.
+
+danielhb413@gmail.com
diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others
index db2c0061bd..99dc1ab31e 100644
--- a/docs/gitdm/companies/others
+++ b/docs/gitdm/companies/others
@@ -35,7 +35,6 @@ hitachi.com Hitachi
 hoster-ok.com hoster-ok.com
 hp.com HP
 huawei.com Huawei
-ibm.com IBM
 inktank.com Inktank Storage
 intel.com Intel
 intellilink.co.jp NTT DATA INTELLILINK
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] gitdm/companies: add 'ibm' file
Posted by Andrea Bolognani 4 years, 5 months ago
On Fri, 2019-10-18 at 11:40 -0300, Daniel Henrique Barboza wrote:
> Julio,
> 
> I didn't add you in this list because I am not sure about the
> nature of your contributions to Libvirt. Let me know if you want
> your email to be added here as well.

It'd be even better if he posted the patch himself.

>  docs/gitdm/companies/ibm    | 6 ++++++
>  docs/gitdm/companies/others | 1 -
>  2 files changed, 6 insertions(+), 1 deletion(-)
>  create mode 100644 docs/gitdm/companies/ibm

You also need

diff --git a/gitdm.config b/gitdm.config
index 3ff3f439d2..396d16758f 100644
--- a/gitdm.config
+++ b/gitdm.config
@@ -23,6 +23,7 @@ EmailMap docs/gitdm/companies/others
 GroupMap docs/gitdm/companies/canonical Canonical
 GroupMap docs/gitdm/companies/datto Datto
 GroupMap docs/gitdm/companies/dreamhost DreamHost
+GroupMap docs/gitdm/companies/ibm IBM
 GroupMap docs/gitdm/companies/nec NEC
 GroupMap docs/gitdm/companies/redhat Red Hat
 GroupMap docs/gitdm/companies/suse SUSE

or gitdm will not know about the new file you've just introduced.
Please make sure you always test your changes before posting!


I've squashed the above hunk in, added my

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed your patch.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list