From nobody Tue Apr 30 07:15:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1571368571; cv=none; d=zoho.com; s=zohoarc; b=ZPHdIXgJuFdw0K9eU8Nz3s55dhmy+ICrhKpu8JHPS7e0QLtD2bt/1CeaJX2zLFzF/8ykIywbglgIsHlw7CxE6qcKZZw7zipUKxBl+B2zelXllyRG1aISdiZSVMIczKTamwhKr9aemM4TUMEHagRWzm3dwSuUuLW6ufdjKbMoWLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571368571; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=U6/a6lK8wtf+bCCtFU3CUEn9qR1Mx7l2UDrN4UqCfEw=; b=gi0c+KmDvM9Oj4pWzRD9mmtQ1XDJyuK6FkALs/s/agxiuVp3Gp5GcJERtjL20m5Y87Y+jP4L0K+kFVznlOiOhKh6lfkxsFx9k9LhpOFVCwASvSBMfo1J3gznR823byyXSKYxk0u9JatUqnYp3ew2YrILfVhPtsk86F+JTj2JAX4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571368571374147.89438175997918; Thu, 17 Oct 2019 20:16:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 671853078468; Fri, 18 Oct 2019 03:16:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0861600C8; Fri, 18 Oct 2019 03:16:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6BE2D4E58A; Fri, 18 Oct 2019 03:15:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9I3FtUJ031506 for ; Thu, 17 Oct 2019 23:15:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id D654E600CC; Fri, 18 Oct 2019 03:15:55 +0000 (UTC) Received: from mx1.redhat.com (ext-mx24.extmail.prod.ext.phx2.redhat.com [10.5.110.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 755C4600C4; Fri, 18 Oct 2019 03:15:53 +0000 (UTC) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4126410CC1E4; Fri, 18 Oct 2019 03:15:52 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id t20so7000669qtr.10; Thu, 17 Oct 2019 20:15:52 -0700 (PDT) Received: from localhost.localdomain ([2804:431:c7cb:cd05:49f2:b549:7306:f7f3]) by smtp.gmail.com with ESMTPSA id h29sm2630218qtb.46.2019.10.17.20.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 20:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wEUoD1Asfh6s1OyO9aLzXUWVXOuStF1mMPE648sGPWU=; b=NpdE98qBq4U5H2slMA/PQSRcF1ldpxKmxUP5AOG/gJREQWlT//hh6saouBUycCOkfY VMlAu7kx7h5CzW9QiQGfyGsx+J0mTXVch/yvAgDVqkdJZQ1EPO/0aMCXAYPJ6zQ01Yin zBJEtc444IvM1CHsgKtliLsAjZ23eq0hJgEQ/qHPaHYDhn32ByQ45GeSSg5YLbCcBMmr SuXOV1yRDpjFQdXsWLaze3tobJllawwPetDdzKn/UD9wPe4A9RFDRmRYJyPibDNwrCuN 2/Sa5llgaQZfd6G4jkyJSaElxNXHiWX5h8Hy4Kc+UW71h1BcxQd0rTXH6WxUtjNdet35 LYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wEUoD1Asfh6s1OyO9aLzXUWVXOuStF1mMPE648sGPWU=; b=StUH9cyWOWU7i2dxo2l3V39nSXYuvZPoJ2LeCya8Mbs3quzDndELBKQo/02UouhBi0 64YhCosV9O/H/819nOu95tuVU1ZKgIihSreEROvF2RdZJnwNTXDaod8+ZtULymU3crNf dDt8wBQTAob+MExVJh+VtyY6UdfDMS69jIEDcXlA7BxB5+Www2OcCmIQtIO0BgLrMGh/ tqFwXThQjoborEu07cK1x70uGWzSTKlofiBZ60BJ8KX6DeDIDCtCu08Bo3uRgv94kfay Tp/NnMJfAg2PBwLk4KiIRKThHX2uQ/nUKHkqF5QgwwB2RT6nwOKk1c4llhqCXtDJKr2G 9RSQ== X-Gm-Message-State: APjAAAXXRvMPZxUqpnP6imgZOB8cQChBU8MiiUxvE3RRtLR34XQQQamT zjJ0JuBfgsjIJt0eSDGdNy/h00ce X-Google-Smtp-Source: APXvYqwNwbUJVbREEyhN3453DzqKAvcMB4LRCxw5y2hk8PKoT7r78dGuj7RLx7L+GjI4xU9exdWF3g== X-Received: by 2002:ac8:2c23:: with SMTP id d32mr7492012qta.313.1571368550892; Thu, 17 Oct 2019 20:15:50 -0700 (PDT) From: jcfaracco@gmail.com To: libvir-list@redhat.com Date: Fri, 18 Oct 2019 00:15:45 -0300 Message-Id: <20191018031545.8065-1-jcfaracco@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Fri, 18 Oct 2019 03:15:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Fri, 18 Oct 2019 03:15:52 +0000 (UTC) for IP:'209.85.160.196' DOMAIN:'mail-qt1-f196.google.com' HELO:'mail-qt1-f196.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.097 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS) 209.85.160.196 mail-qt1-f196.google.com 209.85.160.196 mail-qt1-f196.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.65 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Julio Faracco Subject: [libvirt] [PATCH] conf: Fix memory leak caused by missing VIR_FREE for video resolution. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 18 Oct 2019 03:16:09 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Julio Faracco Commit 72862797 introduced resolution settings for QEMU video drivers. It includes a new structure inside video definition. So, the code needs to clear pointer allocation for that structure into clear function virDomainVideoDefClear(). This commit adds this missing VIR_FREE(). Signed-off-by: Julio Faracco Reviewed-by: Jonathon Jongsma --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 88e93f6fb8..696a01043e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2850,6 +2850,7 @@ virDomainVideoDefClear(virDomainVideoDefPtr def) if (def->accel) VIR_FREE(def->accel->rendernode); VIR_FREE(def->accel); + VIR_FREE(def->res); VIR_FREE(def->virtio); if (def->driver) VIR_FREE(def->driver->vhost_user_binary); --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list