From nobody Sun Feb 8 10:16:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571161061; cv=none; d=zoho.com; s=zohoarc; b=cSlbFs3xB3JXX5sAeKd7yJcuNJ/Pklabmk+QHhYExeTCd600SkeKIRzetyZo/Egrdg0zcVYtuRaNrb6wlBJsriLAlJUDjdd1XU996A5vgMXnZSezRJCKSg4dEsMsOdP//ZyGL5f86KLghcxJqNpuHrfaDNPs39vh1yLKXZIAJAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571161061; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/aclG/HA1qQEAcILjTmHxL2PPFHeNaAh/eKSD7jaDpk=; b=V4+KeCgSEjBQSqwOKb9XuqsAVJSRKfKwNQP0Xd/h92O3FAv4Twd65gFcBHJNmR4UWgUCr2kfH5akwDo7MXKRTyjqi8FoGMopCwYP0dJ2ynmqOzVMkYWhPfZWNgtkdtqpqKgYs54fUtFNd1LutI80Oo+XL957ywQmLCEbzGDeQ7I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571161061309552.5004974376319; Tue, 15 Oct 2019 10:37:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F5E6302246D; Tue, 15 Oct 2019 17:37:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A836A1001DF0; Tue, 15 Oct 2019 17:37:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A2184EDA7; Tue, 15 Oct 2019 17:37:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9FHbZv3001206 for ; Tue, 15 Oct 2019 13:37:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id D6F565D9E2; Tue, 15 Oct 2019 17:37:35 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-116-31.phx2.redhat.com [10.3.116.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id 967385D9CD for ; Tue, 15 Oct 2019 17:37:35 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 15 Oct 2019 13:37:19 -0400 Message-Id: <20191015173728.1633-2-jferlan@redhat.com> In-Reply-To: <20191015173728.1633-1-jferlan@redhat.com> References: <20191015173728.1633-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 01/10] conf: Use consistent error preservation and restoration calls X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 15 Oct 2019 17:37:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Provide some consistency over error message variable name and usage when saving error messages across possible other errors or possibility of resetting of the last error. Instead of virSaveLastError paired up with virSetError and virFreeError, we should use the newer virErrorPreserveLast and virRestoreError. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 10d6bf0eea..188ea80c3d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -23624,17 +23624,14 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPt= r src, return true; =20 error: - err =3D virSaveLastError(); + virErrorPreserveLast(&err); =20 strSrc =3D virDomainDefFormat(src, NULL, 0); strDst =3D virDomainDefFormat(dst, NULL, 0); VIR_DEBUG("XMLs that failed stability check were: src=3D\"%s\", dst=3D= \"%s\"", NULLSTR(strSrc), NULLSTR(strDst)); =20 - if (err) { - virSetError(err); - virFreeError(err); - } + virErrorRestore(&err); return false; } =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list