From nobody Sat Feb 7 09:36:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570625978; cv=none; d=zoho.com; s=zohoarc; b=NWgGW/OHslTK4HU4irwGpAL0wI628hm8AZfDPNjMRQRbcZYnD0bj8tnpNzIJLI136ZCgW5X4lt2FxM4lOVxrEEPcbvhXrxVJce+6SCNh/JhyNE9GjUhy81KqOaPB36eNu2znhMHMYHNJXFDn/VdyuuHbtifNVW7IdpSH1HCGkH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570625978; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u+lDvx4dOT841OhHbDoLBtIxl5/fg8fnfEHXgHN/iI4=; b=jrWTB0fau14FMXcE3Nzi7fJ0N+YprUp4M6umhHqfb+GjdKG7QqQ/a/Zar4jPM0eoVa9pgouwoMCjawlq2uV6GLTVN7kJvWAY+OMHbk5xR3gCR60bQfBWCHj7fdhuCUPEC7A8o68K6hQ5RaWQKoOdU4INoeLDX99V4l1sIMJnI0U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570625978535346.74121563159053; Wed, 9 Oct 2019 05:59:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE96E9B282; Wed, 9 Oct 2019 12:59:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97EDF60BF4; Wed, 9 Oct 2019 12:59:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 51FB018037CD; Wed, 9 Oct 2019 12:59:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x99CxYQI003139 for ; Wed, 9 Oct 2019 08:59:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id D89B35DA8D; Wed, 9 Oct 2019 12:59:34 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28EA65DA8C; Wed, 9 Oct 2019 12:59:23 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 9 Oct 2019 13:58:44 +0100 Message-Id: <20191009125844.18202-11-berrange@redhat.com> In-Reply-To: <20191009125844.18202-1-berrange@redhat.com> References: <20191009125844.18202-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 10/10] build: comment on why we're not adopting certain flake8 rules X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 09 Oct 2019 12:59:37 +0000 (UTC) Simplify the list of ignored warnings now that we only have two left, and document why we're not honouring them. Signed-off-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index ebacb8312e..812c8baae8 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -878,13 +878,17 @@ sc_require_enum_last_marker: { echo '$(ME): enum impl needs _LAST marker on second line' 1>&2; \ exit 1; } || : =20 -# Validate many python style rules -FLAKE8_LINE_LENGTH =3D E501 -FLAKE8_WARNINGS =3D W504 - -FLAKE8_IGNORE =3D $(FLAKE8_LINE_LENGTH),$\ - $(FLAKE8_WARNINGS) \ - $(NULL) +# We're intentionally ignoring a few warnings +# +# E501: Force breaking lines at < 80 characters results in +# some really unnatural code formatting which harms +# readability. +# +# W504: Knuth code style requires the operators "or" and "and" etc +# to be at the start of line in a multi-line conditional. +# This the opposite to what is normal libvirt practice. +# +FLAKE8_IGNORE =3D E501,W504 =20 sc_flake8: @if [ -n "$(FLAKE8)" ]; then \ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list