From nobody Fri Apr 26 23:06:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570547622; cv=none; d=zoho.com; s=zohoarc; b=IeKQls4Gjum8/g7HjBwLj0tp0wmIoBDN/T/+rJ7CfwIpSuMRPoeBb3Lp5N3llD2qQCIxuML1cT8DPEeSGEKMJmqYaYcuTBVJ4+ceRVu9d6olijng0w5Tg0RmfLCC9EwnCwXFSO1XcuIJ2b1HWFV4sDPeN4wd/rb3WnUB/E8Gixo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570547622; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=hsB3THd7OdNTfGNYWzwuDzSwgIgLePd/GSC1OBUsojc=; b=G4O1ccAUrTPzSzYJTkXW32uKMdGnpOqZxeVBYl61dA1ZH1kkGQcr5kEWjbKQVZwg9peg3tGDP/E0j6UsFNOO16+wlnj1cGZsJeYbOMz6tBWzuDlRDr3djP8FUSoHV5SWpd6Ib+me08elTmkBakDKaQD3ljnJj5vkfYY+rkcejRc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570547622192617.9437845732893; Tue, 8 Oct 2019 08:13:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FCD37BDAC; Tue, 8 Oct 2019 15:13:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65E9A60BE2; Tue, 8 Oct 2019 15:13:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 24E9C18089DC; Tue, 8 Oct 2019 15:13:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x98FDa8Y003919 for ; Tue, 8 Oct 2019 11:13:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 27441196AE; Tue, 8 Oct 2019 15:13:36 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-66.ams2.redhat.com [10.36.112.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F2C519C69; Tue, 8 Oct 2019 15:13:32 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Tue, 8 Oct 2019 15:39:22 +0100 Message-Id: <20191008143922.13378-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] build: stop clang complaining about redefined typedefs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 08 Oct 2019 15:13:39 +0000 (UTC) Clang's gnu99 mode is not quite the same as GCC's. It will complain about redefined typedefs being a C11 feature, while GCC does not complain and allows them in GNU99. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Fid=C3=AAncio --- Technically a build breaker fix, but given my track record of breaking the build today/yestday, lets have a reviewer approve :-) m4/virt-compile-warnings.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 26f231f97e..4f9eee121c 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -125,6 +125,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # We do "bad" function casts all the time for event callbacks wantwarn=3D"$wantwarn -Wno-cast-function-type" =20 + # CLang incorrectly complains about dup typedefs win gnu99 mode + # so use this CLang-specific arg to keep it quiet + wantwarn=3D"$wantwarn -Wno-typedef-redefinition" + # GNULIB expects this to be part of -Wc++-compat, but we turn # that one off, so we need to manually enable this again wantwarn=3D"$wantwarn -Wjump-misses-init" --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list