From nobody Sat Feb 7 18:29:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570542400; cv=none; d=zoho.com; s=zohoarc; b=cyj/s/M4S6VzmCogYtX5sPOu4aVCj4K4nkiukQumbyHR84rp0nEXQIbg3P5o3ApcWPrzL+NAyrxOTevFo3c1xqAbCo74BvY65AdJGYX6krF94NgAokhgHjHW4F4Y/uQyfengxwQe3kBx3hyO2a0EpTdn+81oYZQ2pPmTmd7p6S0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570542400; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=DMcrzqWgYRM1uz0k+CvfwWHS0zqwOwvzsUFKihb26Ug=; b=fUsJzcw1UP3/KbayplXKeCtR5+0mXVudYqCSXBKSL9bJP+kLCmvUEFQf0ANuzckrubLFJ216k7stB/CI85qXwXZ4Tm+cyMemAPBfeogTDDaACrAZmTeDkHbJ0OnO7bAIwT8PKsn1FqS3ZMfMFzatQ+FTgKHyd3xuG6WsNxGaJUw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570542400349111.66438108854504; Tue, 8 Oct 2019 06:46:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A61233018FC5; Tue, 8 Oct 2019 13:46:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73A2C60605; Tue, 8 Oct 2019 13:46:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 106E418089DC; Tue, 8 Oct 2019 13:46:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x98Dka4l030689 for ; Tue, 8 Oct 2019 09:46:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 697496060D; Tue, 8 Oct 2019 13:46:36 +0000 (UTC) Received: from catbus.gsslab.fab.redhat.com (dhcp-32.gsslab.fab.redhat.com [10.33.9.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id D18D660605; Tue, 8 Oct 2019 13:46:33 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Tue, 8 Oct 2019 14:41:08 +0100 Message-Id: <20191008134108.7501-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] m4: fix setting of warning flags X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 08 Oct 2019 13:46:39 +0000 (UTC) When adding the -std=3Dgnu99 flag, we set $wantwarn instead of appending to it. This meant all the compiler warnings were accidentally discarded. Signed-off-by: Daniel P. Berrang=C3=A9 --- Pushed as a trivial fix for the previous commit m4/virt-compile-warnings.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 411d257465..26f231f97e 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -192,7 +192,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # Request the gnu99 standard which is the best choice with # gcc 4.8.0. Not a warning flag, but the probing mechanism # is convenient - wantwarn=3D"-std=3Dgnu99" + wantwarn=3D"$wantwarn -std=3Dgnu99" =20 # Check for $CC support of each warning for w in $wantwarn; do --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list