From nobody Tue Apr 23 23:57:18 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
as permitted sender) client-ip=209.132.183.28;
envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=gmail.com
ARC-Seal: i=1; a=rsa-sha256; t=1570505952; cv=none;
d=zoho.com; s=zohoarc;
b=H0do/h1lI0AvVZ2js4/e5LB+55eC5uP989ZOGHS9JPPXz8gDtHWLAvUeQ25za14wnveO2YWs/NwhVpElcWziGHXv3I+kePzPuAdcdHSyicwH5+5lnwOiCH8g7WFc+rtUQrxoHn0TcPExmvLk6wBAqQv17ODKznjuy0q3NULBGGI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
s=zohoarc;
t=1570505952;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results;
bh=yj9fMK/Dym6aqXZg+gP+hE9gi/5slyY00oXldp/7MsQ=;
b=CKo+lD2cCH2DSweo2vd4wzhxVkU2iNryFGPjj1kxLSbDNprIwJB8xWkUNXUJjOrIfA3mHcyQTTG8WOFLFSXCav7F5wd8mlKVR8o6mXfNHRZzOjdzICNcvSBVLKUUneuYov3lU1gB0Q5B/tgbSS5ZhERs4ZpGbdWGx4HO7ApR44c=
ARC-Authentication-Results: i=1; mx.zoho.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
mx.zohomail.com
with SMTPS id 1570505952521637.5684393303308;
Mon, 7 Oct 2019 20:39:12 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 3AD7030860C3;
Tue, 8 Oct 2019 03:39:08 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F76E60925;
Tue, 8 Oct 2019 03:39:06 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4528218005A0;
Tue, 8 Oct 2019 03:39:02 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id x983bWR6030763 for ;
Mon, 7 Oct 2019 23:37:32 -0400
Received: by smtp.corp.redhat.com (Postfix)
id 20D0910013A1; Tue, 8 Oct 2019 03:37:32 +0000 (UTC)
Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com
[10.5.110.31])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BF681001DD8
for ; Tue, 8 Oct 2019 03:37:29 +0000 (UTC)
Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com
[209.85.160.179])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id BE958C047B68
for ; Tue, 8 Oct 2019 03:37:28 +0000 (UTC)
Received: by mail-qt1-f179.google.com with SMTP id o12so22948175qtf.3
for ; Mon, 07 Oct 2019 20:37:28 -0700 (PDT)
Received: from localhost.localdomain
([2804:431:c7cb:2ffa:6543:6636:1395:624c])
by smtp.gmail.com with ESMTPSA id
n192sm8186314qke.9.2019.10.07.20.37.25
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 07 Oct 2019 20:37:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=aDqkC6Yat6fC890ELrM7PoHm8YY5lInDJ487BGytr6Y=;
b=NyHsvW8epGV8xpjwTYc5fszqCy4ggoHOlZT8dCweJoaFicMGKZuPGySzCJITZuyv/i
v+KrNsCPbfgbm6QNQsNYyLOE0+vehFXhcMGLATIXBwtkSV1WGwBhg3sv9UGqwPQ8nh0+
fpTm7u5hV8twrMDHlLDNxKnvfpdKFB3fkrIA/shtbVAT+ss51AnDS1rWLTWma58G/XeN
WiKGEXEofaDp8rb12SEeB6ibWC7y4KyaS69VVmgIk56WGVmmjdpVw2yDHUuNznledvqz
c+OieQu7ZL8hFZ2xMjLyID4tWz/ByEBNpe9TqqT7QKQ8nZRf15LlxVMjZ3jrM/ldm+FY
rXbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=aDqkC6Yat6fC890ELrM7PoHm8YY5lInDJ487BGytr6Y=;
b=rUevVYIXaj4oAeaEXTLHP13Ue/1ZehgppxLqE5ncanzq1RlxPUx8iNV0q2Sx8P+/K0
5Z/OzppiwD0F+6mtI2EqNnw1e5KHwwOxhS2YfdcuePK5U2Eh24BEDves8ZCKc4VZdf+w
TmkSpitdFCo0grTSOlvIUHzrNEb/HRYSAr28S8OrmwRsVRgxnjIJO9SoG1CNG5l05RA4
jyiJH6AlBtElIsUcPAKqneXZgQwnugQwpmTUX7BPTZJ0VRXEHL+i+mxfK37KTYb4SrjD
bVoI7DTts/4xprdnv3bgjriETAR1KKDzCPy+fEHSKz3bCtmDhfmDzSAt0VgriwmE+Voi
iBgg==
X-Gm-Message-State: APjAAAUM6GN96FvA4t7SWF4MiH7/swtGFZK5PyQQuUL+10zYnsstd2yu
52PlKtKu1TZFHRXPHfhpgev0E4+d
X-Google-Smtp-Source:
APXvYqx8REQuHNnl6zFpES0g5/j1AnQc60QzhVT9TQH0uvFvU3BmGLgZHROoCeN6n6rKdlyJVm41HQ==
X-Received: by 2002:ac8:e82:: with SMTP id v2mr33731323qti.78.1570505847419;
Mon, 07 Oct 2019 20:37:27 -0700 (PDT)
From: jcfaracco@gmail.com
To: libvir-list@redhat.com
Date: Tue, 8 Oct 2019 00:35:56 -0300
Message-Id: <20191008033558.24751-2-jcfaracco@gmail.com>
In-Reply-To: <20191008033558.24751-1-jcfaracco@gmail.com>
References: <20191008033558.24751-1-jcfaracco@gmail.com>
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.31]);
Tue, 08 Oct 2019 03:37:28 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com
[10.5.110.31]);
Tue, 08 Oct 2019 03:37:28 +0000 (UTC) for IP:'209.85.160.179'
DOMAIN:'mail-qt1-f179.google.com'
HELO:'mail-qt1-f179.google.com' FROM:'jcfaracco@gmail.com' RCPT:''
X-RedHat-Spam-Score: -0.097 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU,
FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,
RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
SPF_PASS) 209.85.160.179 mail-qt1-f179.google.com 209.85.160.179
mail-qt1-f179.google.com
X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-loop: libvir-list@redhat.com
Cc: Julio Faracco
Subject: [libvirt] [PATCH v3 1/4] docs: Add 'x' and 'y' into video model XML
definition
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted,
not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]);
Tue, 08 Oct 2019 03:39:10 +0000 (UTC)
X-ZohoMail-DKIM: fail (Header signature does not verify)
Content-Type: text/plain; charset="utf-8"
From: Julio Faracco
This commit adds resolution element with parameters 'x' and 'y' into video
XML domain group definition. Both, properties were added into an element
called 'resolution' and it was added inside 'model' element. They are set
as optional. This element does not follow QEMU properties 'xres' and
'yres' format. HTML documentation was changed too.
Signed-off-by: Julio Faracco
---
docs/formatdomain.html.in | 5 ++++-
docs/schemas/domaincommon.rng | 10 ++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 647f96f651..d9d0b5a03b 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -7066,7 +7066,10 @@ qemu-kvm -net nic,model=3D? /dev/null
vgamem (since 1.2.11) =
to set
the size of VGA framebuffer for fallback mode of QXL device.
Attribute vram64 (since 1.3.3=
)
- extends secondary bar and makes it addressable as 64bit memory.
+ extends secondary bar and makes it addressable as 64bit memory. =
For
+ resolution settings, there are x and y
+ (since 5.9.0) optional attributes t=
o set
+ minimum resolution for model.
=20
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 40eb4a2d75..ad841d2746 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -3655,6 +3655,16 @@
+
+
+
+
+
+
+
+
+
+
--=20
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Tue Apr 23 23:57:18 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
as permitted sender) client-ip=209.132.183.28;
envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=gmail.com
ARC-Seal: i=1; a=rsa-sha256; t=1570506286; cv=none;
d=zoho.com; s=zohoarc;
b=J9t8zw1bKaG4uoXUEXuaVBDz6eYMOXHJYDyo2EEOSuAKp/E8FN58hYsfpo2jSpVkTDsQYlPFGDWxgA+p7Is+hayUuTT1MNHSkg9iHC2LFjJGjsl5phzyNL9vYC2Pn+lIxhAnuiX+83z/5E6MBeKw4lHrKF2VgBFfTHC3XH0U4/w=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
s=zohoarc;
t=1570506286;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results;
bh=Idps6ZlIy26BP+Rtpq/MTmfID3XNsc8aCstNmgtlX2U=;
b=aEWg2KxrmWUWRkrbV/5uvdBUH9eEDRrH9JX6p+S2FPCk+mMcvP7cTeZ4Wzom5bpm9FXmLbISyTi11yBzGbjxmjDl0bERP0WKXCncRHlt+kOPcBqj6TI1idMf9YfGkGr1IAg1cl9O1PSB5K+Qtf0S6r5bb/QX2CkOpfWyBLPQeCM=
ARC-Authentication-Results: i=1; mx.zoho.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
mx.zohomail.com
with SMTPS id 1570506286330398.3322754638681;
Mon, 7 Oct 2019 20:44:46 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id D574876531;
Tue, 8 Oct 2019 03:44:44 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
by smtp.corp.redhat.com (Postfix) with ESMTPS id B37B219C68;
Tue, 8 Oct 2019 03:44:44 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 774C84E58C;
Tue, 8 Oct 2019 03:44:44 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
[10.5.11.15])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id x983bcu7030782 for ;
Mon, 7 Oct 2019 23:37:38 -0400
Received: by smtp.corp.redhat.com (Postfix)
id 94BFA5D71C; Tue, 8 Oct 2019 03:37:38 +0000 (UTC)
Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com
[10.5.110.43])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F1C25D70D
for ; Tue, 8 Oct 2019 03:37:36 +0000 (UTC)
Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com
[209.85.160.195])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 4A04C308FC22
for ; Tue, 8 Oct 2019 03:37:35 +0000 (UTC)
Received: by mail-qt1-f195.google.com with SMTP id u22so22859819qtq.13
for ; Mon, 07 Oct 2019 20:37:35 -0700 (PDT)
Received: from localhost.localdomain
([2804:431:c7cb:2ffa:6543:6636:1395:624c])
by smtp.gmail.com with ESMTPSA id
n192sm8186314qke.9.2019.10.07.20.37.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 07 Oct 2019 20:37:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=Bka30spzQRGzAoPN4za/ZAtXl5t6wqnnF3kScJKDd1Y=;
b=RPk1xyoaLjjjASXxmvJ1KqaaZDxXD+oNz62h/zFaguCEEq5VSzuIifq7yZ+bKqUreE
sjCxU83QGLorz0YHgfbS/rY5fvLROoBQ5y9Er+rOsQDblYzovq++vzAap+jtkE7kOt4L
Y6GI8aRCrU11IAYojo+9Lgn6WS83eNVQFxy44CHxCguRaZoNylyCrbPMCzD5bdc3dK0Z
xD9DsPdmxLbZdEX/Cf7c8J0a+8jRhGEvvIzEnu5PHeBxC5IwRuoDLEcV714Lay1UsLEa
k4pcsV0RJFXkEZf2LkyKe/1vDDYa7eJZUZIugllkF2SLwoIn/zOeGErgV6ua2dmCbkje
cWyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=Bka30spzQRGzAoPN4za/ZAtXl5t6wqnnF3kScJKDd1Y=;
b=l/NCRz1OmByH+++ig/TMVBX3zQGyYFfCIDyrbNEwh9LMcImDe+CMzOz+iKvGGMuA5I
Cjn4x3+qwGSbm3I5LmRIXDxX2P4Rs9bm+jslAl5ohVDxg+fdebgtQzeeuy2k+hpnGzUv
34biGLEs98Gb1v1NUq2XxDJcIajBwuxhCli5PChX8ibf1YWDbULVzJWvlkFGteOU4MkA
hOi+Y8s19MHgvsi/EP2wDU6qcjDT3nMHPl29lUeMaLKN2GPRrbJBMeI2RiDGsk+iRXPA
xBAM03M/hJ9HgVGmisJ7zbdHY81vdfrk6SIUY2HGLUD8XJgyrba+x35VfVv/pv03P46+
dTzw==
X-Gm-Message-State: APjAAAXZHyC10MOWzfV61q4pt8AcwaRHNn7VTugt55V2xE9Vz5atZZnc
+ayER8q6QTyCvF4Y69mwiKWE4zZl
X-Google-Smtp-Source:
APXvYqxRF1wXulQtk1BOw5ppkzob6vct8IQLJtbt01QGamIeLH5d3fIr3PzCE72/rSnoS/KBSqWwoQ==
X-Received: by 2002:ac8:3150:: with SMTP id h16mr33391997qtb.14.1570505854195;
Mon, 07 Oct 2019 20:37:34 -0700 (PDT)
From: jcfaracco@gmail.com
To: libvir-list@redhat.com
Date: Tue, 8 Oct 2019 00:35:57 -0300
Message-Id: <20191008033558.24751-3-jcfaracco@gmail.com>
In-Reply-To: <20191008033558.24751-1-jcfaracco@gmail.com>
References: <20191008033558.24751-1-jcfaracco@gmail.com>
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.43]);
Tue, 08 Oct 2019 03:37:35 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com
[10.5.110.43]);
Tue, 08 Oct 2019 03:37:35 +0000 (UTC) for IP:'209.85.160.195'
DOMAIN:'mail-qt1-f195.google.com'
HELO:'mail-qt1-f195.google.com' FROM:'jcfaracco@gmail.com' RCPT:''
X-RedHat-Spam-Score: -0.097 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU,
FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,
RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
SPF_PASS) 209.85.160.195 mail-qt1-f195.google.com 209.85.160.195
mail-qt1-f195.google.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.110.43
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Cc: Julio Faracco
Subject: [libvirt] [PATCH v3 2/4] qemu: Generate 'xres' and 'yres' for video
devices
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted,
not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]);
Tue, 08 Oct 2019 03:44:45 +0000 (UTC)
X-ZohoMail-DKIM: fail (Header signature does not verify)
Content-Type: text/plain; charset="utf-8"
From: Julio Faracco
Now, QEMU command line can define 'xres' and 'yres' if XML contains both
properties from video model. This is generetaed if resolution was set.
Code let QEMU handle if video model supports this feature.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_command.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index cbf25d5f07..99b43243e3 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4596,6 +4596,11 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,
virBufferAsprintf(&buf, ",vgamem=3D%uk", video->vram);
}
=20
+ if (video->res && video->res->x && video->res->y) {
+ /* QEMU accepts resolution xres and yres. */
+ virBufferAsprintf(&buf, ",xres=3D%u,yres=3D%u", video->res->x, vid=
eo->res->y);
+ }
+
if (qemuBuildDeviceAddressStr(&buf, def, &video->info, qemuCaps) < 0)
return NULL;
=20
--=20
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Tue Apr 23 23:57:18 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
as permitted sender) client-ip=209.132.183.28;
envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=gmail.com
ARC-Seal: i=1; a=rsa-sha256; t=1570505970; cv=none;
d=zoho.com; s=zohoarc;
b=jekmAPxRwq276EQ/7AXdOxvDk2oRVzg/mK+phhEZcxUACd5we78gyMjsJYj4GrwGSw/NNRqpsjHEokbgUlRvnF87On6BewJtMt5KBXjUiGHv3rBqkKspVZU/d7S5ogjGPUgQvvJN/dY2uK8+5jhcU+YBVtwVopU25cqnRUT/bog=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
s=zohoarc;
t=1570505970;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results;
bh=R+frRCE5jPOnWgIpbHZsiRJlHGvj1AGrpsXf7TnjnHA=;
b=QoDPfXSJE9ohvYy8XUSO+kA9wAE7obWU6Qm/eUiG36bRMZVSRwXSNXhfqRWS5eDljIQ2IFjE7F6pwE3ldSL0rnJxbwjYA3JtbH8x7wHclV+pFdRHErHh4IbWfh9nvtp47bGqwbYh3ZVxKAlnWDG6sqlxBy7mlIVXz3XLRdB8r+A=
ARC-Authentication-Results: i=1; mx.zoho.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
mx.zohomail.com
with SMTPS id 1570505970878853.3876068645425;
Mon, 7 Oct 2019 20:39:30 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id C414F63704;
Tue, 8 Oct 2019 03:39:28 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 710CB19C68;
Tue, 8 Oct 2019 03:39:28 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id E028C180B761;
Tue, 8 Oct 2019 03:39:27 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id x983btHT030816 for ;
Mon, 7 Oct 2019 23:37:55 -0400
Received: by smtp.corp.redhat.com (Postfix)
id 09F3519C69; Tue, 8 Oct 2019 03:37:55 +0000 (UTC)
Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com
[10.5.110.25])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 0485119C68
for ; Tue, 8 Oct 2019 03:37:52 +0000 (UTC)
Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com
[209.85.160.194])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id CEFFC81F31
for ; Tue, 8 Oct 2019 03:37:51 +0000 (UTC)
Received: by mail-qt1-f194.google.com with SMTP id m15so22960159qtq.2
for ; Mon, 07 Oct 2019 20:37:51 -0700 (PDT)
Received: from localhost.localdomain
([2804:431:c7cb:2ffa:6543:6636:1395:624c])
by smtp.gmail.com with ESMTPSA id
n192sm8186314qke.9.2019.10.07.20.37.49
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 07 Oct 2019 20:37:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=ID2iIsyiAJwKzmNrGMVHLvJu//+tB6KudUc33nr9VWE=;
b=pyDzfN8rAanKVCpYP5aBTWQ7YREGlA3W/cTEy+FX3t3u2pocH356Mhd5PLcDNQmDWv
BTfmeLqNFbh4kpseraYDtgILf3pZfRuWY2pKgpRqjoDFd4fpptfwfREH/rtqPpz7lZV0
B0H1dq+ef0MB2pbLFLFM5VbOLRZAPJiGFydw7J/faXBOLyocU8KBRkQFbtb7WbqLRit8
G35yxBE3L9MbyU+Fg8dqar7637G+oQB2DE1VL0xOgjgYHQKgGTEQT07US1egfD+my6wB
ZvLNdPWvDBjerS9TGw2cpqeC0KGYzS7vrkvUQIm4FaDlDP0tlbnOiSDH0Sich9K7FRYV
91hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=ID2iIsyiAJwKzmNrGMVHLvJu//+tB6KudUc33nr9VWE=;
b=akTpvA/k2HnLWrD7FSXwqXcFP8OkSAEUgfn2IEIvndRQSTtI4xFlW/ORkeg7vCCusg
d0csNaxHtLZwTVc7n1Bnsbs33k6Y4zbHwdhysrShjNoN7cbkNXx+QpY+DH5HSYNguHmM
H7jx3pRLI7tIMN2BUNqs25f3KlEAIo4Cj4HxjCAIQAzFw3HObNryiMVGPUDrXHmsNqKC
gqSui8slXF1lmlNJPsRBxya1vtGAt96OgzYcnchq7Qr/vaFKEZA8iTjkLuQVhEOovCfe
3ZhmY/HIVOSorEeXdqjmhp8MvjvfOHA9rH7gcu1Uf3Fyul+vQ6VW6RYE3Gbe93COCndz
NE6w==
X-Gm-Message-State: APjAAAWlUssrCffAh97DWWholgW8mPqHQN+tgkw/ILwNAG7m52L7Iepy
GlWwSbBaEmkiTgSBzy7yFNEzyeA4
X-Google-Smtp-Source:
APXvYqzlDJqCBtu0g8ZrmS9a4lHze5+SXluhj5etUeRn190oCMtEebC5pU7gYnZhud2lMler8Zuq0w==
X-Received: by 2002:a0c:fec3:: with SMTP id z3mr29307678qvs.122.1570505870590;
Mon, 07 Oct 2019 20:37:50 -0700 (PDT)
From: jcfaracco@gmail.com
To: libvir-list@redhat.com
Date: Tue, 8 Oct 2019 00:35:58 -0300
Message-Id: <20191008033558.24751-4-jcfaracco@gmail.com>
In-Reply-To: <20191008033558.24751-1-jcfaracco@gmail.com>
References: <20191008033558.24751-1-jcfaracco@gmail.com>
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.25]);
Tue, 08 Oct 2019 03:37:52 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com
[10.5.110.25]);
Tue, 08 Oct 2019 03:37:52 +0000 (UTC) for IP:'209.85.160.194'
DOMAIN:'mail-qt1-f194.google.com'
HELO:'mail-qt1-f194.google.com' FROM:'jcfaracco@gmail.com' RCPT:''
X-RedHat-Spam-Score: -0.097 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU,
FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,
RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
SPF_PASS) 209.85.160.194 mail-qt1-f194.google.com 209.85.160.194
mail-qt1-f194.google.com
X-Scanned-By: MIMEDefang 2.83 on 10.5.110.25
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-loop: libvir-list@redhat.com
Cc: Julio Faracco
Subject: [libvirt] [PATCH v3 3/4] conf: Add XML resolution support for video
models
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted,
not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]);
Tue, 08 Oct 2019 03:39:29 +0000 (UTC)
X-ZohoMail-DKIM: fail (Header signature does not verify)
Content-Type: text/plain; charset="utf-8"
From: Julio Faracco
XML need to support both properties together. This commit adds XML
support for video model if they are set. Domain configuration is able
to parse this properties as 'x' and 'y'. Code is not using same label as
QEMU: 'xres' and 'yres'.
Signed-off-by: Julio Faracco
---
src/conf/domain_conf.c | 74 ++++++++++++++++++++++++++++++++++++++++-
src/conf/domain_conf.h | 5 +++
src/conf/virconftypes.h | 3 ++
3 files changed, 81 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a53cd6a725..950c4522f9 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15403,6 +15403,52 @@ virDomainVideoAccelDefParseXML(xmlNodePtr node)
return def;
}
=20
+static virDomainVideoResolutionDefPtr
+virDomainVideoResolutionDefParseXML(xmlNodePtr node)
+{
+ xmlNodePtr cur;
+ virDomainVideoResolutionDefPtr def;
+ VIR_AUTOFREE(char *) x =3D NULL;
+ VIR_AUTOFREE(char *) y =3D NULL;
+
+ cur =3D node->children;
+ while (cur !=3D NULL) {
+ if (cur->type =3D=3D XML_ELEMENT_NODE) {
+ if (!x && !y &&
+ virXMLNodeNameEqual(cur, "resolution")) {
+ x =3D virXMLPropString(cur, "x");
+ y =3D virXMLPropString(cur, "y");
+ }
+ }
+ cur =3D cur->next;
+ }
+
+ if (!x || !y)
+ return NULL;
+
+ if (VIR_ALLOC(def) < 0)
+ goto cleanup;
+
+ if (x) {
+ if (virStrToLong_uip(x, NULL, 10, &def->x) < 0) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("cannot parse video x-resolution '%s'"), x);
+ goto cleanup;
+ }
+ }
+
+ if (y) {
+ if (virStrToLong_uip(y, NULL, 10, &def->y) < 0) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("cannot parse video y-resolution '%s'"), y);
+ goto cleanup;
+ }
+ }
+
+ cleanup:
+ return def;
+}
+
static virDomainVideoDriverDefPtr
virDomainVideoDriverDefParseXML(xmlNodePtr node)
{
@@ -15482,6 +15528,7 @@ virDomainVideoDefParseXML(virDomainXMLOptionPtr xml=
opt,
}
=20
def->accel =3D virDomainVideoAccelDefParseXML(cur);
+ def->res =3D virDomainVideoResolutionDefParseXML(cur);
}
if (virXMLNodeNameEqual(cur, "driver")) {
if (virDomainVirtioOptionsParseXML(cur, &def->virtio) < 0)
@@ -15569,6 +15616,17 @@ virDomainVideoDefParseXML(virDomainXMLOptionPtr xm=
lopt,
}
}
=20
+ if (def->res) {
+ if (def->type !=3D VIR_DOMAIN_VIDEO_TYPE_VGA &&
+ def->type !=3D VIR_DOMAIN_VIDEO_TYPE_QXL &&
+ def->type !=3D VIR_DOMAIN_VIDEO_TYPE_VIRTIO &&
+ def->type !=3D VIR_DOMAIN_VIDEO_TYPE_BOCHS) {
+ virReportError(VIR_ERR_XML_ERROR, "%s",
+ _("model resolution is not supported"));
+ goto error;
+ }
+ }
+
if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, flags) < 0)
goto error;
=20
@@ -26574,6 +26632,18 @@ virDomainVideoAccelDefFormat(virBufferPtr buf,
virBufferAddLit(buf, "/>\n");
}
=20
+static void
+virDomainVideoResolutionDefFormat(virBufferPtr buf,
+ virDomainVideoResolutionDefPtr def)
+{
+ virBufferAddLit(buf, "x && def->y) {
+ virBufferAsprintf(buf, " x=3D'%u' y=3D'%u'",
+ def->x, def->y);
+ }
+ virBufferAddLit(buf, "/>\n");
+}
+
static int
virDomainVideoDefFormat(virBufferPtr buf,
virDomainVideoDefPtr def,
@@ -26621,11 +26691,13 @@ virDomainVideoDefFormat(virBufferPtr buf,
virBufferAsprintf(buf, " heads=3D'%u'", def->heads);
if (def->primary)
virBufferAddLit(buf, " primary=3D'yes'");
- if (def->accel) {
+ if (def->accel || def->res) {
virBufferAddLit(buf, ">\n");
virBufferAdjustIndent(buf, 2);
if (def->accel)
virDomainVideoAccelDefFormat(buf, def->accel);
+ if (def->res)
+ virDomainVideoResolutionDefFormat(buf, def->res);
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "\n");
} else {
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 2884af49d8..ce5da4ddf4 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1420,6 +1420,10 @@ struct _virDomainVideoAccelDef {
char *rendernode;
};
=20
+struct _virDomainVideoResolutionDef {
+ unsigned int x;
+ unsigned int y;
+};
=20
struct _virDomainVideoDriverDef {
virDomainVideoVGAConf vgaconf;
@@ -1437,6 +1441,7 @@ struct _virDomainVideoDef {
unsigned int heads;
bool primary;
virDomainVideoAccelDefPtr accel;
+ virDomainVideoResolutionDefPtr res;
virDomainVideoDriverDefPtr driver;
virDomainDeviceInfo info;
virDomainVirtioOptionsPtr virtio;
diff --git a/src/conf/virconftypes.h b/src/conf/virconftypes.h
index a15cfb5f9e..462842f324 100644
--- a/src/conf/virconftypes.h
+++ b/src/conf/virconftypes.h
@@ -324,6 +324,9 @@ typedef virDomainVcpuDef *virDomainVcpuDefPtr;
typedef struct _virDomainVideoAccelDef virDomainVideoAccelDef;
typedef virDomainVideoAccelDef *virDomainVideoAccelDefPtr;
=20
+typedef struct _virDomainVideoResolutionDef virDomainVideoResolutionDef;
+typedef virDomainVideoResolutionDef *virDomainVideoResolutionDefPtr;
+
typedef struct _virDomainVideoDef virDomainVideoDef;
typedef virDomainVideoDef *virDomainVideoDefPtr;
=20
--=20
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Tue Apr 23 23:57:18 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
as permitted sender) client-ip=209.132.183.28;
envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=gmail.com
ARC-Seal: i=1; a=rsa-sha256; t=1570506015; cv=none;
d=zoho.com; s=zohoarc;
b=hdTQE3NvKJrtg5VwMV6jrwWI3SBBL+WWHEs8+d+Vmmch1B7JybvxZvfTGccrYLOF5bK3a+WgeQ6O98qfNkffKyxEFVCR7llqb7sHim7pMLRvT+I9VmUiLim+VxBwRdwnJAmCMVhRGFGeaA6qhRt/8xInHFAAo1UxmIouAIO3DYE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
s=zohoarc;
t=1570506015;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results;
bh=jxbpYIkMAHrbUvgi8zOz6yMNyFdkm4fPuZ+8lWk5Sy4=;
b=V+FSc+snoXhJ0NNKivdlE2NqlNYx3N2TjEl8ey0SyYJcAaMDB1R8R5QE01jWlaSA9rLCW7ybqRsK9Ell/Awagst+pW1B1bsN4HMkPG83OI53qaDggdPE7zMIekZcEg0mZwIr+3grz0WI097bxQ5GVtyieqe/ZIt2LJsWn4nhVlU=
ARC-Authentication-Results: i=1; mx.zoho.com;
dkim=fail;
spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
mx.zohomail.com
with SMTPS id 1570506015038230.9438470582213;
Mon, 7 Oct 2019 20:40:15 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id EC2F7A44AC3;
Tue, 8 Oct 2019 03:40:12 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id BE34E100EBA3;
Tue, 8 Oct 2019 03:40:12 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5A898180B76F;
Tue, 8 Oct 2019 03:40:12 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id x983bx7A030843 for ;
Mon, 7 Oct 2019 23:37:59 -0400
Received: by smtp.corp.redhat.com (Postfix)
id CC52260925; Tue, 8 Oct 2019 03:37:59 +0000 (UTC)
Received: from mx1.redhat.com (ext-mx21.extmail.prod.ext.phx2.redhat.com
[10.5.110.62])
by smtp.corp.redhat.com (Postfix) with ESMTPS id C6B5260605
for ; Tue, 8 Oct 2019 03:37:57 +0000 (UTC)
Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com
[209.85.160.172])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 5B24418C4284
for ; Tue, 8 Oct 2019 03:37:56 +0000 (UTC)
Received: by mail-qt1-f172.google.com with SMTP id n7so22924197qtb.6
for ; Mon, 07 Oct 2019 20:37:56 -0700 (PDT)
Received: from localhost.localdomain
([2804:431:c7cb:2ffa:6543:6636:1395:624c])
by smtp.gmail.com with ESMTPSA id
n192sm8186314qke.9.2019.10.07.20.37.53
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 07 Oct 2019 20:37:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=WhfoZWCvKc4CkuUB4RDAdQ/oosM3/4SP8fX2cQoRico=;
b=dZa7kq9aZjUy4uRz5O3Ibqzy9aifEZ4Ut6gdIhw8hoCzKBX+ut2v9SqrYQzDjkZZbU
T27ODhRgpnCPn8xHe+Ms0wQLkingNpO06mYOampMIG1A9XXTbq8qeidJX6xXRoOtua+J
zMp8YFa0V5cWrVhnpVZVZOmfXHoSX5WLi7E5M0CXkuyrYmiZbxe4jJ5+bgFVlcSUUxY1
1yzKLTl5fEUE450wmUVQAJdJg0I6/t7TUBsSSHvWVVRqNDv3ixkS/IXSV2RWOymMCRR/
Vl5o+7QqyMv5/+O7brQo1PSVB+tJIhPI3ztL9BCnqaamiTUwG2pfaBgt+KrgguhooLsN
WE6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=WhfoZWCvKc4CkuUB4RDAdQ/oosM3/4SP8fX2cQoRico=;
b=PSSh+8kKT/cpBPNh6qeg0TSoI5Sf6pzCbSfepjefG+LDOKduabSZ1Wi2B1ZwJPzk6k
753dFTtep97fGIJTsbw10rDxfgl16nmm9/W/Jp2rG77+MRV/2s/bb9wh7E7UGLUp79of
+EcLBVvDeBqX3k49QLVxyd2F+fGKAcl4xH9NhpXXSjBWAiryj91ITgCAxLBULLToYPsC
Rv4h2z6WPi9bafxJT88ngzdpPMR3m5clugfUWTE45A7oSaPsOa7KITQMUG6uWWETZbVf
qOKAHvyYOW/MWy+fbt48FEwjMBSv5pRZmq8MaqLclkMRWM3JLv4jT817anQQSQMOGFGo
ly1w==
X-Gm-Message-State: APjAAAX0FPXWIiid43mOOAXEYT+JNLivtaL5C1avHbrrORHwixQWIb+/
OmV9D0iG/XenRghLBJqcU5RtttAQ
X-Google-Smtp-Source:
APXvYqwUEu5H3dmEw40Du3sGRWXkfiHSLxyLhHqaGiysJE9uZjzdDKJTRXH+ksPBy6uBzBikd+wqhA==
X-Received: by 2002:ac8:76c6:: with SMTP id q6mr3322318qtr.158.1570505875101;
Mon, 07 Oct 2019 20:37:55 -0700 (PDT)
From: jcfaracco@gmail.com
To: libvir-list@redhat.com
Date: Tue, 8 Oct 2019 00:35:59 -0300
Message-Id: <20191008033558.24751-5-jcfaracco@gmail.com>
In-Reply-To: <20191008033558.24751-1-jcfaracco@gmail.com>
References: <20191008033558.24751-1-jcfaracco@gmail.com>
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2
(mx1.redhat.com [10.5.110.62]);
Tue, 08 Oct 2019 03:37:56 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]);
Tue, 08 Oct 2019 03:37:56 +0000 (UTC) for IP:'209.85.160.172'
DOMAIN:'mail-qt1-f172.google.com'
HELO:'mail-qt1-f172.google.com' FROM:'jcfaracco@gmail.com' RCPT:''
X-RedHat-Spam-Score: -0.1 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU,
FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,
SPF_HELO_NONE,
SPF_PASS) 209.85.160.172 mail-qt1-f172.google.com 209.85.160.172
mail-qt1-f172.google.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.110.62
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-loop: libvir-list@redhat.com
Cc: Julio Faracco
Subject: [libvirt] [PATCH v3 4/4] tests: Add separate tests for resolution
'x' and 'y'
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted,
not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]);
Tue, 08 Oct 2019 03:40:13 +0000 (UTC)
X-ZohoMail-DKIM: fail (Header signature does not verify)
Content-Type: text/plain; charset="utf-8"
From: Julio Faracco
New tests to verify resolution properties of a simple qxl video. Other
video models supports 'xres' and 'yres' feature for QEMU. But a qxl test
should be enough to cover this domain feature.
Signed-off-by: Julio Faracco
---
.../video-qxl-resolution.args | 32 ++++++++++++++
.../qemuxml2argvdata/video-qxl-resolution.xml | 42 +++++++++++++++++++
tests/qemuxml2argvtest.c | 4 ++
.../video-qxl-resolution.xml | 42 +++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
5 files changed, 121 insertions(+)
create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.args
create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.xml
create mode 100644 tests/qemuxml2xmloutdata/video-qxl-resolution.xml
diff --git a/tests/qemuxml2argvdata/video-qxl-resolution.args b/tests/qemux=
ml2argvdata/video-qxl-resolution.args
new file mode 100644
index 0000000000..ed2e4422da
--- /dev/null
+++ b/tests/qemuxml2argvdata/video-qxl-resolution.args
@@ -0,0 +1,32 @@
+LC_ALL=3DC \
+PATH=3D/bin \
+HOME=3D/tmp/lib/domain--1-QEMUGuest1 \
+USER=3Dtest \
+LOGNAME=3Dtest \
+XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.local/share \
+XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.cache \
+XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \
+QEMU_AUDIO_DRV=3Dnone \
+/usr/bin/qemu-system-i686 \
+-name QEMUGuest1 \
+-S \
+-machine pc,accel=3Dtcg,usb=3Doff,dump-guest-core=3Doff \
+-m 214 \
+-realtime mlock=3Doff \
+-smp 1,sockets=3D1,cores=3D1,threads=3D1 \
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=3Dcharmonitor,path=3D/tmp/lib/domain--1-QEMUGuest1/moni=
tor.sock,\
+server,nowait \
+-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \
+-rtc base=3Dutc \
+-no-shutdown \
+-no-acpi \
+-usb \
+-drive file=3D/dev/HostVG/QEMUGuest1,format=3Draw,if=3Dnone,id=3Ddrive-ide=
0-0-0 \
+-device ide-hd,bus=3Dide.0,unit=3D0,drive=3Ddrive-ide0-0-0,id=3Dide0-0-0,b=
ootindex=3D1 \
+-device qxl-vga,id=3Dvideo0,ram_size=3D67108864,vram_size=3D67108864,vgame=
m_mb=3D8,\
+xres=3D1280,yres=3D720,bus=3Dpci.0,addr=3D0x2 \
+-device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0x3
diff --git a/tests/qemuxml2argvdata/video-qxl-resolution.xml b/tests/qemuxm=
l2argvdata/video-qxl-resolution.xml
new file mode 100644
index 0000000000..1bc415f3f8
--- /dev/null
+++ b/tests/qemuxml2argvdata/video-qxl-resolution.xml
@@ -0,0 +1,42 @@
+
+ QEMUGuest1
+ c7a5fdbd-edaf-9455-926a-d65c16db1809
+ 219136
+ 219136
+ 1
+
+ hvm
+
+
+
+ destroy
+ restart
+ destroy
+
+ /usr/bin/qemu-system-i686
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index db79301f0e..12f620fc1d 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2055,6 +2055,10 @@ mymain(void)
QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
QEMU_CAPS_DEVICE_QXL,
QEMU_CAPS_QXL_MAX_OUTPUTS);
+ DO_TEST("video-qxl-resolution",
+ QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
+ QEMU_CAPS_DEVICE_QXL,
+ QEMU_CAPS_QXL_VGAMEM);
DO_TEST("video-virtio-gpu-device",
QEMU_CAPS_DEVICE_VIRTIO_GPU,
QEMU_CAPS_DEVICE_VIDEO_PRIMARY);
diff --git a/tests/qemuxml2xmloutdata/video-qxl-resolution.xml b/tests/qemu=
xml2xmloutdata/video-qxl-resolution.xml
new file mode 100644
index 0000000000..1bc415f3f8
--- /dev/null
+++ b/tests/qemuxml2xmloutdata/video-qxl-resolution.xml
@@ -0,0 +1,42 @@
+
+ QEMUGuest1
+ c7a5fdbd-edaf-9455-926a-d65c16db1809
+ 219136
+ 219136
+ 1
+
+ hvm
+
+
+
+ destroy
+ restart
+ destroy
+
+ /usr/bin/qemu-system-i686
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index d5c66d8791..9fb207bfbb 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -1209,6 +1209,7 @@ mymain(void)
QEMU_CAPS_DEVICE_QXL);
DO_TEST("video-qxl-heads", NONE);
DO_TEST("video-qxl-noheads", NONE);
+ DO_TEST("video-qxl-resolution", NONE);
DO_TEST("video-virtio-gpu-secondary", NONE);
DO_TEST("video-virtio-gpu-ccw",
QEMU_CAPS_CCW,
--=20
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list