[libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots

Simon Kobyda posted 2 patches 2 weeks ago
Failed in applying to current master (apply log)
data/Makefile.am                    |   1 +
data/org.libvirt.Domain.xml         |  26 +++
data/org.libvirt.DomainSnapshot.xml |  41 ++++
src/Makefile.am                     |   2 +
src/connect.c                       |   6 +
src/connect.h                       |   1 +
src/domain.c                        | 158 ++++++++++++++++
src/domainsnapshot.c                | 281 ++++++++++++++++++++++++++++
src/domainsnapshot.h                |   9 +
src/util.c                          |  47 +++++
src/util.h                          |  16 ++
tests/Makefile.am                   |   1 +
tests/libvirttest.py                |  14 ++
tests/test_domain.py                |   8 +
tests/test_snapshot.py              |  43 +++++
tests/xmldata.py                    |   6 +
16 files changed, 660 insertions(+)
create mode 100644 data/org.libvirt.DomainSnapshot.xml
create mode 100644 src/domainsnapshot.c
create mode 100644 src/domainsnapshot.h
create mode 100755 tests/test_snapshot.py

[libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots

Posted by Simon Kobyda 2 weeks ago
Implement snapshot interface and its APIs.

Simon Kobyda (2):
  Introduce Domain Snapshot Interface
  Implement snapshots APIs

 data/Makefile.am                    |   1 +
 data/org.libvirt.Domain.xml         |  26 +++
 data/org.libvirt.DomainSnapshot.xml |  41 ++++
 src/Makefile.am                     |   2 +
 src/connect.c                       |   6 +
 src/connect.h                       |   1 +
 src/domain.c                        | 158 ++++++++++++++++
 src/domainsnapshot.c                | 281 ++++++++++++++++++++++++++++
 src/domainsnapshot.h                |   9 +
 src/util.c                          |  47 +++++
 src/util.h                          |  16 ++
 tests/Makefile.am                   |   1 +
 tests/libvirttest.py                |  14 ++
 tests/test_domain.py                |   8 +
 tests/test_snapshot.py              |  43 +++++
 tests/xmldata.py                    |   6 +
 16 files changed, 660 insertions(+)
 create mode 100644 data/org.libvirt.DomainSnapshot.xml
 create mode 100644 src/domainsnapshot.c
 create mode 100644 src/domainsnapshot.h
 create mode 100755 tests/test_snapshot.py

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots

Posted by Fabiano Fidêncio 1 week ago
Simon,

On Mon, Oct 7, 2019 at 5:30 PM Simon Kobyda <skobyda@redhat.com> wrote:
>
> Implement snapshot interface and its APIs.
>

Apart from the comments made by Jano, I'd strongly recommend to have
this series rebased atop of Pavel Hrdina's series switching
libvirt-dbus to meson.

His series is already reviewed and will be pushed as soon as we have
libvirt-jenkins-ci work merged.

Best Regards,
-- 
Fabiano Fidêncio

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list