From nobody Thu Apr 25 04:48:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570457722; cv=none; d=zoho.com; s=zohoarc; b=kfbO+kPNsPuNV2QyXa9MTJtekNcYHtxXozi11t6mwRshb1I+Hn7hijkvhBrCtapSCBKIHIlAsGSkt2qFco+Mxy2m7Fz67ZxA+1kkctErkkHW6rbbSLL8wULeBroCoqhtCBHyvOi5vxmClilPWRgrHof1KgsBBVTBx+HNWJYAgfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570457722; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=b3qETK5RPwhgwZZZTMoThrhqA266VmLG2+ApZx0k8Io=; b=R+kEwmWfewHhOuJfB+cZ/KfEi3f6jP7QZzmC+4ALYSHXR4oYXJAtZJpIqLZ94Q71xhnaMG5PflzSzZyMVLe9k3ZJFK1nFgVvqRq/QaEHvLAuiiyzHnBdDuyVpOxSzzHtioSU1bApwHvNR3NX1zzhQusDbu/9HIpNsLUrh2xMV1s= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15704577220841023.599370476883; Mon, 7 Oct 2019 07:15:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E1F6C04BD33; Mon, 7 Oct 2019 14:15:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DEF3A6012A; Mon, 7 Oct 2019 14:15:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F3EEC4EE68; Mon, 7 Oct 2019 14:15:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x97EFFox018595 for ; Mon, 7 Oct 2019 10:15:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9C7CF1001B33; Mon, 7 Oct 2019 14:15:15 +0000 (UTC) Received: from catbus.gsslab.fab.redhat.com (dhcp-32.gsslab.fab.redhat.com [10.33.9.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D3511001B30; Mon, 7 Oct 2019 14:15:12 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 7 Oct 2019 15:09:52 +0100 Message-Id: <20191007140952.18753-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] build: ask for -std=gnu99 explicitly X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 07 Oct 2019 14:15:20 +0000 (UTC) We previously got -std=3Dgnu99 secretly enabled as a side-effect of requesting the 'stdarg' gnulib module. We rely on some extensions from c99/gnu99 and while RHEL-7 supports this, it still defaults to gnu89. RHEL-7 also supports some newer standards but declares them experimental/incomplete, so sticking with gnu99 is best bet for now & matches historical usage. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Fid=C3=AAncio --- m4/virt-compile-warnings.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index f9460e82ba..502f7384ff 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -189,6 +189,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ wantwarn=3D"$wantwarn -Werror" fi =20 + # Request the gnu99 standard which is the best choice with + # gcc 4.8.0 + wantwarn=3D"-std=3Dgnu99" + # Check for $CC support of each warning for w in $wantwarn; do gl_WARN_ADD([$w]) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list