From nobody Sun Feb 8 16:24:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569604671; cv=none; d=zoho.com; s=zohoarc; b=XHQAQIidkoAWLHq6NNN3XgjI2g9LRZo6rwfWwZ+m/6V04yHUasqHKHQ5O3cEg5vFbqCvehtNVOaE6U08K3YhdRQ/7JZ90YlXjL2oL07N8Az4nY5W9Afvo2YuH9rthE6/Q+7lxdkk/3EPB1XcjnObbRm+W+RHCHuhJYzrGe11D5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569604671; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ir4VLgWkmMNhtY36NakhtrLmxgW1huUsxlj41EM0J68=; b=b0vJcIodv3MbSTjj2jUWRQeL9DRdHzzeMnj7cxF7gl6GbX+f/g7WtoDRQpGz0y4lJjzvFX7PI27HSMy7euC14+HmHwebByyGR6GmwqNdsEz7zOPWvsqP76E/x+jBgT2T6FIQ8WCI3Ot9KW+R/3QF7I4bqRAXqMg/3lrsC4LiXW8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1569604671687448.4107993183202; Fri, 27 Sep 2019 10:17:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6F01300D1C8; Fri, 27 Sep 2019 17:17:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2EE75D9D6; Fri, 27 Sep 2019 17:17:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8C2B54EE6A; Fri, 27 Sep 2019 17:17:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8RHHgrh016541 for ; Fri, 27 Sep 2019 13:17:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id A97D1600CD; Fri, 27 Sep 2019 17:17:42 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DFE5600C6; Fri, 27 Sep 2019 17:17:41 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 27 Sep 2019 18:17:25 +0100 Message-Id: <20190927171733.10842-4-berrange@redhat.com> In-Reply-To: <20190927171733.10842-1-berrange@redhat.com> References: <20190927171733.10842-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 03/11] remote: don't pull anonymous enums into rpc protocol structs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 27 Sep 2019 17:17:50 +0000 (UTC) The VIR_TYPED_PARAM_* enum fields are defined in libvirt-common.h, not in the remote protcol, so shouldn't be part of the protocol structs output check. This avoids similar problems hitting when we add use of glib, which has other such anonymous enums. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Pavel Hrdina --- src/Makefile.am | 3 +-- src/admin_protocol-structs | 9 --------- src/remote_protocol-structs | 9 --------- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 66ba710e50..9d21395892 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -241,8 +241,7 @@ PDWTAGS =3D \ else \ $(PERL) -0777 -n \ -e 'foreach my $$p (split m!\n*(?:$(r1)|$(r2))\n!) {' \ - -e ' if ($$p =3D~ /^(struct|enum) $(struct_prefix)/ ||' \ - -e ' $$p =3D~ /^enum \{/) {' \ + -e ' if ($$p =3D~ /^(struct|enum) $(struct_prefix)/) {' \ -e ' $$p =3D~ s!\t*/\*.*?\*/!!sg;' \ -e ' $$p =3D~ s!\s+\n!\n!sg;' \ -e ' $$p =3D~ s!\s+$$!!;' \ diff --git a/src/admin_protocol-structs b/src/admin_protocol-structs index a6c53807ee..983e6e5292 100644 --- a/src/admin_protocol-structs +++ b/src/admin_protocol-structs @@ -1,13 +1,4 @@ /* -*- c -*- */ -enum { - VIR_TYPED_PARAM_INT =3D 1, - VIR_TYPED_PARAM_UINT =3D 2, - VIR_TYPED_PARAM_LLONG =3D 3, - VIR_TYPED_PARAM_ULLONG =3D 4, - VIR_TYPED_PARAM_DOUBLE =3D 5, - VIR_TYPED_PARAM_BOOLEAN =3D 6, - VIR_TYPED_PARAM_STRING =3D 7, -}; struct admin_typed_param_value { int type; union { diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index eb689b3574..51606e7473 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -1,13 +1,4 @@ /* -*- c -*- */ -enum { - VIR_TYPED_PARAM_INT =3D 1, - VIR_TYPED_PARAM_UINT =3D 2, - VIR_TYPED_PARAM_LLONG =3D 3, - VIR_TYPED_PARAM_ULLONG =3D 4, - VIR_TYPED_PARAM_DOUBLE =3D 5, - VIR_TYPED_PARAM_BOOLEAN =3D 6, - VIR_TYPED_PARAM_STRING =3D 7, -}; struct remote_nonnull_domain { remote_nonnull_string name; remote_uuid uuid; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list