[libvirt] [PATCH] qemu: ensure vhostuser FD is initialized to -1

Daniel P. Berrangé posted 1 patch 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190927163603.24980-1-berrange@redhat.com
There is a newer version of this series
src/qemu/qemu_domain.c | 2 ++
1 file changed, 2 insertions(+)
[libvirt] [PATCH] qemu: ensure vhostuser FD is initialized to -1
Posted by Daniel P. Berrangé 4 years, 6 months ago
The video private data was not initializing the vhostuser FD
causing us to attempt to close FD 0 many times over.

Fixes

  commit ca60ecfa8cc1bd85baf7137dd1864d5f00f019f0
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   Mon Sep 23 14:44:36 2019 +0400

      qemu: add qemuDomainVideoPrivate

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/qemu/qemu_domain.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index bfd49beb21..bb81bda88e 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1336,6 +1336,8 @@ qemuDomainVideoPrivateNew(void)
     if (!(priv = virObjectNew(qemuDomainVideoPrivateClass)))
         return NULL;
 
+    priv->vhost_user_fd = -1;
+
     return (virObjectPtr) priv;
 }
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: ensure vhostuser FD is initialized to -1
Posted by Michal Prívozník 4 years, 6 months ago
On 9/27/19 6:36 PM, Daniel P. Berrangé wrote:
> The video private data was not initializing the vhostuser FD
> causing us to attempt to close FD 0 many times over.
> 
> Fixes
> 
>   commit ca60ecfa8cc1bd85baf7137dd1864d5f00f019f0
>   Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>   Date:   Mon Sep 23 14:44:36 2019 +0400
> 
>       qemu: add qemuDomainVideoPrivate
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: ensure vhostuser FD is initialized to -1
Posted by Daniel P. Berrangé 4 years, 5 months ago
On Sat, Sep 28, 2019 at 10:39:49PM +0200, Michal Prívozník wrote:
> On 9/27/19 6:36 PM, Daniel P. Berrangé wrote:
> > The video private data was not initializing the vhostuser FD
> > causing us to attempt to close FD 0 many times over.
> > 
> > Fixes
> > 
> >   commit ca60ecfa8cc1bd85baf7137dd1864d5f00f019f0
> >   Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> >   Date:   Mon Sep 23 14:44:36 2019 +0400
> > 
> >       qemu: add qemuDomainVideoPrivate
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  src/qemu/qemu_domain.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Seems life isn't quite as simple as this.  We break the test suite
as the FD we pass to QEMU is -1 now. 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list